Skip to content

Optimize qede use of Rx/Tx entries

Balazs Nemeth dpdk-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 1 replyIn review
  2. v18 patches 8 repliesSuperseded

Changes in v2 from the cover letter

- Fix checkpatches.sh warnings
- Fix check-git-log.sh warnings
- Add Reviewed-by: Igor Russkikh <[email protected]>

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7net/qede: remove flags from Tx entrydrivers/net/qede/qede_rxtx.c drivers/net/qede/qede_rxtx.h+13 -190 replies
2/7net/qede: get consumer index oncedrivers/net/qede/qede_rxtx.c+14 -80 replies
3/7net/qede: assume mbuf to free is never nulldrivers/net/qede/qede_rxtx.c+25 -340 replies
4/7net/qede: free packets in bulk instead of one by onedrivers/net/qede/qede_rxtx.c+11 -10 replies
5/7net/qede: prefetch hardware consumerdrivers/net/qede/qede_rxtx.c+1 -00 replies
6/7net/qede: prefetch next packet to freedrivers/net/qede/qede_rxtx.c+6 -00 replies
7/7net/qede: remove unnecessary field in Rx entry and simplifydrivers/net/qede/qede_rxtx.c drivers/net/qede/qede_rxtx.h+29 -380 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchIgor Russkikh
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [dpdk-dev] [PATCH v2 0/7] Optimize qede use of Rx/Tx entries

This patch set optimizes qede_{rx,tx}_entry and introduces rte_pktmbuf_free_bulk in qede_process_tx_compl. The overall performance improvement depends on the use-case; in a physical-virtual-physical test on a ThunderX2 99xx system with two SMT threads used in ovs, and two cores used in a vm, an improvement of around 2.55% is observed due to this patch set.

Changes in v2:
- Fix checkpatches.sh warnings
- Fix check-git-log.sh warnings
- Add Reviewed-by: Igor Russkikh <[email protected]>

Balazs Nemeth (7):
net/qede: remove flags from Tx entry
net/qede: get consumer index once
net/qede: assume mbuf to free is never null net/qede: free packets in bulk instead of one by one net/qede: prefetch hardware consumer
net/qede: prefetch next packet to free
net/qede: remove unnecessary field in Rx entry and simplify

 drivers/net/qede/qede_rxtx.c | 154 +++++++++++++++++++----------------
 drivers/net/qede/qede_rxtx.h |  21 +----
 2 files changed, 87 insertions(+), 88 deletions(-)

--
2.30.2