Skip to content

btrfs: bug fixes for the tree mod log and small refactorings

[email protected] linux-btrfs oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9btrfs: fix race when cloning extent buffer during rewind of an old rootfs/btrfs/ctree.c+2 -00 replies
2/9btrfs: always pin deleted leaves when there are active tree mod log usersfs/btrfs/extent-tree.c+22 -13 replies
3/9btrfs: move the tree mod log code into its own filefs/btrfs/Makefile fs/btrfs/backref.c fs/btrfs/ctree.c +5 more+1006 -9612 replies
4/9btrfs: use booleans where appropriate for the tree mod log functionsfs/btrfs/ctree.c fs/btrfs/tree-mod-log.c fs/btrfs/tree-mod-log.h+25 -251 reply
5/9btrfs: use a bit to track the existence of tree mod log usersfs/btrfs/ctree.h fs/btrfs/tree-mod-log.c+9 -52 replies
6/9btrfs: use the new bit BTRFS_FS_TREE_MOD_LOG_USERS at btrfs_free_tree_block()fs/btrfs/extent-tree.c+3 -50 replies
7/9btrfs: remove unnecessary leaf check at btrfs_tree_mod_log_free_eb()fs/btrfs/tree-mod-log.c+1 -40 replies
8/9btrfs: add and use helper to get lowest sequence number for the tree mod logfs/btrfs/delayed-ref.c fs/btrfs/tree-mod-log.c fs/btrfs/tree-mod-log.h+34 -230 replies
9/9btrfs: update debug message when checking seq number of a delayed reffs/btrfs/delayed-ref.c+2 -30 replies

Reviews trailers per patch

2 of 9 patches have a Reviewed-by or Acked-by.

PatchAnand Jain
1/9
2/9
3/9R-b
4/9R-b
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9] btrfs: bug fixes for the tree mod log and small refactorings

From: Filipe Manana <[email protected]>

This patchset fixes a couple bugs, in the two first patches, with the tree mod log code. The remaining patches just move all that code into a separate file, since it's quite large and ctree.c is huge as well, and do some small refactorings and cleanups.

One of the bugs in particular, has been hit frequently by Zygo, hitting a BUG_ON().

Filipe Manana (9):
btrfs: fix race when cloning extent buffer during rewind of an old
root
btrfs: always pin deleted leaves when there are active tree mod log
users
btrfs: move the tree mod log code into its own file
btrfs: use booleans where appropriate for the tree mod log functions
btrfs: use a bit to track the existence of tree mod log users
btrfs: use the new bit BTRFS_FS_TREE_MOD_LOG_USERS at
btrfs_free_tree_block()
btrfs: remove unnecessary leaf check at btrfs_tree_mod_log_free_eb()
btrfs: add and use helper to get lowest sequence number for the tree
mod log
btrfs: update debug message when checking seq number of a delayed ref

 fs/btrfs/Makefile       |   2 +-
 fs/btrfs/backref.c      |  33 +-
 fs/btrfs/ctree.c        | 954 ++--------------------------------------
 fs/btrfs/ctree.h        |  20 +-
 fs/btrfs/delayed-ref.c  |  31 +-
 fs/btrfs/extent-tree.c  |  21 +-
 fs/btrfs/qgroup.c       |   9 +-
 fs/btrfs/tree-mod-log.c | 912 ++++++++++++++++++++++++++++++++++++++
 fs/btrfs/tree-mod-log.h |  53 +++
 9 files changed, 1056 insertions(+), 979 deletions(-)
 create mode 100644 fs/btrfs/tree-mod-log.c
 create mode 100644 fs/btrfs/tree-mod-log.h
Signature · 1 line
2.28.0