Handle bad dev_root properly with rescue=all
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 11 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | btrfs: init devices alwaysfs/ | +1 | 4 replies | |
| 2/3 | btrfs: do not init dev stats if we have no dev_rootfs/ | +3 | 1 reply | |
| 3/3 | btrfs: don't init dev replace for bad dev rootfs/ | +3 | 1 reply |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Neal Gompa | Anand Jain |
|---|---|---|
| Series | R-b | |
| 1/3 | R-b | |
| 2/3 | R-b | |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] Handle bad dev_root properly with rescue=all
Hello,
My recent debugging session with Neal's broken filesystem uncovered a glaring hole in my rescue=all patches, they don't deal with a NULL dev_root properly. In testing I only ever tested corrupting the extent tree or the csum tree, since those are the most problematic. The following 3 fixes allowed Neal to get rescue=all working without panicing the machine, and I verified everything by using btrfs-corrupt-block to corrupt a dev root of a file system. Thanks,
Josef
Josef Bacik (3):
btrfs: init devices always
btrfs: do not init dev stats if we have no dev_root
btrfs: don't init dev replace for bad dev root
fs/btrfs/dev-replace.c | 3 +++ fs/btrfs/disk-io.c | 2 +- fs/btrfs/volumes.c | 3 +++ 3 files changed, 7 insertions(+), 1 deletion(-)
Signature · 1 line
2.26.2