Skip to content

staging: rtl8723bs: fix checkpatch errors on macros

Fabio Aiuto linux-staging lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15staging: rtl8723bs: inlcude macros in a do..while loop in core/rtw_security.cdrivers/staging/rtl8723bs/core/rtw_security.c+54 -402 replies
2/15staging: rtl8723bs: put parentheses on macros with complex values in hal/HalBtcOutSrc.hdrivers/staging/rtl8723bs/hal/HalBtcOutSrc.h+3 -32 replies
3/15staging: rtl8723bs: put parentheses on macros with complex values in hal/odm_debug.hdrivers/staging/rtl8723bs/hal/odm_debug.h+3 -30 replies
4/15staging: rtl8723bs: put parentheses on macros with complex values in include/basic_types.hdrivers/staging/rtl8723bs/include/basic_types.h+18 -123 replies
5/15staging: rtl8723bs: put parentheses on macros with complex values in include/drv_types.hdrivers/staging/rtl8723bs/include/drv_types.h+2 -22 replies
6/15staging: rtl8723bs: put parentheses on macros with complex values in include/hal_com.hdrivers/staging/rtl8723bs/include/hal_com.h+4 -40 replies
7/15staging: rtl8723bs: put parentheses on macros with complex values in include/hal_com_reg.hdrivers/staging/rtl8723bs/include/hal_com_reg.h+7 -70 replies
8/15staging: rtl8723bs: put parentheses on macros with complex values in include/hal_data.hdrivers/staging/rtl8723bs/include/hal_data.h+3 -30 replies
9/15staging: rtl8723bs: put parentheses on macros with complex values in include/hal_phy.hdrivers/staging/rtl8723bs/include/hal_phy.h+1 -10 replies
10/15staging: rtl8723bs: put parentheses on macros with complex values in include/ieee80211.hdrivers/staging/rtl8723bs/include/ieee80211.h+2 -20 replies
11/15staging: rtl8723bs: put parentheses on macros with complex values in include/rtw_debug.hdrivers/staging/rtl8723bs/include/rtw_debug.h+15 -130 replies
12/15staging: rtl8723bs: put parentheses on macros with complex values in include/rtw_pwrctrl.hdrivers/staging/rtl8723bs/include/rtw_pwrctrl.h+3 -30 replies
13/15staging: rtl8723bs: add spaces around operator in include/rtw_pwrctrl.hdrivers/staging/rtl8723bs/include/rtw_pwrctrl.h+1 -10 replies
14/15staging: rtl8723bs: put parentheses on macros with complex values in include/sta_info.hdrivers/staging/rtl8723bs/include/sta_info.h+6 -62 replies
15/15staging: rtl8723bs: put parentheses on macros with complex values in include/wifi.hdrivers/staging/rtl8723bs/include/wifi.h+19 -190 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/15] staging: rtl8723bs: fix checkpatch errors on macros

Fix all checkpatch errors on macros but the following:

ERROR: Macros with complex values should be enclosed in parentheses #41: FILE: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:41:
+#define RTL8723B_TRANS_CARDEMU_TO_ACT \
--
ERROR: Macros with complex values should be enclosed in parentheses #67: FILE: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:67:
+#define RTL8723B_TRANS_ACT_TO_CARDEMU \
--
ERROR: Macros with complex values should be enclosed in parentheses #80: FILE: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:80:
+#define RTL8723B_TRANS_CARDEMU_TO_SUS \
--
ERROR: Macros with complex values should be enclosed in parentheses #91: FILE: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:91:
+#define RTL8723B_TRANS_SUS_TO_CARDEMU \
--
ERROR: Macros with complex values should be enclosed in parentheses #100: FILE: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:100:
+#define RTL8723B_TRANS_CARDEMU_TO_CARDDIS \
--
ERROR: Macros with complex values should be enclosed in parentheses #111: FILE: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:111:
+#define RTL8723B_TRANS_CARDDIS_TO_CARDEMU \
--
ERROR: Macros with complex values should be enclosed in parentheses #123: FILE: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:123:
+#define RTL8723B_TRANS_CARDEMU_TO_PDN \
--
ERROR: Macros with complex values should be enclosed in parentheses #136: FILE: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:136:
+#define RTL8723B_TRANS_ACT_TO_LPS \
--
ERROR: Macros with complex values should be enclosed in parentheses #154: FILE: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:154:
+#define RTL8723B_TRANS_LPS_TO_ACT \
--
ERROR: Macros with complex values should be enclosed in parentheses #170: FILE: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:170:
+ #define RTL8723B_TRANS_ACT_TO_SWLPS \
--
ERROR: Macros with complex values should be enclosed in parentheses #197: FILE: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:197:
+#define RTL8723B_TRANS_SWLPS_TO_ACT \
--

I counld't put braces for they are meant to be expanded inside an array definition

ERROR: Macros with complex values should be enclosed in parentheses #108: FILE: drivers/staging/rtl8723bs/include/osdep_service_linux.h:108:
+#define FUNC_NDEV_ARG(ndev) __func__, ndev->name
--
ERROR: Macros with complex values should be enclosed in parentheses #110: FILE: drivers/staging/rtl8723bs/include/osdep_service_linux.h:110:
+#define FUNC_ADPT_ARG(adapter) __func__, adapter->pnetdev->nam

All those macros are not used to generate expressions but arguments of a functions.

If someone knows how to silence those errors as well, please tell me.

Fabio Aiuto (15):
staging: rtl8723bs: inlcude macros in a do..while loop in
core/rtw_security.c
staging: rtl8723bs: put parentheses on macros with complex values in
hal/HalBtcOutSrc.h
staging: rtl8723bs: put parentheses on macros with complex values in
hal/odm_debug.h
staging: rtl8723bs: put parentheses on macros with complex values in
include/basic_types.h
staging: rtl8723bs: put parentheses on macros with complex values in
include/drv_types.h
staging: rtl8723bs: put parentheses on macros with complex values in
include/hal_com.h
staging: rtl8723bs: put parentheses on macros with complex values in
include/hal_com_reg.h
staging: rtl8723bs: put parentheses on macros with complex values in
include/hal_data.h
staging: rtl8723bs: put parentheses on macros with complex values in
include/hal_phy.h
staging: rtl8723bs: put parentheses on macros with complex values in

    include/ieee80211.h

staging: rtl8723bs: put parentheses on macros with complex values in
include/rtw_debug.h
staging: rtl8723bs: put parentheses on macros with complex values in
include/rtw_pwrctrl.h
staging: rtl8723bs: add spaces around operator in
include/rtw_pwrctrl.h
staging: rtl8723bs: put parentheses on macros with complex values in
include/sta_info.h
staging: rtl8723bs: put parentheses on macros with complex values in
include/wifi.h

 drivers/staging/rtl8723bs/core/rtw_security.c | 94 +++++++++++--------
 drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h  |  6 +-
 drivers/staging/rtl8723bs/hal/odm_debug.h     |  6 +-
 .../staging/rtl8723bs/include/basic_types.h   | 30 +++---
 drivers/staging/rtl8723bs/include/drv_types.h |  4 +-
 drivers/staging/rtl8723bs/include/hal_com.h   |  8 +-
 .../staging/rtl8723bs/include/hal_com_reg.h   | 14 +--
 drivers/staging/rtl8723bs/include/hal_data.h  |  6 +-
 drivers/staging/rtl8723bs/include/hal_phy.h   |  2 +-
 drivers/staging/rtl8723bs/include/ieee80211.h |  4 +-
 drivers/staging/rtl8723bs/include/rtw_debug.h | 28 +++---
 .../staging/rtl8723bs/include/rtw_pwrctrl.h   |  6 +-
 drivers/staging/rtl8723bs/include/sta_info.h  | 12 +--
 drivers/staging/rtl8723bs/include/wifi.h      | 38 ++++----
 14 files changed, 140 insertions(+), 118 deletions(-)
Signature · 1 line
2.20.1