Skip to content

fix checkpatch error on macros

Fabio Aiuto linux-staging lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest20 patches 6 repliesIn review

Changes in v2 from the cover letter

- deleted unused macros
- ignored following checkpatch issues on macro:
* issues requiring to add parentheses to macro expanding in args of a function
* issues requiring to add parentheses to very complex and unreadable macro

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20staging: rtl8723bs: remove unused macros in include/hal_com.hdrivers/staging/rtl8723bs/include/hal_com.h+0 -40 replies
2/20staging: rtl8723bs: put parentheses on macro with complex values in include/hal_com.hdrivers/staging/rtl8723bs/include/hal_com.h+1 -10 replies
3/20staging: rtl8723bs: added spaces around operators in a macro in include/hal_com.hdrivers/staging/rtl8723bs/include/hal_com.h+1 -10 replies
4/20staging: rtl8723bs: remove unused macros in include/hal_com_reg.hdrivers/staging/rtl8723bs/include/hal_com_reg.h+0 -80 replies
5/20staging: rtl8723bs: remove unused macros in include/hal_data.hdrivers/staging/rtl8723bs/include/hal_data.h+0 -70 replies
6/20staging: rtl8723bs: put parentheses on macros with complex values in include/hal_data.hdrivers/staging/rtl8723bs/include/hal_data.h+1 -10 replies
7/20staging: rtl8723bs: add spaces around operators in include/hal_data.hdrivers/staging/rtl8723bs/include/hal_data.h+1 -10 replies
8/20staging: rtl8723bs: remove unused macros in include/hal_phy.hdrivers/staging/rtl8723bs/include/hal_phy.h+0 -110 replies
9/20staging: rtl8723bs: put parentheses on macros with complex values in include/rtw_debug.hdrivers/staging/rtl8723bs/include/rtw_debug.h+15 -134 replies
10/20staging: rtl8723bs: remove unused macro in include/rtw_pwrctrl.hdrivers/staging/rtl8723bs/include/rtw_pwrctrl.h+0 -30 replies
11/20staging: rtl8723bs: remove unused field in rereg_nd_name_data structdrivers/staging/rtl8723bs/include/drv_types.h+0 -10 replies
12/20staging: rtl8723bs: remove commented code line in os_dep/ioctl_linux.cdrivers/staging/rtl8723bs/os_dep/ioctl_linux.c+0 -10 replies
13/20staging: rtl8723bs: put parentheses on macros with complex values in include/rtw_pwrctrl.hdrivers/staging/rtl8723bs/include/rtw_pwrctrl.h+2 -20 replies
14/20staging: rtl8723bs: add spaces around operator in include/rtw_pwrctrl.hdrivers/staging/rtl8723bs/include/rtw_pwrctrl.h+1 -10 replies
15/20staging: rtl8723bs: remove unused macros in include/wifi.hdrivers/staging/rtl8723bs/include/wifi.h+0 -200 replies
16/20staging: rtl8723bs: put parentheses on macros with complex values in include/wifi.hdrivers/staging/rtl8723bs/include/wifi.h+14 -140 replies
17/20staging: rtl8723bs: remove macros updating unused fields in struct security_privdrivers/staging/rtl8723bs/core/rtw_security.c+0 -680 replies
18/20staging: rtl8723bs: remove unused fields in struct security_privdrivers/staging/rtl8723bs/include/rtw_security.h+0 -230 replies
19/20staging: rtl8723bs: include macro in a do - while loop in core/rtw_security.cdrivers/staging/rtl8723bs/core/rtw_security.c+6 -42 replies
20/20staging: rtl8723bs: remove unused macros in include/drv_types.cdrivers/staging/rtl8723bs/include/drv_types.h+0 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/20] fix checkpatch error on macros

this patchset fixes, where possible, some checkpatch errors on macros. Delete unused macros and some unused struct fields tied
to removed macros.

Changes in v2:
- deleted unused macros
- ignored following checkpatch issues on macro:
* issues requiring to add parentheses to macro expanding in args of a function
* issues requiring to add parentheses to very complex and unreadable macro

Fabio Aiuto (20):
staging: rtl8723bs: remove unused macros in include/hal_com.h
staging: rtl8723bs: put parentheses on macro with complex values in
include/hal_com.h
staging: rtl8723bs: added spaces around operators in a macro in
include/hal_com.h
staging: rtl8723bs: remove unused macros in include/hal_com_reg.h
staging: rtl8723bs: remove unused macros in include/hal_data.h
staging: rtl8723bs: put parentheses on macros with complex values in
include/hal_data.h
staging: rtl8723bs: add spaces around operators in include/hal_data.h
staging: rtl8723bs: remove unused macros in include/hal_phy.h
staging: rtl8723bs: put parentheses on macros with complex values in
include/rtw_debug.h
staging: rtl8723bs: remove unused macro in include/rtw_pwrctrl.h
staging: rtl8723bs: remove unused field in rereg_nd_name_data struct
staging: rtl8723bs: remove commented code line in os_dep/ioctl_linux.c
staging: rtl8723bs: put parentheses on macros with complex values in
include/rtw_pwrctrl.h
staging: rtl8723bs: add spaces around operator in
include/rtw_pwrctrl.h
staging: rtl8723bs: remove unused macros in include/wifi.h
staging: rtl8723bs: put parentheses on macros with complex values in
include/wifi.h
staging: rtl8723bs: remove macros updating unused fields in struct
security_priv
staging: rtl8723bs: remove unused fields in struct security_priv
staging: rtl8723bs: include macro in a do - while loop in
core/rtw_security.c
staging: rtl8723bs: remove unused macros in include/drv_types.c

 drivers/staging/rtl8723bs/core/rtw_security.c | 78 ++-----------------
 drivers/staging/rtl8723bs/include/drv_types.h |  6 --
 drivers/staging/rtl8723bs/include/hal_com.h   |  6 +-
 .../staging/rtl8723bs/include/hal_com_reg.h   |  8 --
 drivers/staging/rtl8723bs/include/hal_data.h  |  9 +--
 drivers/staging/rtl8723bs/include/hal_phy.h   | 11 ---
 drivers/staging/rtl8723bs/include/rtw_debug.h | 28 +++----
 .../staging/rtl8723bs/include/rtw_pwrctrl.h   |  7 +-
 .../staging/rtl8723bs/include/rtw_security.h  | 23 ------
 drivers/staging/rtl8723bs/include/wifi.h      | 48 ++++--------
 .../staging/rtl8723bs/os_dep/ioctl_linux.c    |  1 -
 11 files changed, 39 insertions(+), 186 deletions(-)
Signature · 1 line
2.20.1