Skip to content

Fix out-of-bounds warnings

Gustavo A. R. Silva linux-hardening linux-wireless lkml netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 4 repliesIn review
  2. v22 patches 6 repliesSuperseded
  3. v12 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- Add new struct wl3501_req.
- Update changelog text in patch 2/2.
- Add Kees' RB tag to patch 1/2.
- Fix one more instance of this same issue in both patches.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2wl3501_cs: Fix out-of-bounds warnings in wl3501_send_pktdrivers/net/wireless/wl3501.h drivers/net/wireless/wl3501_cs.c+14 -82 replies
2/2wl3501_cs: Fix out-of-bounds warnings in wl3501_mgmt_joindrivers/net/wireless/wl3501.h drivers/net/wireless/wl3501_cs.c+38 -412 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchKees Cook
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] Fix out-of-bounds warnings

Fix multiple out-of-bounds warnings by making the code a bit more structured.

This helps with the ongoing efforts to globally enable -Warray-bounds and get us closer to being able to tighten the FORTIFY_SOURCE routines on memcpy().

Changes in v3:
- Add new struct wl3501_req.
- Update changelog text in patch 2/2.
- Add Kees' RB tag to patch 1/2.
- Fix one more instance of this same issue in both patches.

Changes in v2:
- Update changelog text in patch 1/2.
- Replace a couple of magic numbers with new variable sig_addr_len.

Gustavo A. R. Silva (2):
wl3501_cs: Fix out-of-bounds warnings in wl3501_send_pkt
wl3501_cs: Fix out-of-bounds warnings in wl3501_mgmt_join

 drivers/net/wireless/wl3501.h    | 47 ++++++++++++++-------------
 drivers/net/wireless/wl3501_cs.c | 54 +++++++++++++++++---------------
 2 files changed, 52 insertions(+), 49 deletions(-)
Signature · 1 line
2.27.0