Skip to content

staging: rtl8723bs: remove RT_TRACE logs in core/*

Fabio Aiuto linux-staging lkml 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest30 patches 0 repliesNew
  2. v330 patches 10 repliesSuperseded
  3. v230 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v116 patches10 repliesSuperseded

Changes in v4 from the cover letter

- completed checkpatch fix in if condition
- fix reference in Suggested-by: tag

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/30staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.cdrivers/staging/rtl8723bs/core/rtw_xmit.c+7 -750 replies
2/30staging: rtl8723bs: fix condition in if statement in core/rtw_xmit.cdrivers/staging/rtl8723bs/core/rtw_xmit.c+1 -10 replies
3/30staging: rtl8723bs: remove RT_TRACE logs in core/rtw_security.cdrivers/staging/rtl8723bs/core/rtw_security.c+1 -390 replies
4/30staging: rtl8723bs: fix line exceed warning in core/rtw_security.cdrivers/staging/rtl8723bs/core/rtw_security.c+2 -10 replies
5/30staging: rtl8723bs: fix spaces around operator issues in core/rtw_security.cdrivers/staging/rtl8723bs/core/rtw_security.c+2 -20 replies
6/30staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_eeprom.cdrivers/staging/rtl8723bs/core/rtw_eeprom.c+22 -340 replies
7/30staging: rtl8723bs: fix error prone if conditions in core/rtw_eeprom.cdrivers/staging/rtl8723bs/core/rtw_eeprom.c+11 -110 replies
8/30staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_pwrctrl.cdrivers/staging/rtl8723bs/core/rtw_pwrctrl.c+4 -500 replies
9/30staging: rtl8723bs: fix logical continuation issue in core/rtw_pwrctrl.cdrivers/staging/rtl8723bs/core/rtw_pwrctrl.c+2 -20 replies
10/30staging: rtl8723bs: remove unnecessary parentheses in if-condition in core/rtw_pwrctrl.cdrivers/staging/rtl8723bs/core/rtw_pwrctrl.c+2 -20 replies
11/30staging: rtl8723bs: remove RT_TRACE logs in core/rtw_cmd.cdrivers/staging/rtl8723bs/core/rtw_cmd.c+6 -470 replies
12/30staging: rtl8723bs: fix null check conditions in core/rtw_cmd.cdrivers/staging/rtl8723bs/core/rtw_cmd.c+3 -30 replies
13/30staging: rtl8723bs: remove unnecessary parentheses in if condition in core/rtw_cmd.cdrivers/staging/rtl8723bs/core/rtw_cmd.c+1 -10 replies
14/30staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_mlme.cdrivers/staging/rtl8723bs/core/rtw_mlme.c+0 -60 replies
15/30staging: rtl8723bs: remove RT_TRACE logs in core/rtw_mlme.cdrivers/staging/rtl8723bs/core/rtw_mlme.c+15 -900 replies
16/30staging: rtl8723bs: tidy up some error handling in core/rtw_mlme.cdrivers/staging/rtl8723bs/core/rtw_mlme.c+11 -60 replies
17/30staging: rtl8723bs: remove RT_TRACE logs in core/rtw_mlme_ext.cdrivers/staging/rtl8723bs/core/rtw_mlme_ext.c+5 -340 replies
18/30staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_recv.cdrivers/staging/rtl8723bs/core/rtw_recv.c+0 -120 replies
19/30staging: rtl8723bs: remove RT_TRACE logs in core/rtw_recv.cdrivers/staging/rtl8723bs/core/rtw_recv.c+6 -1280 replies
20/30staging: rtl8723bs: added spaces around operator in core/rtw_recv.cdrivers/staging/rtl8723bs/core/rtw_recv.c+1 -10 replies
21/30staging: rtl8723bs: split long line in core/rtw_recv.cdrivers/staging/rtl8723bs/core/rtw_recv.c+2 -10 replies
22/30staging: rtl8723bs: remove unnecessary parentheses in core/rtw_recv.cdrivers/staging/rtl8723bs/core/rtw_recv.c+2 -20 replies
23/30staging: rtl8723bs: fix comparison in if condition in core/rtw_recv.cdrivers/staging/rtl8723bs/core/rtw_recv.c+2 -20 replies
24/30staging: rtl8723bs: remove commented RT_TRACE call in core/rtw_ioctl_set.cdrivers/staging/rtl8723bs/core/rtw_ioctl_set.c+0 -30 replies
25/30staging: rtl8723bs: remove RT_TRACE logs in core/rtw_ioctl_set.cdrivers/staging/rtl8723bs/core/rtw_ioctl_set.c+4 -720 replies
26/30staging: rtl8723bs: place constant on the right side of the test in core/rtw_ioctl_set.cdrivers/staging/rtl8723bs/core/rtw_ioctl_set.c+2 -20 replies
27/30staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_wlan_util.cdrivers/staging/rtl8723bs/core/rtw_wlan_util.c+4 -200 replies
28/30staging: rtl8723bs: remove RT_TRACE logs in core/rtw_sta_mgt.cdrivers/staging/rtl8723bs/core/rtw_sta_mgt.c+0 -250 replies
29/30staging: rtl8723bs: remove RT_TRACE logs in core/rtw_ieee80211.cdrivers/staging/rtl8723bs/core/rtw_ieee80211.c+15 -750 replies
30/30staging: rtl8723bs: add spaces around operators in core/rtw_ieee80211.cdrivers/staging/rtl8723bs/core/rtw_ieee80211.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 00/30] staging: rtl8723bs: remove RT_TRACE logs in core/*

This patchset removes all RT_TRACE usages in core/ files.

This is the first of a series aimed at removing RT_TRACE macro.

The whole private tracing system is not tied to a configuration symbol and the default behaviour is _trace nothing_. It's verbose and relies on a private log level tracing doomed to be removed.

-------------------------------
Changes in v4:
- completed checkpatch fix in if condition
- fix reference in Suggested-by: tag

Changes in v3:
- written better changelog in single patches

Changes in v2:
- isolate checkpatch fixes in separate patches
- removed two if conditions in core/rtw_wlan_util.c

Fabio Aiuto (30):
staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c
staging: rtl8723bs: fix condition in if statement in core/rtw_xmit.c
staging: rtl8723bs: remove RT_TRACE logs in core/rtw_security.c
staging: rtl8723bs: fix line exceed warning in core/rtw_security.c
staging: rtl8723bs: fix spaces around operator issues in
core/rtw_security.c
staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_eeprom.c
staging: rtl8723bs: fix error prone if conditions in core/rtw_eeprom.c
staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_pwrctrl.c
staging: rtl8723bs: fix logical continuation issue in
core/rtw_pwrctrl.c
staging: rtl8723bs: remove unnecessary parentheses in if-condition in
core/rtw_pwrctrl.c
staging: rtl8723bs: remove RT_TRACE logs in core/rtw_cmd.c
staging: rtl8723bs: fix null check conditions in core/rtw_cmd.c
staging: rtl8723bs: remove unnecessary parentheses in if condition in
core/rtw_cmd.c
staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_mlme.c
staging: rtl8723bs: remove RT_TRACE logs in core/rtw_mlme.c
staging: rtl8723bs: tidy up some error handling in core/rtw_mlme.c
staging: rtl8723bs: remove RT_TRACE logs in core/rtw_mlme_ext.c
staging: rtl8723bs: remove commented RT_TRACE calls in core/rtw_recv.c
staging: rtl8723bs: remove RT_TRACE logs in core/rtw_recv.c
staging: rtl8723bs: added spaces around operator in core/rtw_recv.c
staging: rtl8723bs: split long line in core/rtw_recv.c
staging: rtl8723bs: remove unnecessary parentheses in core/rtw_recv.c
staging: rtl8723bs: fix comparison in if condition in core/rtw_recv.c
staging: rtl8723bs: remove commented RT_TRACE call in
core/rtw_ioctl_set.c
staging: rtl8723bs: remove RT_TRACE logs in core/rtw_ioctl_set.c
staging: rtl8723bs: place constant on the right side of the test in
core/rtw_ioctl_set.c
staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_wlan_util.c
staging: rtl8723bs: remove RT_TRACE logs in core/rtw_sta_mgt.c
staging: rtl8723bs: remove RT_TRACE logs in core/rtw_ieee80211.c
staging: rtl8723bs: add spaces around operators in

    core/rtw_ieee80211.c
 drivers/staging/rtl8723bs/core/rtw_cmd.c      |  53 +------
 drivers/staging/rtl8723bs/core/rtw_eeprom.c   |  56 +++----
 .../staging/rtl8723bs/core/rtw_ieee80211.c    |  90 ++---------
 .../staging/rtl8723bs/core/rtw_ioctl_set.c    |  79 +---------
 drivers/staging/rtl8723bs/core/rtw_mlme.c     | 124 +++------------
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |  39 +----
 drivers/staging/rtl8723bs/core/rtw_pwrctrl.c  |  56 +------
 drivers/staging/rtl8723bs/core/rtw_recv.c     | 147 +-----------------
 drivers/staging/rtl8723bs/core/rtw_security.c |  41 +----
 drivers/staging/rtl8723bs/core/rtw_sta_mgt.c  |  25 ---
 .../staging/rtl8723bs/core/rtw_wlan_util.c    |  24 +--
 drivers/staging/rtl8723bs/core/rtw_xmit.c     |  82 +---------
 12 files changed, 101 insertions(+), 715 deletions(-)
Signature · 1 line
2.20.1