Skip to content

staging: rtl8723bs: completely remove RT_TRACE logs

Fabio Aiuto linux-staging lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10staging: rtl8723bs: remove all RT_TRACE logs in hal/ and os_dep/drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c drivers/staging/rtl8723bs/hal/hal_intf.c drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +13 more+3 -4080 replies
2/10staging: rtl8723bs: remove commented out RT_TRACE logs in hal/ and os_dep/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c drivers/staging/rtl8723bs/hal/hal_com_phycfg.c drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +2 more+0 -202 replies
3/10staging: rtl8723bs: remove RT_TRACE log definitionsdrivers/staging/rtl8723bs/include/rtw_debug.h+0 -180 replies
4/10staging: rtl8723bs: remove empty if, else blocks after RT_TRACE deletiondrivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c +1 more+1 -250 replies
5/10staging: rtl8723bs: remove empty #ifdef blocks after RT_TRACE deletiondrivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c+0 -50 replies
6/10staging: rtl8723bs: remove unnecessary bracks after RT_TRACE deletiondrivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c drivers/staging/rtl8723bs/hal/sdio_halinit.c +6 more+23 -420 replies
7/10staging: rtl8723bs: place constant on the right side of the testdrivers/staging/rtl8723bs/hal/sdio_halinit.c+1 -10 replies
8/10staging: rtl8723bs: rewrite comparisons to nulldrivers/staging/rtl8723bs/os_dep/ioctl_linux.c drivers/staging/rtl8723bs/os_dep/recv_linux.c drivers/staging/rtl8723bs/os_dep/sdio_intf.c+3 -30 replies
9/10staging: rtl8723bs: remove empty for cyclesdrivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c+0 -70 replies
10/10staging: rtl8723bs: remove commented code blockdrivers/staging/rtl8723bs/hal/hal_com_phycfg.c+0 -190 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/10] staging: rtl8723bs: completely remove RT_TRACE logs

This patchset removes all RT_TRACE usages left and definitions

The whole private tracing system is not tied to a configuration symbol and the default behaviour is _trace nothing_. It's verbose and relies on a private log level tracing doomed to be removed.

The patchset consist on a first patch applying the following semantic patch on rtl8723bs directory:

$ cat RT_TRACE.cocci
@@
expression a, b, c;
@@

- RT_TRACE(a, b, (c));

Then follows a patch removing commented out RT_TRACE calls. Third patch removes RT_TRACE definitions.

All other patches, do some code cleaning on sites left blank by RT_TRACE removal.

This scheme was suggested by Joe Perches.

https://lore.kernel.org/linux-staging/[email protected]/

Fabio Aiuto (10):
staging: rtl8723bs: remove all RT_TRACE logs in hal/ and os_dep/
staging: rtl8723bs: remove commented out RT_TRACE logs in hal/ and

    os_dep/

staging: rtl8723bs: remove RT_TRACE log definitions
staging: rtl8723bs: remove empty if, else blocks after RT_TRACE
deletion
staging: rtl8723bs: remove empty #ifdef blocks after RT_TRACE deletion
staging: rtl8723bs: remove unnecessary bracks after RT_TRACE deletion
staging: rtl8723bs: place constant on the right side of the test
staging: rtl8723bs: rewrite comparisons to null
staging: rtl8723bs: remove empty for cycles
staging: rtl8723bs: remove commented code block

 .../staging/rtl8723bs/hal/HalPhyRf_8723B.c    |   3 -
 drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c  |  46 ------
 .../staging/rtl8723bs/hal/hal_com_phycfg.c    |  20 ---
 drivers/staging/rtl8723bs/hal/hal_intf.c      |   2 -
 .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 131 +-----------------
 .../staging/rtl8723bs/hal/rtl8723b_phycfg.c   |  33 -----
 .../staging/rtl8723bs/hal/rtl8723b_rf6052.c   |   2 -
 .../staging/rtl8723bs/hal/rtl8723bs_recv.c    |   5 +-
 .../staging/rtl8723bs/hal/rtl8723bs_xmit.c    |  41 +-----
 drivers/staging/rtl8723bs/hal/sdio_halinit.c  |  49 +------
 drivers/staging/rtl8723bs/hal/sdio_ops.c      |  35 +----
 drivers/staging/rtl8723bs/include/rtw_debug.h |  18 ---
 .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c |   6 -
 .../staging/rtl8723bs/os_dep/ioctl_linux.c    |  69 +--------
 drivers/staging/rtl8723bs/os_dep/mlme_linux.c |   4 -
 drivers/staging/rtl8723bs/os_dep/os_intfs.c   |  52 +------
 .../staging/rtl8723bs/os_dep/osdep_service.c  |   4 +-
 drivers/staging/rtl8723bs/os_dep/recv_linux.c |  12 +-
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c  |  28 +---
 drivers/staging/rtl8723bs/os_dep/xmit_linux.c |   5 -
 20 files changed, 24 insertions(+), 541 deletions(-)
Signature · 1 line
2.20.1