Skip to content

staging: rtl8723bs: remove unused variables

Fabio Aiuto linux-staging lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11staging: rtl8723bs: remove unused variable in core/rtw_cmd.cdrivers/staging/rtl8723bs/core/rtw_cmd.c+0 -30 replies
2/11staging: rtl8723bs: remove unused variable and empty for cycles left unused in os_dep/ioctl_linux.cdrivers/staging/rtl8723bs/os_dep/ioctl_linux.c+1 -60 replies
3/11staging: rtl8723bs: remove unused code block in os_dep/ioctl_linux.cdrivers/staging/rtl8723bs/os_dep/ioctl_linux.c+0 -200 replies
4/11staging: rtl8723bs: remove unused variables and code block left unused in os_dep/ioctl_linux.cdrivers/staging/rtl8723bs/os_dep/ioctl_linux.c+0 -80 replies
5/11staging: rtl8723bs: remove set but unused psta variable in rtw_dbg_port() in os_dep/ioctl_linux.cdrivers/staging/rtl8723bs/os_dep/ioctl_linux.c+0 -20 replies
6/11staging: rtl8723bs: remove unused variable pstapriv in rtw_dbg_port() in os_dep/ioctl_linux.cdrivers/staging/rtl8723bs/os_dep/ioctl_linux.c+0 -20 replies
7/11staging: rtl8723bs: remove unused cur_network variable in rtw_dbg_port() in os_dep/ioctl_linux.cdrivers/staging/rtl8723bs/os_dep/ioctl_linux.c+0 -10 replies
8/11staging: rtl8723bs: remove unused pmlmepriv variable in rtw_dbg_port() in os_dep/ioctl_linux.cdrivers/staging/rtl8723bs/os_dep/ioctl_linux.c+0 -10 replies
9/11staging: rtl8723bs: remove unused variable declaration in include/rtw_security.hdrivers/staging/rtl8723bs/include/rtw_security.h+0 -180 replies
10/11staging: rtl8723bs: remove unused variable in os_dep/ioctl_linux.cdrivers/staging/rtl8723bs/os_dep/ioctl_linux.c+0 -30 replies
11/11staging: rtl8723bs: remove decl of unused static const variable in os_dep/ioctl_linux.cdrivers/staging/rtl8723bs/os_dep/ioctl_linux.c+0 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/11] staging: rtl8723bs: remove unused variables

This patchset fixes some issues warned from kernel test robot in reply to the following patch:

https://lore.kernel.org/linux-staging/56055b20bc064d7ac1e8f14bd1ed42aba6b02c36.1617802415.git.fabioaiuto83@gmail.com/

This is kernel robot output:

If you fix the issue, kindly add following tag as appropriate

All warnings (new ones prefixed by >>):

drivers/staging/rtl8723bs/core/rtw_cmd.c: In function 'rtw_cmd_thread':

Quoted 1 line
Quoted 1 line

drivers/staging/rtl8723bs/core/rtw_cmd.c:390:16: warning: variable 'cmd_start_time' set but not used [-Wunused-but-set-variable]

     390 |  unsigned long cmd_start_time;
         |                ^~~~~~~~~~~~~~
   In file included from drivers/staging/rtl8723bs/include/drv_types.h:33,
                    from drivers/staging/rtl8723bs/core/rtw_cmd.c:9:
   At top level:
   drivers/staging/rtl8723bs/include/rtw_security.h:336:28: warning: 'K' defined but not used [-Wunused-const-variable=]
     336 | static const unsigned long K[64] = {
         |                            ^
--
   drivers/staging/rtl8723bs/os_dep/ioctl_linux.c: In function 'rtw_wx_set_mlme':
   drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:1136:6: warning: variable 'reason' set but not used [-Wunused-but-set-variable]
    1136 |  u16 reason;
         |      ^~~~~~

drivers/staging/rtl8723bs/os_dep/ioctl_linux.c: In function 'rtw_dbg_port':

Quoted 1 line
Quoted 1 line

drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2575:33: warning: variable 'preorder_ctrl' set but not used

+[-Wunused-but-set-variable]

    2575 |       struct recv_reorder_ctrl *preorder_ctrl;
         |                                 ^~~~~~~~~~~~~
   drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2601:33: warning: variable 'preorder_ctrl' set but not used
+[-Wunused-but-set-variable]
    2601 |       struct recv_reorder_ctrl *preorder_ctrl;
         |                                 ^~~~~~~~~~~~~
   At top level:
   drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:36:27: warning: 'iw_operation_mode' defined but not used [-Wunused-const-variable=]
      36 | static const char * const iw_operation_mode[] = {
         |                           ^~~~~~~~~~~~~~~~~
   In file included from drivers/staging/rtl8723bs/include/drv_types.h:33,
                    from drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:10:
   drivers/staging/rtl8723bs/include/rtw_security.h:336:28: warning: 'K' defined but not used [-Wunused-const-variable=]
     336 | static const unsigned long K[64] = {
         |                            ^

First and fourth patch remove these two issues introduced by the patch above.

Other patches fix other local issues described in kernel test robot output and other local 'make W=1' compiler warnings.

Unnecessary code blocks are removed as well.

Fabio Aiuto (11):
staging: rtl8723bs: remove unused variable in core/rtw_cmd.c
staging: rtl8723bs: remove unused variable and empty for cycles left
unused in os_dep/ioctl_linux.c
staging: rtl8723bs: remove unused code block in os_dep/ioctl_linux.c
staging: rtl8723bs: remove unused variables and code block left unused
in os_dep/ioctl_linux.c
staging: rtl8723bs: remove set but unused psta variable in
rtw_dbg_port() in os_dep/ioctl_linux.c
staging: rtl8723bs: remove unused variable pstapriv in rtw_dbg_port()
in os_dep/ioctl_linux.c
staging: rtl8723bs: remove unused cur_network variable in
rtw_dbg_port() in os_dep/ioctl_linux.c
staging: rtl8723bs: remove unused pmlmepriv variable in rtw_dbg_port()
in os_dep/ioctl_linux.c
staging: rtl8723bs: remove unused variable declaration in
include/rtw_security.h
staging: rtl8723bs: remove unused variable in os_dep/ioctl_linux.c
staging: rtl8723bs: remove decl of unused static const variable in
os_dep/ioctl_linux.c

 drivers/staging/rtl8723bs/core/rtw_cmd.c      |  3 --
 .../staging/rtl8723bs/include/rtw_security.h  | 18 --------
 .../staging/rtl8723bs/os_dep/ioctl_linux.c    | 46 -------------------
 3 files changed, 67 deletions(-)
Signature · 1 line
2.20.1