Skip to content

staging: rtl8723bs: remove DBG_8192C tracing macro

Fabio Aiuto linux-staging lkml oe-kbuild-all 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest25 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/25staging: rtl8723bs: remove all DBG_8192C logsdrivers/staging/rtl8723bs/core/rtw_mlme_ext.c drivers/staging/rtl8723bs/core/rtw_pwrctrl.c drivers/staging/rtl8723bs/core/rtw_xmit.c +10 more+9 -3250 replies
2/25staging: rtl8723bs: remove all commented out DBG_8192C logsdrivers/staging/rtl8723bs/core/rtw_ieee80211.c drivers/staging/rtl8723bs/core/rtw_wlan_util.c drivers/staging/rtl8723bs/hal/odm.c +6 more+0 -520 replies
3/25staging: rtl8723bs: remove DBG_8192C macro definitionsdrivers/staging/rtl8723bs/include/rtw_debug.h+0 -100 replies
4/25staging: rtl8723bs: remove all if-blocks left empty by DBG_8192C-remove coccinelle scriptdrivers/staging/rtl8723bs/hal/sdio_ops.c drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c+1 -310 replies
5/25staging: rtl8723bs: put spaces around operatorsdrivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c+1 -10 replies
6/25staging: rtl8723bs: remove unused code blocks guarded by DEBUG_RTL871Xdrivers/staging/rtl8723bs/core/rtw_debug.c drivers/staging/rtl8723bs/core/rtw_mlme_ext.c+0 -550 replies
7/25staging: rtl8723bs: remove commented out DEBUG_RTL871X definitiondrivers/staging/rtl8723bs/include/autoconf.h+0 -10 replies
8/25staging: rtl8723bs: remove code blocks guarded by DEBUG symboldrivers/staging/rtl8723bs/hal/rtl8723b_cmd.c drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c drivers/staging/rtl8723bs/include/autoconf.h+0 -350 replies
9/25staging: rtl8723bs: remove empty code block guarded by DBG_CCXdrivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c+0 -20 replies
10/25staging: rtl8723bs: remove code block guarded by undefined SDIO_DEBUG_IOdrivers/staging/rtl8723bs/hal/sdio_ops.c+1 -90 replies
11/25staging: rtl8723bs: remove commented out SDIO_DEBUG_IO symbol definitiondrivers/staging/rtl8723bs/hal/sdio_ops.c+0 -30 replies
12/25staging: rtl8723bs: remove empty ifdef blocks conditioned to DEBUG_CFG80211 definitiondrivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c+0 -150 replies
13/25staging: rtl8723bs: remove commented out DEBUG_CFG80211 symbol definitiondrivers/staging/rtl8723bs/include/autoconf.h+0 -10 replies
14/25staging: rtl8723bs: remove unnecessary bracksdrivers/staging/rtl8723bs/core/rtw_xmit.c drivers/staging/rtl8723bs/hal/hal_com.c drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c +5 more+52 -950 replies
15/25staging: rtl8723bs: fix comparison to nulldrivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c drivers/staging/rtl8723bs/os_dep/sdio_intf.c+5 -50 replies
16/25staging: rtl8723bs: put spaces around operatorsdrivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c+4 -40 replies
17/25staging: rtl8723bs: split long linedrivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c+2 -10 replies
18/25staging: rtl8723bs: put constant on the right side of the testdrivers/staging/rtl8723bs/hal/sdio_halinit.c+1 -10 replies
19/25staging: rtl8723bs: remove empty if and else blocksdrivers/staging/rtl8723bs/hal/rtl8723b_cmd.c drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c drivers/staging/rtl8723bs/hal/sdio_ops.c +1 more+3 -330 replies
20/25staging: rtl8723bs: put constant on the right side of a test in os_dep/ioctl_cfg80211.cdrivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c+1 -10 replies
21/25staging: rtl8723bs: remove unnecessary parentheses in os_dep/ioctl_cfg80211.cdrivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c+0 -20 replies
22/25staging: rtl8723bs: remove empty else block in os_dep/ioctl_cfg80211.cdrivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c+0 -10 replies
23/25staging: rtl8723bs: fix comparison to true issuedrivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c+1 -10 replies
24/25staging: rtl8723bs: remove more unnecessary parenthesesdrivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c+11 -140 replies
25/25staging: rtl8723bs: remove more empty if blocks after DBG_8192C deletiondrivers/staging/rtl8723bs/hal/sdio_halinit.c+0 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/25] staging: rtl8723bs: remove DBG_8192C tracing macro

This patchset remove from rtl8723bs driver the tracing macro DBG_8192C.

This macro belongs to a verbose private tracing family, which by default is set to _do nothing_. The only way to activate the tracing is to manually define a symbol in code.

First patch applies the following semantic patch:

@@
expression a, b, c, d, e, f, g, h, i, j, k;
constant B, C, D, E;
@@

(
- DBG_8192C(a);
|
- DBG_8192C(a, b);
|
- DBG_8192C(a, B);
|
- DBG_8192C(a, b, c);
|
- DBG_8192C(a, B, c);
|
- DBG_8192C(a, b, C);
|
- DBG_8192C(a, B, C);
|
- DBG_8192C(a, b, c, d);
|
- DBG_8192C(a, B, c, d);
|
- DBG_8192C(a, b, C, d);
|
- DBG_8192C(a, b, c, D);
|
- DBG_8192C(a, B, C, d);
|
- DBG_8192C(a, B, c, D);
|
- DBG_8192C(a, b, C, D);
|
- DBG_8192C(a, B, C, D);
|
- DBG_8192C(a, b, c, d, e);
|
- DBG_8192C(a, B, c, d, e);
|
- DBG_8192C(a, b, C, d, e);
|
- DBG_8192C(a, b, c, D, e);
|
- DBG_8192C(a, b, c, d, E);
|
- DBG_8192C(a, B, C, d, e);
|
- DBG_8192C(a, B, c, D, e);
|
- DBG_8192C(a, B, c, d, E);
|
- DBG_8192C(a, b, C, D, e);
|
- DBG_8192C(a, b, C, d, E);
|
- DBG_8192C(a, b, c, D, E);
|
- DBG_8192C(a, B, C, D, e);
|
- DBG_8192C(a, B, C, d, E);
|
- DBG_8192C(a, B, c, D, E);
|
- DBG_8192C(a, b, C, D, E);
|
- DBG_8192C(a, B, C, D, E);
|
- DBG_8192C(a, b, c, d, e, f);
|
- DBG_8192C(a, b, c, d, e, f, g);
|
- DBG_8192C(a, b, c, d, e, f, g, h);
|
- DBG_8192C(a, b, c, d, e, f, g, h, i);
|
- DBG_8192C(a, b, c, d, e, f, g, h, i, j);
|
- DBG_8192C(a, b, c, d, e, f, g, h, i, j, k);
)

Second patch removes all commented out call of macro.

Third patch removes macro definitions.

All subsequent patches do some code cleaning in all places left empty by deleted macro, such as empty #ifdef blocks, conditional code blocks guarded by never defined symbols if-else blocks, for cycles, commented debug symbol definitions, unnecessary parentheses and some other checkpatch issues.

Fabio Aiuto (25):
staging: rtl8723bs: remove all DBG_8192C logs
staging: rtl8723bs: remove all commented out DBG_8192C logs
staging: rtl8723bs: remove DBG_8192C macro definitions
staging: rtl8723bs: remove all if-blocks left empty by
DBG_8192C-remove coccinelle script
staging: rtl8723bs: put spaces around operators
staging: rtl8723bs: remove unused code blocks guarded by DEBUG_RTL871X
staging: rtl8723bs: remove commented out DEBUG_RTL871X definition
staging: rtl8723bs: remove code blocks guarded by DEBUG symbol
staging: rtl8723bs: remove empty code block guarded by DBG_CCX
staging: rtl8723bs: remove code block guarded by undefined
SDIO_DEBUG_IO
staging: rtl8723bs: remove commented out SDIO_DEBUG_IO symbol
definition
staging: rtl8723bs: remove empty ifdef blocks conditioned to
DEBUG_CFG80211 definition
staging: rtl8723bs: remove commented out DEBUG_CFG80211 symbol
definition
staging: rtl8723bs: remove unnecessary bracks
staging: rtl8723bs: fix comparison to null
staging: rtl8723bs: put spaces around operators
staging: rtl8723bs: split long line
staging: rtl8723bs: put constant on the right side of the test
staging: rtl8723bs: remove empty if and else blocks
staging: rtl8723bs: put constant on the right side of a test in

    os_dep/ioctl_cfg80211.c
  staging: rtl8723bs: remove unnecessary parentheses in
    os_dep/ioctl_cfg80211.c

staging: rtl8723bs: remove empty else block in os_dep/ioctl_cfg80211.c
staging: rtl8723bs: fix comparison to true issue
staging: rtl8723bs: remove more unnecessary parentheses
staging: rtl8723bs: remove more empty if blocks after DBG_8192C
deletion

 drivers/staging/rtl8723bs/core/rtw_debug.c    |  35 ---
 .../staging/rtl8723bs/core/rtw_ieee80211.c    |   1 -
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |  21 --
 drivers/staging/rtl8723bs/core/rtw_pwrctrl.c  |   7 -
 .../staging/rtl8723bs/core/rtw_wlan_util.c    |   3 -
 drivers/staging/rtl8723bs/core/rtw_xmit.c     |   7 +-
 drivers/staging/rtl8723bs/hal/hal_com.c       |  10 +-
 drivers/staging/rtl8723bs/hal/odm.c           |   1 -
 drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c  |  48 +---
 .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 263 +++---------------
 .../staging/rtl8723bs/hal/rtl8723b_phycfg.c   |   2 -
 .../staging/rtl8723bs/hal/rtl8723b_rxdesc.c   |   3 -
 .../staging/rtl8723bs/hal/rtl8723bs_recv.c    |  15 +-
 drivers/staging/rtl8723bs/hal/sdio_halinit.c  |  19 +-
 drivers/staging/rtl8723bs/hal/sdio_ops.c      |  39 +--
 drivers/staging/rtl8723bs/include/autoconf.h  |   7 -
 drivers/staging/rtl8723bs/include/rtw_debug.h |  10 -
 .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 216 +-------------
 .../staging/rtl8723bs/os_dep/ioctl_linux.c    |   6 -
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c  |  35 +--
 20 files changed, 69 insertions(+), 679 deletions(-)
Signature · 1 line
2.20.1