Skip to content

staging: rtl8723bs: replace DBG_871X_SEL_NL macro with netdev_dbg()

Fabio Aiuto linux-staging lkml 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 0 repliesNew
  2. v17 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- Excluded patches already accepted in v1
- Added by hand a newline after coccinelle script application
- Dropped the patch applying newline separately

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3staging: rtl8723bs: replace DBG_871X_SEL_NL with netdev_dbg()drivers/staging/rtl8723bs/core/rtw_debug.c drivers/staging/rtl8723bs/core/rtw_odm.c drivers/staging/rtl8723bs/hal/hal_com.c+47 -500 replies
2/3staging: rtl8723bs: remove DBG_871X_SEL_NL macro declarationdrivers/staging/rtl8723bs/include/rtw_debug.h+0 -90 replies
3/3staging: rtl8723bs: remove unused argument in functiondrivers/staging/rtl8723bs/core/rtw_odm.c drivers/staging/rtl8723bs/include/rtw_odm.h drivers/staging/rtl8723bs/os_dep/ioctl_linux.c+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] staging: rtl8723bs: replace DBG_871X_SEL_NL macro with netdev_dbg()

This patchset replaces DGB_871X_SEL_NL macro with the driver recommended log function netdev_dbg().

Here are contained the patches not accepted yet in v1.

Macro DBG_871X_SEL_NL indeed executes a raw printk call as default behaviour. The other behaviour is doing a seq_printf() call which never occurs.

First patch apply the following coccinelle script for macro bulk replacement:

@@
expression sel;
expression list args;
identifier padapter;
identifier func;
@@

func(..., struct adapter *padapter, ...) {
        <...
-       DBG_871X_SEL_NL(sel, args);
+       netdev_dbg(padapter->pnetdev, args);
        ...>
}

added by hand a newline in coccinelle output.

Second patch removes DBG_871X_SEL_NL macro declaration. Third patch removes an unused function argument after macro replacement.

-------------------------------------------------
Changes in v2:
- Excluded patches already accepted in v1
- Added by hand a newline after coccinelle script application
- Dropped the patch applying newline separately

Fabio Aiuto (3):
staging: rtl8723bs: replace DBG_871X_SEL_NL with netdev_dbg()
staging: rtl8723bs: remove DBG_871X_SEL_NL macro declaration
staging: rtl8723bs: remove unused argument in function

 drivers/staging/rtl8723bs/core/rtw_debug.c    | 16 +++---
 drivers/staging/rtl8723bs/core/rtw_odm.c      | 52 ++++++++++---------
 drivers/staging/rtl8723bs/hal/hal_com.c       | 31 +++++------
 drivers/staging/rtl8723bs/include/rtw_debug.h |  9 ----
 drivers/staging/rtl8723bs/include/rtw_odm.h   |  2 +-
 .../staging/rtl8723bs/os_dep/ioctl_linux.c    |  2 +-
 6 files changed, 50 insertions(+), 62 deletions(-)
Signature · 1 line
2.20.1