Skip to content

zfcp: cleanups and qdio code refactor for 5.13/5.14

Benjamin Block linux-s390 linux-scsi 1 version Applied

Status from this message: Applied to 5.13/scsi-staging, thanks! We'll see whether we get an -rc8

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/6zfcp: remove unneeded INIT_LIST_HEAD() for FSF requestsdrivers/s390/scsi/zfcp_fsf.c+0 -10 replies
2/6zfcp: fix indentation coding style issuedrivers/s390/scsi/zfcp_def.h+3 -30 replies
3/6zfcp: fix sysfs roll-back on error in zfcp_adapter_enqueue()drivers/s390/scsi/zfcp_aux.c+18 -20 replies
4/6zfcp: clean up sysfs code for SFP diagnosticsdrivers/s390/scsi/zfcp_aux.c drivers/s390/scsi/zfcp_diag.c drivers/s390/scsi/zfcp_diag.h +2 more+14 -630 replies
5/6scsi: zfcp: move the position of put_devicedrivers/s390/scsi/zfcp_sysfs.c drivers/s390/scsi/zfcp_unit.c+4 -40 replies
6/6scsi: zfcp: lift Request Queue tasklet & timer from qdiodrivers/s390/scsi/zfcp_qdio.c drivers/s390/scsi/zfcp_qdio.h+61 -120 replies

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by.

PatchBenjamin BlockSteffen Maier
1/6R-b R-b
2/6
3/6R-b R-b
4/6R-b R-b
5/6
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] zfcp: cleanups and qdio code refactor for 5.13/5.14

Hello James, Martin,

I know I am pretty late; we have some patches queued that I didn't come around posting yet; its nothing world-changing, so if you don't want to pull them for 5.13 anymore, no worries.

Most of these are cleanups, apart from the last patch from Julian. This lifts the handling of our outbound queue from the common QDIO layer (common for s390x, that is) to our driver. There is more details in the patch itself. We already did the same for the inbound queue handling some time ago.

All of these have run successfully in our internal CI for a bit already (most for quite some time actually), and so far nothing came up. I also retested them today with our regression suite on top of 5.12.0-rc7. So I'm pretty confident this should work without problems.

best regards,
- Benjamin

Julian Wiedmann (4):
zfcp: remove unneeded INIT_LIST_HEAD() for FSF requests
zfcp: fix sysfs roll-back on error in zfcp_adapter_enqueue()
zfcp: clean up sysfs code for SFP diagnostics
scsi: zfcp: lift Request Queue tasklet & timer from qdio

Qinglang Miao (1):
scsi: zfcp: move the position of put_device

Yevhen Viktorov (1):
zfcp: fix indentation coding style issue

 drivers/s390/scsi/zfcp_aux.c   | 28 +++++++++-----
 drivers/s390/scsi/zfcp_def.h   |  6 +--
 drivers/s390/scsi/zfcp_diag.c  | 42 ---------------------
 drivers/s390/scsi/zfcp_diag.h  |  7 ----
 drivers/s390/scsi/zfcp_ext.h   |  4 +-
 drivers/s390/scsi/zfcp_fsf.c   |  1 -
 drivers/s390/scsi/zfcp_qdio.c  | 68 ++++++++++++++++++++++++++++------
 drivers/s390/scsi/zfcp_qdio.h  |  5 +++
 drivers/s390/scsi/zfcp_sysfs.c | 14 +++++--
 drivers/s390/scsi/zfcp_unit.c  |  4 +-
 10 files changed, 97 insertions(+), 82 deletions(-)
Signature · 1 line
2.30.2