Skip to content

git: support separate arg for `--config-env`'s value

Patrick Steinhardt git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v12 patches 3 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2git.txt: fix synopsis of `--config-env` missing the equals signDocumentation/git.txt+1 -10 replies
2/2git: support separate arg for `--config-env`'s valuegit.c t/t1300-config.sh+22 -10 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchPatrick Steinhardt
1/2Signed-of-by
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] git: support separate arg for `--config-env`'s value

Hi,

this is the second version of this series fixing inconsistencies with the --config-env parameter. It's only got a single change compared to v1, which is to replace test_i18ngrep with grep as pointed out by Ævar.

Patrick

Patrick Steinhardt (2):
git.txt: fix synopsis of --config-env missing the equals sign
git: support separate arg for --config-env's value

 Documentation/git.txt |  2 +-
 git.c                 |  8 ++++++++
 t/t1300-config.sh     | 15 ++++++++++++++-
 3 files changed, 23 insertions(+), 2 deletions(-)

Range-diff against v1:

1:  08049f3b10 = 1:  08049f3b10 git.txt: fix synopsis of `--config-env` missing the equals sign
2:  d52db89bc2 ! 2:  5264fb6fa7 git: support separate arg for `--config-env`'s value
    @@ t/t1300-config.sh: test_expect_success 'git --config-env=key=envvar support' '
      
     +test_expect_success 'git --config-env with missing value' '
     +	test_must_fail env ENVVAR=value git --config-env 2>error &&
    -+	test_i18ngrep "no config key given for --config-env" error &&
    ++	grep "no config key given for --config-env" error &&
     +	test_must_fail env ENVVAR=value git --config-env config core.name 2>error &&
    -+	test_i18ngrep "invalid config format: config" error
    ++	grep "invalid config format: config" error
     +'
     +
      test_expect_success 'git --config-env fails with invalid parameters' '
Signature · 1 line
2.31.1

Read the cover letter in its thread