Skip to content

clk: mvebu: Fix some error handling paths + do some clean-up

Christophe JAILLET kernel-janitors linux-clk lkml 1 version NAK

Status from this message: NAK, wrong cover letter sent

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 6 repliesNAK

Patches in v1

#Subject and filesSizeRepliesApplied
1/4clk: mvebu: Fix a memory leak in an error handling pathdrivers/clk/mvebu/clk-cpu.c+5 -53 replies
2/4clk: mvebu: Fix a another memory leak in an error handling pathdrivers/clk/mvebu/clk-cpu.c+7 -20 replies
3/4clk: mvebu: Add a missing spacedrivers/clk/mvebu/clk-cpu.c+1 -10 replies
4/4clk: mvebu: Remove an unneeded includedrivers/clk/mvebu/clk-cpu.c+0 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] clk: mvebu: Fix some error handling paths + do some clean-up

This serie fixes some (unlikely) error handlings paths.

The 4th patch is completely speculative. When I compile-tested the changes, I had to remove this line in order for it to compile.
As it works fine (at least for me) without it, I wonder if it is needed at all.

Also, I wonder if the drivers in drivers/clk/mvebu are used by anyone. In order to compile-test the changes, I also had to change the 'bool' in Kconfig by 'bool "blah"'. Without this change, it was not possible to set CONFIG_MVEBU_CLK_CPU required by Makefile.

I don't know if I did something wrong, if it is an issue only on my environment or if something got broken at some time in the build chain but it looks spurious.

If I'm right and that these drivers never compile and no-one noticed it, maybe removing them is better than fixing some unlikely issues and style. If these drivers should stay, Kconfig may need some love from someone.

Christophe JAILLET (4):
clk: mvebu: Fix a memory leak in an error handling path
clk: mvebu: Fix a another memory leak in an error handling path
clk: mvebu: Fix a checkpatch warning
clk: mvebu: Remove an unneeded include

 drivers/clk/mvebu/clk-cpu.c | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)
Signature · 1 line
2.27.0