staging: rtl8723bs: remove all remaining debug macros in rtw_debug.h
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest50 patches 5 repliesIn review
- v149 patches 4 repliesSuperseded
Changes in v2 from the cover letter
- Added a patch to improve register dump
- Fix commit message and changelog in patch removing an unneeded include directive
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/50 | staging: rtl8723bs: remove unused log functiondrivers/ drivers/ | +0 | 0 replies | |
| 2/50 | staging: rtl8723bs: replace DBG_871X_SEL log macro with netdev_dbg()drivers/ | +8 | 0 replies | |
| 3/50 | staging: rtl8723bs: add two functions to improve register dump in core/rtw_debug.cdrivers/ | +35 | 0 replies | |
| 4/50 | staging: rtl8723bs: remove DBG_871X_SEL macro declarationdrivers/ | +0 | 0 replies | |
| 5/50 | staging: rtl8723bs: remove unused _DBG_871X_LEVEL macrodrivers/ | +0 | 0 replies | |
| 6/50 | staging: rtl8723bs: remove unused mac_reg_dump() function argumentdrivers/ drivers/ drivers/ | +3 | 0 replies | |
| 7/50 | staging: rtl8723bs: remove unused bb_reg_dump() function argumentdrivers/ drivers/ drivers/ | +3 | 0 replies | |
| 8/50 | staging: rtl8723bs: remove unused rf_reg_dump() function argumentdrivers/ drivers/ drivers/ | +3 | 0 replies | |
| 9/50 | staging: rtl8723bs: remove unused RTW_DBGDUMP macro definitiondrivers/ | +0 | 0 replies | |
| 10/50 | staging: rtl8723bs: remove all defs related to _dbgdump macrodrivers/ | +0 | 0 replies | |
| 11/50 | staging: rtl8723bs: remove unused debug variables declarations and initializationdrivers/ drivers/ | +0 | 0 replies | |
| 12/50 | staging: rtl8723bs: remove unneeded header file includedrivers/ | +0 | 0 replies | |
| 13/50 | staging: rtl8723bs: remove unused debug macro definitionsdrivers/ | +0 | 0 replies | |
| 14/50 | staging: rtl8723bs: remove debug macros related to core/rtw_xmit.c tracingdrivers/ drivers/ | +1 | 0 replies | |
| 15/50 | staging: rtl8723bs: remove debug macros related to os_dep/xmit_linux.c tracingdrivers/ drivers/ | +1 | 0 replies | |
| 16/50 | staging: rtl8723bs: remove debug macros related to core/rtw_recv.c tracingdrivers/ drivers/ | +1 | 0 replies | |
| 17/50 | staging: rtl8723bs: remove debug macros related to os_dep/recv_linux.c tracingdrivers/ drivers/ | +1 | 0 replies | |
| 18/50 | staging: rtl8723bs: remove debug macros related to core/rtw_mlme.c tracingdrivers/ drivers/ | +1 | 0 replies | |
| 19/50 | staging: rtl8723bs: remove debug macros related to os_dep/mlme_linux.c tracingdrivers/ drivers/ | +1 | 0 replies | |
| 20/50 | staging: rtl8723bs: move static array definition from header to .c filedrivers/ drivers/ | +30 | 0 replies | |
| 21/50 | staging: rtl8723bs: remove debug macros related to core/rtw_mlme_ext.c tracingdrivers/ drivers/ | +1 | 0 replies | |
| 22/50 | staging: rtl8723bs: remove debug macros related to core/rtw_sta_mgt.c tracingdrivers/ drivers/ | +1 | 0 replies | |
| 23/50 | staging: rtl8723bs: remove debug macros related to core/rtw_cmd.c tracingdrivers/ drivers/ | +1 | 0 replies | |
| 24/50 | staging: rtl8723bs: remove obsolete debug macro definitionsdrivers/ | +1 | 0 replies | |
| 25/50 | staging: rtl8723bs: remove debug macros related to core/rtw_io.c tracingdrivers/ drivers/ | +1 | 0 replies | |
| 26/50 | staging: rtl8723bs: remove obsolete _IO_OSDEP_C_ debug macro definitiondrivers/ | +1 | 0 replies | |
| 27/50 | staging: rtl8723bs: remove debug macros related to os_dep/os_intfs.c tracingdrivers/ drivers/ | +1 | 0 replies | |
| 28/50 | staging: rtl8723bs: remove debug macros related to core/rtw_security.c tracingdrivers/ drivers/ | +1 | 0 replies | |
| 29/50 | staging: rtl8723bs: remove debug macros related to core/rtw_eeprom.c tracingdrivers/ drivers/ | +1 | 0 replies | |
| 30/50 | staging: rtl8723bs: remove debug macros related to hal/hal_intf.c tracingdrivers/ drivers/ | +1 | 0 replies | |
| 31/50 | staging: rtl8723bs: remove debug macros related to hal/sdio_halinit.c tracingdrivers/ drivers/ | +1 | 0 replies | |
| 32/50 | staging: rtl8723bs: remove unused debug macros tied to _RTL871X_IOCTL_C_ definitiondrivers/ | +1 | 0 replies | |
| 33/50 | staging: rtl8723bs: remove unused debug macros tied to _RTL871X_IOCTL_SET_C_ definitiondrivers/ | +1 | 0 replies | |
| 34/50 | staging: rtl8723bs: remove unused debug macros tied to _RTL871X_IOCTL_QUERY_C_ definitiondrivers/ | +1 | 0 replies | |
| 35/50 | staging: rtl8723bs: remove unused debug macros tied to _RTL871X_PWRCTRL_C_ definitiondrivers/ | +1 | 0 replies | |
| 36/50 | staging: rtl8723bs: remove unused macros tied to core/rtw_pwrctrl.c debugdrivers/ drivers/ | +1 | 0 replies | |
| 37/50 | staging: rtl8723bs: remove unused macros tied to os_dep/sdio_intf.c debugdrivers/ drivers/ | +1 | 0 replies | |
| 38/50 | staging: rtl8723bs: remove unused debug macros tied to _HCI_OPS_C_ definitiondrivers/ | +1 | 0 replies | |
| 39/50 | staging: rtl8723bs: remove unused debug macros tied to hal/sdio_ops.c debugdrivers/ drivers/ | +1 | 0 replies | |
| 40/50 | staging: rtl8723bs: remove unused debug macros tied to os_dep/osdep_service.c debugdrivers/ drivers/ | +1 | 0 replies | |
| 41/50 | staging: rtl8723bs: remove unused _module_mp_ defdrivers/ | +0 | 0 replies | |
| 42/50 | staging: rtl8723bs: remove unused macros tied to _HCI_OPS_OS_C_ definitiondrivers/ | +1 | 0 replies | |
| 43/50 | staging: rtl8723bs: remove unused macros tied to _RTL871X_IOCTL_LINUX_C definitiondrivers/ | +1 | 0 replies | |
| 44/50 | staging: rtl8723bs: remove unused macros tied to _RTL8712_CMD_C_ definitiondrivers/ | +1 | 0 replies | |
| 45/50 | staging: rtl8723bs: remove commented out macro definitiondrivers/ | +0 | 0 replies | |
| 46/50 | staging: rtl8723bs: remove unused debug macro definitionsdrivers/ | +0 | 0 replies | |
| 47/50 | staging: rtl8723bs: remove unused macros tied to core/rtw_efuse.c debugdrivers/ drivers/ | +0 | 0 replies | |
| 48/50 | staging: rtl8723bs: remove unsed debug macros tied to no particular code debugdrivers/ | +1 | 0 replies | |
| 49/50 | staging: rtl8723bs: remove last unused debug macrosdrivers/ | +0 | 0 replies | |
| 50/50 | staging: rtl8723bs: macro DRIVER_PREFIX expands to lowercase driver namedrivers/ | +1 | 3 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 00/50] staging: rtl8723bs: remove all remaining debug macros in rtw_debug.h
This patchset removes all remaining debug macros in rtw_debug.h
DBG_871X_SEL macro is replaced with netdev_dbg() for it does a raw printk call which is not best recommended for a driver.
@@
expression sel;
expression list args;
identifier padapter;
identifier func;
@@
func(..., struct adapter *padapter, ...) {
<...
- DBG_871X_SEL(sel, args);
+ netdev_dbg(padapter->pnetdev, args);
...>unused _DBG_871X_LEVEL macro declaration is removed.
Beautified register dump in core/rtw_debug.c
Some code cleaning is done and all other private component tracing macros are removed.
----------------------------------------------
Changes in v2:
- Added a patch to improve register dump
- Fix commit message and changelog in patch removing an unneeded include directive
Fabio Aiuto (50):
staging: rtl8723bs: remove unused log function
staging: rtl8723bs: replace DBG_871X_SEL log macro with netdev_dbg()
staging: rtl8723bs: add two functions to improve register dump in
core/rtw_debug.c
staging: rtl8723bs: remove DBG_871X_SEL macro declaration
staging: rtl8723bs: remove unused _DBG_871X_LEVEL macro
staging: rtl8723bs: remove unused mac_reg_dump() function argument
staging: rtl8723bs: remove unused bb_reg_dump() function argument
staging: rtl8723bs: remove unused rf_reg_dump() function argument
staging: rtl8723bs: remove unused RTW_DBGDUMP macro definition
staging: rtl8723bs: remove all defs related to _dbgdump macro
staging: rtl8723bs: remove unused debug variables declarations and
initialization
staging: rtl8723bs: remove unneeded header file include
staging: rtl8723bs: remove unused debug macro definitions
staging: rtl8723bs: remove debug macros related to core/rtw_xmit.c
tracing
staging: rtl8723bs: remove debug macros related to os_dep/xmit_linux.c
tracing
staging: rtl8723bs: remove debug macros related to core/rtw_recv.c
tracing
staging: rtl8723bs: remove debug macros related to os_dep/recv_linux.c
tracing
staging: rtl8723bs: remove debug macros related to core/rtw_mlme.c
tracing
staging: rtl8723bs: remove debug macros related to os_dep/mlme_linux.c
tracing
staging: rtl8723bs: move static array definition from header to .c
file
staging: rtl8723bs: remove debug macros related to core/rtw_mlme_ext.c
tracing
staging: rtl8723bs: remove debug macros related to core/rtw_sta_mgt.c
tracing
staging: rtl8723bs: remove debug macros related to core/rtw_cmd.c
tracing
staging: rtl8723bs: remove obsolete debug macro definitions
staging: rtl8723bs: remove debug macros related to core/rtw_io.c
tracing
staging: rtl8723bs: remove obsolete _IO_OSDEP_C_ debug macro
definition
staging: rtl8723bs: remove debug macros related to os_dep/os_intfs.c
tracing
staging: rtl8723bs: remove debug macros related to core/rtw_security.c
tracing
staging: rtl8723bs: remove debug macros related to core/rtw_eeprom.c
tracing
staging: rtl8723bs: remove debug macros related to hal/hal_intf.c
tracing
staging: rtl8723bs: remove debug macros related to hal/sdio_halinit.c
tracing
staging: rtl8723bs: remove unused debug macros tied to
_RTL871X_IOCTL_C_ definition
staging: rtl8723bs: remove unused debug macros tied to
_RTL871X_IOCTL_SET_C_ definition
staging: rtl8723bs: remove unused debug macros tied to
_RTL871X_IOCTL_QUERY_C_ definition
staging: rtl8723bs: remove unused debug macros tied to
_RTL871X_PWRCTRL_C_ definition
staging: rtl8723bs: remove unused macros tied to core/rtw_pwrctrl.c
debug
staging: rtl8723bs: remove unused macros tied to os_dep/sdio_intf.c
debug
staging: rtl8723bs: remove unused debug macros tied to _HCI_OPS_C_
definition
staging: rtl8723bs: remove unused debug macros tied to hal/sdio_ops.c
debug
staging: rtl8723bs: remove unused debug macros tied to
os_dep/osdep_service.c debug
staging: rtl8723bs: remove unused _module_mp_ def
staging: rtl8723bs: remove unused macros tied to _HCI_OPS_OS_C_
definition
staging: rtl8723bs: remove unused macros tied to
_RTL871X_IOCTL_LINUX_C definition
staging: rtl8723bs: remove unused macros tied to _RTL8712_CMD_C_
definition
staging: rtl8723bs: remove commented out macro definition
staging: rtl8723bs: remove unused debug macro definitions
staging: rtl8723bs: remove unused macros tied to core/rtw_efuse.c
debug
staging: rtl8723bs: remove unsed debug macros tied to no particular
code debug
staging: rtl8723bs: remove last unused debug macros
staging: rtl8723bs: macro DRIVER_PREFIX expands to lowercase driver
name
drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 - drivers/staging/rtl8723bs/core/rtw_debug.c | 74 ++++---- drivers/staging/rtl8723bs/core/rtw_eeprom.c | 2 - drivers/staging/rtl8723bs/core/rtw_efuse.c | 2 - drivers/staging/rtl8723bs/core/rtw_io.c | 2 - drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 - drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 32 +++- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 2 - drivers/staging/rtl8723bs/core/rtw_recv.c | 2 - drivers/staging/rtl8723bs/core/rtw_security.c | 2 - drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 - drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 - drivers/staging/rtl8723bs/hal/hal_intf.c | 3 - drivers/staging/rtl8723bs/hal/sdio_halinit.c | 2 - drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 - drivers/staging/rtl8723bs/include/rtw_debug.h | 170 +----------------- .../staging/rtl8723bs/include/rtw_mlme_ext.h | 32 ---- .../staging/rtl8723bs/os_dep/ioctl_linux.c | 6 +- drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 4 - drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 - .../staging/rtl8723bs/os_dep/osdep_service.c | 4 - drivers/staging/rtl8723bs/os_dep/recv_linux.c | 2 - drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 2 - drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 2 - 24 files changed, 69 insertions(+), 288 deletions(-)
Signature · 1 line
2.20.1