Skip to content

cec-follower: increase accuracy Audio Rate Control

Deborah Brouwer linux-media 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 0 repliesNew
  2. v22 patches 2 repliesSuperseded

Changes in v3 from the cover letter

* Patch 1:
cec-follower: increase precision of Audio Rate Control active sensing
* Add the unit (nanoseconds) as a suffix to the define name.
* Write the defined value as a multiplication of seconds times nsecs_per_sec.
* Add ULL to help cast the expression to an unsigned long long.
* Note: for the sake of clarity in the diff, a blank line before the if statement is missing but it is subsequently added by Patch 2.

* Patch 2:
cec-follower: detect the cessation of Audio Rate Control messages
* Remove double negative in comment.
* Extend comment to specify (i.e. state.last_aud_rate_rx_ts != 0).
* Make warning message more succinct.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2cec-follower: increase precision of Audio Rate Control active sensingutils/cec-follower/cec-processing.cpp+4 -40 replies
2/2cec-follower: detect the cessation of Audio Rate Control messagesutils/cec-follower/cec-processing.cpp+14 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/2] cec-follower: increase accuracy Audio Rate Control

Changes since v2:
* Patch 1:
cec-follower: increase precision of Audio Rate Control active sensing
* Add the unit (nanoseconds) as a suffix to the define name.
* Write the defined value as a multiplication of seconds times nsecs_per_sec.
* Add ULL to help cast the expression to an unsigned long long.
* Note: for the sake of clarity in the diff, a blank line before the if statement is missing but it is subsequently added by Patch 2.

* Patch 2:
cec-follower: detect the cessation of Audio Rate Control messages
* Remove double negative in comment.
* Extend comment to specify (i.e. state.last_aud_rate_rx_ts != 0).
* Make warning message more succinct.

Changes since v1:
* Patch 1: cec-follower: increase precision of Audio Rate Control active sensing
* new patch

*Patch 2:
* Keep the aud_rate_msg_interval_check in processMsg to avoid missing late messages that arrive between periodic interval checks.
* Swap arguments so that struct node appears first.
* Add blank line for readability.

Deborah Brouwer (2):
cec-follower: increase precision of Audio Rate Control active sensing
cec-follower: detect the cessation of Audio Rate Control messages

 utils/cec-follower/cec-processing.cpp | 30 ++++++++++++++++-----------
 1 file changed, 18 insertions(+), 12 deletions(-)

--
2.17.1