Fix redefinition errors for toolstack libs
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest5 patches 9 repliesIn review
- v35 patches 7 repliesSuperseded
- v25 patches 1 replySuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 5 patches | 12 replies | Superseded |
Changes in v4 from the cover letter
- Use sysconf(_SC_PAGESIZE) instead of getpagesize()
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | tools/debugger: Fix PAGE_SIZE redefinition errortools/ tools/ tools/ | +21 | 0 replies | |
| 2/5 | tools/libfsimage: Fix PATH_MAX redefinition errortools/ tools/ | +4 | 0 replies | |
| 3/5 | tools/libs/foreignmemory: Fix PAGE_SIZE redefinition errortools/ tools/ tools/ +3 more | +25 | 3 replies | |
| 4/5 | tools/libs/gnttab: Fix PAGE_SIZE redefinition errortools/ tools/ tools/ | +36 | 3 replies | |
| 5/5 | tools/ocaml: Fix redefinition errorstools/ tools/ tools/ | +12 | 0 replies |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Tim Deegan | Julien Grall | Dario Faggioli | Christian Lindig |
|---|---|---|---|---|
| Series | A-b | |||
| 1/5 | R-b | |||
| 2/5 | R-b | |||
| 3/5 | R-b | |||
| 4/5 | R-b | |||
| 5/5 | R-b | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v4 0/5] Fix redefinition errors for toolstack libs
For replication I used gcc 10.3 on an Alpine system. In order to replicate the redefinition error for PAGE_SIZE one should install the 'fortify-headers' package which will change the chain of included headers by indirectly including /usr/include/limits.h where PAGE_SIZE and PATH_MAX are defined.
Changes since v1:
- Use XC_PAGE_* macros instead of PAGE_* macros
Changes since v2:
- Define KDD_PAGE_* macros for changes in debugger/kdd/
Changes since v3:
- Use sysconf(_SC_PAGESIZE) instead of getpagesize()
Costin Lupu (5):
tools/debugger: Fix PAGE_SIZE redefinition error tools/libfsimage: Fix PATH_MAX redefinition error tools/libs/foreignmemory: Fix PAGE_SIZE redefinition error tools/libs/gnttab: Fix PAGE_SIZE redefinition error tools/ocaml: Fix redefinition errors
tools/debugger/kdd/kdd-xen.c | 15 ++++------ tools/debugger/kdd/kdd.c | 19 ++++++------- tools/debugger/kdd/kdd.h | 7 +++++ tools/libfsimage/ext2fs/fsys_ext2fs.c | 2 ++ tools/libfsimage/reiserfs/fsys_reiserfs.c | 2 ++ tools/libs/foreignmemory/core.c | 2 +- tools/libs/foreignmemory/freebsd.c | 10 +++---- tools/libs/foreignmemory/linux.c | 23 +++++++-------- tools/libs/foreignmemory/minios.c | 2 +- tools/libs/foreignmemory/netbsd.c | 10 +++---- tools/libs/foreignmemory/private.h | 9 +----- tools/libs/gnttab/freebsd.c | 28 +++++++++---------- tools/libs/gnttab/linux.c | 28 +++++++++---------- tools/libs/gnttab/netbsd.c | 23 +++++++-------- tools/ocaml/libs/xc/xenctrl_stubs.c | 10 +++---- .../ocaml/libs/xentoollog/xentoollog_stubs.c | 4 +++ tools/ocaml/libs/xl/xenlight_stubs.c | 4 +++ 17 files changed, 98 insertions(+), 100 deletions(-)
Signature · 1 line
2.20.1