Skip to content

Fix redefinition errors for toolstack libs

Costin Lupu xen-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 9 repliesIn review
  2. v35 patches 7 repliesSuperseded
  3. v25 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches12 repliesSuperseded

Changes in v4 from the cover letter

- Use sysconf(_SC_PAGESIZE) instead of getpagesize()

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5tools/debugger: Fix PAGE_SIZE redefinition errortools/debugger/kdd/kdd-xen.c tools/debugger/kdd/kdd.c tools/debugger/kdd/kdd.h+21 -200 replies
2/5tools/libfsimage: Fix PATH_MAX redefinition errortools/libfsimage/ext2fs/fsys_ext2fs.c tools/libfsimage/reiserfs/fsys_reiserfs.c+4 -00 replies
3/5tools/libs/foreignmemory: Fix PAGE_SIZE redefinition errortools/libs/foreignmemory/core.c tools/libs/foreignmemory/freebsd.c tools/libs/foreignmemory/linux.c +3 more+25 -313 replies
4/5tools/libs/gnttab: Fix PAGE_SIZE redefinition errortools/libs/gnttab/freebsd.c tools/libs/gnttab/linux.c tools/libs/gnttab/netbsd.c+36 -433 replies
5/5tools/ocaml: Fix redefinition errorstools/ocaml/libs/xc/xenctrl_stubs.c tools/ocaml/libs/xentoollog/xentoollog_stubs.c tools/ocaml/libs/xl/xenlight_stubs.c+12 -60 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchTim DeeganJulien GrallDario FaggioliChristian Lindig
SeriesA-b
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/5] Fix redefinition errors for toolstack libs

For replication I used gcc 10.3 on an Alpine system. In order to replicate the redefinition error for PAGE_SIZE one should install the 'fortify-headers' package which will change the chain of included headers by indirectly including /usr/include/limits.h where PAGE_SIZE and PATH_MAX are defined.

Changes since v1:
- Use XC_PAGE_* macros instead of PAGE_* macros

Changes since v2:
- Define KDD_PAGE_* macros for changes in debugger/kdd/

Changes since v3:
- Use sysconf(_SC_PAGESIZE) instead of getpagesize()

Costin Lupu (5):
tools/debugger: Fix PAGE_SIZE redefinition error tools/libfsimage: Fix PATH_MAX redefinition error tools/libs/foreignmemory: Fix PAGE_SIZE redefinition error tools/libs/gnttab: Fix PAGE_SIZE redefinition error tools/ocaml: Fix redefinition errors

 tools/debugger/kdd/kdd-xen.c                  | 15 ++++------
 tools/debugger/kdd/kdd.c                      | 19 ++++++-------
 tools/debugger/kdd/kdd.h                      |  7 +++++
 tools/libfsimage/ext2fs/fsys_ext2fs.c         |  2 ++
 tools/libfsimage/reiserfs/fsys_reiserfs.c     |  2 ++
 tools/libs/foreignmemory/core.c               |  2 +-
 tools/libs/foreignmemory/freebsd.c            | 10 +++----
 tools/libs/foreignmemory/linux.c              | 23 +++++++--------
 tools/libs/foreignmemory/minios.c             |  2 +-
 tools/libs/foreignmemory/netbsd.c             | 10 +++----
 tools/libs/foreignmemory/private.h            |  9 +-----
 tools/libs/gnttab/freebsd.c                   | 28 +++++++++----------
 tools/libs/gnttab/linux.c                     | 28 +++++++++----------
 tools/libs/gnttab/netbsd.c                    | 23 +++++++--------
 tools/ocaml/libs/xc/xenctrl_stubs.c           | 10 +++----
 .../ocaml/libs/xentoollog/xentoollog_stubs.c  |  4 +++
 tools/ocaml/libs/xl/xenlight_stubs.c          |  4 +++
 17 files changed, 98 insertions(+), 100 deletions(-)
Signature · 1 line
2.20.1