Skip to content

staging: rtl8723bs: clean up driver from private debug facilities

Fabio Aiuto linux-staging lkml 3 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest43 patches 9 repliesIn review
  2. v243 patches 0 repliesSuperseded
  3. v143 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- fix spelling error in subject of patch 2 as reported by Bryan Brattlof.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/43staging: rtl8723bs: remove ODM_RT_TRACE logsdrivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c drivers/staging/rtl8723bs/hal/HalHWImg8723B_MAC.c drivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.c +10 more+7 -12350 replies
2/43staging: rtl8723bs: remove if-else blocks left empty by ODM_RT_TRACE deletiondrivers/staging/rtl8723bs/hal/HalPhyRf.c drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c drivers/staging/rtl8723bs/hal/odm_PathDiv.c+1 -292 replies
3/43staging: rtl8723bs: remove empty functionsdrivers/staging/rtl8723bs/hal/odm.c drivers/staging/rtl8723bs/hal/odm_PathDiv.c+0 -110 replies
4/43staging: rtl8723bs: remove empty hal/odm_PathDiv.c source filedrivers/staging/rtl8723bs/Makefile drivers/staging/rtl8723bs/hal/odm_PathDiv.c+0 -100 replies
5/43staging: rtl8723bs: remove undefined function prototypesdrivers/staging/rtl8723bs/hal/odm_PathDiv.h+0 -100 replies
6/43staging: rtl8723bs: remove empty header filedrivers/staging/rtl8723bs/hal/odm.h drivers/staging/rtl8723bs/hal/odm_PathDiv.h drivers/staging/rtl8723bs/hal/odm_precomp.h+0 -130 replies
7/43staging: rtl8723bs: remove ODM_RT_TRACE* unused macro defsdrivers/staging/rtl8723bs/hal/odm_debug.h+0 -230 replies
8/43staging: rtl8723bs: remove all commented out ODM_RT_TRACE logsdrivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c drivers/staging/rtl8723bs/hal/odm.c drivers/staging/rtl8723bs/hal/odm_HWConfig.c+0 -360 replies
9/43staging: rtl8723bs: replace ODM_RT_ASSERT with netdev_dbg()drivers/staging/rtl8723bs/hal/odm.c+2 -10 replies
10/43staging: rtl8723bs: remove unused ODM_RT_ASSERT macrodrivers/staging/rtl8723bs/hal/odm_debug.h+0 -150 replies
11/43staging: rtl8723bs: remove unused ODM_PRINT_ADDR macrodrivers/staging/rtl8723bs/hal/odm_debug.h+0 -190 replies
12/43staging: rtl8723bs: remove unused ODM_dbg_trace macrodrivers/staging/rtl8723bs/hal/odm_debug.h+0 -20 replies
13/43staging: rtl8723bs: remove unused ODM_dbg_enterdrivers/staging/rtl8723bs/hal/odm_debug.h+0 -10 replies
14/43staging: rtl8723bs: remove unused ODM_dbg_exit macrodrivers/staging/rtl8723bs/hal/odm_debug.h+0 -10 replies
15/43staging: rtl8723bs: remove empty ifdef blockdrivers/staging/rtl8723bs/hal/odm_debug.h+0 -40 replies
16/43staging: rtl8723bs: remove unused ASSERT macrodrivers/staging/rtl8723bs/hal/odm_debug.h+0 -12 replies
17/43staging: rtl8723bs: remove empty #ifndef blockdrivers/staging/rtl8723bs/hal/odm_debug.h+0 -30 replies
18/43staging: rtl8723bs: remove commented out RT_ASSERT occurrencesdrivers/staging/rtl8723bs/core/rtw_recv.c drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c drivers/staging/rtl8723bs/hal/sdio_halinit.c+0 -80 replies
19/43staging: rtl8723bs: remove unused RT_PRINTK macrodrivers/staging/rtl8723bs/hal/odm_debug.h+0 -20 replies
20/43staging: rtl8723bs: remove BTC_PRINT logsdrivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c drivers/staging/rtl8723bs/hal/hal_btcoex.c+2 -10740 replies
21/43staging: rtl8723bs: remove empty if-else blocks after BTC_PRINT removaldrivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c+2 -260 replies
22/43staging: rtl8723bs: remove braces around single statement in if blockdrivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c+2 -20 replies
23/43staging: rtl8723bs: remove commented out BTC_PRINT logsdrivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c+0 -100 replies
24/43staging: rtl8723bs: remove BTC_PRINT macro definitionsdrivers/staging/rtl8723bs/hal/HalBtcOutSrc.h+0 -70 replies
25/43staging: rtl8723bs: remove BTC_PRINT_ADDR macro definitionsdrivers/staging/rtl8723bs/hal/HalBtcOutSrc.h+0 -140 replies
26/43staging: rtl8723bs: remove BTC_PRINT_DATA definitionsdrivers/staging/rtl8723bs/hal/HalBtcOutSrc.h+0 -170 replies
27/43staging: rtl8723bs: remove BTC_PRINT_F macro definitiondrivers/staging/rtl8723bs/hal/HalBtcOutSrc.h+0 -10 replies
28/43staging: rtl8723bs: remove empty #ifdef blockdrivers/staging/rtl8723bs/hal/HalBtcOutSrc.h+0 -50 replies
29/43staging: rtl8723bs: remove unsed hal_btcoex_SetDBG() functiondrivers/staging/rtl8723bs/hal/hal_btcoex.c drivers/staging/rtl8723bs/include/hal_btcoex.h+0 -130 replies
30/43staging: rtl8723bs: remove hal_btcoex_GetDBG() functiondrivers/staging/rtl8723bs/hal/hal_btcoex.c drivers/staging/rtl8723bs/include/hal_btcoex.h+0 -1240 replies
31/43staging: rtl8723bs: remove unnecessary halbtcoutsrc_DbgInit() functiondrivers/staging/rtl8723bs/hal/hal_btcoex.c+0 -280 replies
32/43staging: rtl8723bs: remove obsolete GLBtcDbgType array declarationsdrivers/staging/rtl8723bs/hal/HalBtcOutSrc.h drivers/staging/rtl8723bs/hal/hal_btcoex.c+0 -20 replies
33/43staging: rtl8723bs: remove unused enumdrivers/staging/rtl8723bs/hal/HalBtcOutSrc.h+0 -60 replies
34/43staging: rtl8723bs: remove obsolete debug macrosdrivers/staging/rtl8723bs/hal/HalBtcOutSrc.h+0 -160 replies
35/43staging: rtl8723bs: remove commented out DbgPrint logsdrivers/staging/rtl8723bs/core/rtw_efuse.c drivers/staging/rtl8723bs/core/rtw_recv.c drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c +4 more+0 -380 replies
36/43staging: rtl8723bs: remove unused DbgPrint macrodrivers/staging/rtl8723bs/hal/odm_debug.h+0 -10 replies
37/43staging: rtl8723bs: remove commented out *RT_DISP logsdrivers/staging/rtl8723bs/hal/odm_HWConfig.c drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c+0 -90 replies
38/43staging: rtl8723bs: remove RT_DISP macro definitiondrivers/staging/rtl8723bs/hal/odm_debug.h+0 -30 replies
39/43staging: rtl8723bs: remove ODM_InitDebugSetting() functiondrivers/staging/rtl8723bs/hal/odm.c drivers/staging/rtl8723bs/hal/odm_debug.c drivers/staging/rtl8723bs/hal/odm_debug.h+0 -390 replies
40/43staging: rtl8723bs: remove empty hal/odm_debug.c filedrivers/staging/rtl8723bs/Makefile drivers/staging/rtl8723bs/hal/odm_debug.c+0 -100 replies
41/43staging: rtl8723bs: remove member in dm_odm_t structdrivers/staging/rtl8723bs/hal/hal_com.c drivers/staging/rtl8723bs/hal/odm.c drivers/staging/rtl8723bs/hal/odm.h+0 -150 replies
42/43staging: rtl8723bs: remove DebugLevel member in dm_odm_t structdrivers/staging/rtl8723bs/hal/hal_com.c drivers/staging/rtl8723bs/hal/odm.c drivers/staging/rtl8723bs/hal/odm.h+0 -90 replies
43/43staging: rtl8723bs: remove odm_debug.h header filedrivers/staging/rtl8723bs/hal/odm_debug.h drivers/staging/rtl8723bs/hal/odm_precomp.h+0 -890 replies

Reviews trailers per patch

None of the 43 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDan Carpenter
SeriesR-b
1/43
2/43
3/43
4/43
5/43
6/43
7/43
8/43
9/43
10/43
11/43
12/43
13/43
14/43
15/43
16/43
17/43
18/43
19/43
20/43
21/43
22/43
23/43
24/43
25/43
26/43
27/43
28/43
29/43
30/43
31/43
32/43
33/43
34/43
35/43
36/43
37/43
38/43
39/43
40/43
41/43
42/43
43/43

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/43] staging: rtl8723bs: clean up driver from private debug facilities

This patchset remove all private debug facilities. It removes unused macros and _do nothing_ ones (i.e. macros whose behaviour is activated by manual code update). Replace tracing macros wrapping raw printk calls by netdev_dbg() calls which is best suited for a network driver.

Remove all unused macros and function definition tied to the whole private tracing facility.

------------------------------------------------
Changes in v3:
- fix spelling error in subject of patch 2 as reported by Bryan Brattlof.
Changes in v2:
- fix patch 4 did not compile due to missing removal of target file in Makefile (as reported by kernel test robot). Remove deleted file target.
- patch 40 did not compile due to missing removal of target file in Makefile. Remove deleted file taget.
- reword of both patches 4 and 40.

Fabio Aiuto (43):
staging: rtl8723bs: remove ODM_RT_TRACE logs
staging: rtl8723bs: remove if-else blocks left empty by ODM_RT_TRACE
deletion
staging: rtl8723bs: remove empty functions
staging: rtl8723bs: remove empty hal/odm_PathDiv.c source file
staging: rtl8723bs: remove undefined function prototypes
staging: rtl8723bs: remove empty header file
staging: rtl8723bs: remove ODM_RT_TRACE* unused macro defs
staging: rtl8723bs: remove all commented out ODM_RT_TRACE logs
staging: rtl8723bs: replace ODM_RT_ASSERT with netdev_dbg()
staging: rtl8723bs: remove unused ODM_RT_ASSERT macro
staging: rtl8723bs: remove unused ODM_PRINT_ADDR macro
staging: rtl8723bs: remove unused ODM_dbg_trace macro
staging: rtl8723bs: remove unused ODM_dbg_enter
staging: rtl8723bs: remove unused ODM_dbg_exit macro
staging: rtl8723bs: remove empty ifdef block
staging: rtl8723bs: remove unused ASSERT macro
staging: rtl8723bs: remove empty #ifndef block
staging: rtl8723bs: remove commented out RT_ASSERT occurrences
staging: rtl8723bs: remove unused RT_PRINTK macro
staging: rtl8723bs: remove BTC_PRINT logs
staging: rtl8723bs: remove empty if-else blocks after BTC_PRINT
removal
staging: rtl8723bs: remove braces around single statement in if block
staging: rtl8723bs: remove commented out BTC_PRINT logs
staging: rtl8723bs: remove BTC_PRINT macro definitions
staging: rtl8723bs: remove BTC_PRINT_ADDR macro definitions
staging: rtl8723bs: remove BTC_PRINT_DATA definitions
staging: rtl8723bs: remove BTC_PRINT_F macro definition
staging: rtl8723bs: remove empty #ifdef block
staging: rtl8723bs: remove unsed hal_btcoex_SetDBG() function
staging: rtl8723bs: remove hal_btcoex_GetDBG() function
staging: rtl8723bs: remove unnecessary halbtcoutsrc_DbgInit() function
staging: rtl8723bs: remove obsolete GLBtcDbgType array declarations
staging: rtl8723bs: remove unused enum
staging: rtl8723bs: remove obsolete debug macros
staging: rtl8723bs: remove commented out DbgPrint logs
staging: rtl8723bs: remove unused DbgPrint macro
staging: rtl8723bs: remove commented out *RT_DISP logs
staging: rtl8723bs: remove RT_DISP macro definition
staging: rtl8723bs: remove ODM_InitDebugSetting() function
staging: rtl8723bs: remove empty hal/odm_debug.c file
staging: rtl8723bs: remove member in dm_odm_t struct
staging: rtl8723bs: remove DebugLevel member in dm_odm_t struct
staging: rtl8723bs: remove odm_debug.h header file

 drivers/staging/rtl8723bs/Makefile            |   2 -
 drivers/staging/rtl8723bs/core/rtw_efuse.c    |   1 -
 drivers/staging/rtl8723bs/core/rtw_recv.c     |  22 -
 .../staging/rtl8723bs/hal/HalBtc8723b1Ant.c   | 604 +-----------------
 .../staging/rtl8723bs/hal/HalBtc8723b2Ant.c   | 502 +--------------
 drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h  |  67 --
 .../staging/rtl8723bs/hal/HalHWImg8723B_BB.c  |  62 --
 .../staging/rtl8723bs/hal/HalHWImg8723B_MAC.c |  49 --
 .../staging/rtl8723bs/hal/HalHWImg8723B_RF.c  |  63 --
 drivers/staging/rtl8723bs/hal/HalPhyRf.c      | 332 ----------
 .../staging/rtl8723bs/hal/HalPhyRf_8723B.c    | 177 +----
 drivers/staging/rtl8723bs/hal/hal_btcoex.c    | 171 -----
 drivers/staging/rtl8723bs/hal/hal_com.c       |  14 -
 drivers/staging/rtl8723bs/hal/odm.c           |  53 +-
 drivers/staging/rtl8723bs/hal/odm.h           |   4 -
 .../staging/rtl8723bs/hal/odm_CfoTracking.c   | 107 ----
 drivers/staging/rtl8723bs/hal/odm_DIG.c       | 320 ----------
 .../rtl8723bs/hal/odm_EdcaTurboCheck.c        |  18 -
 drivers/staging/rtl8723bs/hal/odm_HWConfig.c  |  38 --
 .../staging/rtl8723bs/hal/odm_NoiseMonitor.c  |  27 -
 drivers/staging/rtl8723bs/hal/odm_PathDiv.c   |  34 -
 drivers/staging/rtl8723bs/hal/odm_PathDiv.h   |  21 -
 drivers/staging/rtl8723bs/hal/odm_RTL8723B.c  |   1 -
 .../rtl8723bs/hal/odm_RegConfig8723B.c        |  66 --
 drivers/staging/rtl8723bs/hal/odm_debug.c     |  44 --
 drivers/staging/rtl8723bs/hal/odm_debug.h     | 165 -----
 drivers/staging/rtl8723bs/hal/odm_precomp.h   |   2 -
 .../staging/rtl8723bs/hal/rtl8723b_hal_init.c |   3 -
 drivers/staging/rtl8723bs/hal/sdio_halinit.c  |   7 -
 .../staging/rtl8723bs/include/hal_btcoex.h    |   2 -
 30 files changed, 6 insertions(+), 2972 deletions(-)
 delete mode 100644 drivers/staging/rtl8723bs/hal/odm_PathDiv.c
 delete mode 100644 drivers/staging/rtl8723bs/hal/odm_PathDiv.h
 delete mode 100644 drivers/staging/rtl8723bs/hal/odm_debug.c
 delete mode 100644 drivers/staging/rtl8723bs/hal/odm_debug.h
Signature · 1 line
2.20.1