Skip to content

pinctrl: renesas: Add r8a77995 bias pinconf support

Geert Uytterhoeven linux-gpio linux-renesas-soc 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v112 patches 15 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2pinctrl: renesas: rcar: Avoid changing PUDn when disabling biasdrivers/pinctrl/renesas/pinctrl.c+7 -71 reply
2/2pinctrl: renesas: r8a77995: Add bias pinconf supportdrivers/pinctrl/renesas/pfc-r8a77995.c drivers/pinctrl/renesas/pinctrl.c drivers/pinctrl/renesas/sh_pfc.h+316 -90 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchNiklas Söderlund
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] pinctrl: renesas: Add r8a77995 bias pinconf support

Hi all,

This patch series adds a small optimization to R-Car pin bias handling, and adds bias pinconf support for the R-Car D3 SoC.

Changes compared to v1[1]:
- Drop all accepted patches,
- Add [PATCH v2 1/2],
- Add Reviewed-by,
- Fix NFRE# and NFWE# handling, now we received confirmation that the documentation is correct.

The first patch has been tested on Koelsch and Salvator-XS. The second patch has been tested on a remote Draak development board by specifying one of the "bias-{pull-{down,enable},disable}" properties for the "GP_3_0" and "GP_3_1" pins from DT, and inspecting the impact on the PUEN2 and PUD2 registers. Due to the remote setup, actual voltage levels could not be measured. Note that enabling pull-down for "GP_3_0" breaks eMMC operation, as this pin is used as the eMMC's "CMD" signal.

I plan to queue this in renesas-pinctrl for v5.15.

Thanks for your comments!

[1] [PATCH 00/12] pinctrl: renesas: Add more bias pinconf support

    https://lore.kernel.org/linux-renesas-soc/[email protected]/

Geert Uytterhoeven (2):
pinctrl: renesas: rcar: Avoid changing PUDn when disabling bias
pinctrl: renesas: r8a77995: Add bias pinconf support

 drivers/pinctrl/renesas/pfc-r8a77995.c | 320 ++++++++++++++++++++++++-
 drivers/pinctrl/renesas/pinctrl.c      |  16 +-
 drivers/pinctrl/renesas/sh_pfc.h       |   3 +
 3 files changed, 323 insertions(+), 16 deletions(-)
Signature · 12 lines
2.25.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds