MP_FAIL support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest5 patches 2 repliesIn review
- v65 patches 5 repliesSuperseded
- v55 patches 4 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 5 patches | 1 reply | Superseded | |
| v3 | 8 patches | 12 replies | Superseded | |
| v2 | 5 patches | 3 replies | Superseded | |
| v1 | 3 patches | 2 replies | Superseded |
Changes in v7 from the cover letter
- The single subflow case is handled by sending MP_FAIL + RST instead of sending MP_FAIL echo.
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | mptcp: MP_FAIL suboption sendinginclude/ net/ net/ | +62 | 0 replies | |
| 2/5 | mptcp: MP_FAIL suboption receivingnet/ net/ net/ | +24 | 0 replies | |
| 3/5 | mptcp: send out MP_FAIL when data checksum failsnet/ net/ | +28 | 0 replies | |
| 4/5 | mptcp: add the mibs for MP_FAILnet/ net/ net/ +1 more | +6 | 0 replies | |
| 5/5 | selftests: mptcp: add MP_FAIL mibs checktools/ | +38 | 0 replies |
Reviews trailers per patch
None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Mat Martineau |
|---|---|
| Series | R-b |
| 1/5 | |
| 2/5 | |
| 3/5 | |
| 4/5 | |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [MPTCP][PATCH v7 mptcp-next 0/5] MP_FAIL support
From: Geliang Tang <[email protected]>
v7:
- The single subflow case is handled by sending MP_FAIL + RST instead of sending MP_FAIL echo.
v6: only rebased patch 1
- move the struct member 'fail_seq' behind 'ext_copy'.
- define OPTION_MPTCP_FAIL to BIT(12), BIT(11) is used by DSS
- move the MP_FAIL writing code at the beginning of mptcp_write_options, and add the 'unlikely' tag.
- tag: export/20210728T080904
v5:
- patch 1, change "ret = true;" to "return true;"
- patch 3, in the single-subflow case, send MP_FAIL and receive the echo, then temporarily handled by reset.
v4:
- just deal with the multiple subflows case, put the single subflow case into the new 'infinite mapping' part.
v3:
- respond with MP_FAIL
- add single subflow check
- add infinite mapping sending and receiving
- export/20210626T054902
v2:
- MP_FAIL logic:
* Peer B send a DSS to peer A, and the data has been modify by the
middleboxes, then peer A detects the bad checksum.
* In the multiple subflows case, peer A sends MP_FAIL+RST back to peer B,
and peer A discards the data following the bad data sequence number. Peer B receives this MP_FAIL+RST, and close this subflow.
* In the single subflow case, using the simple implementation, peer A
sends MP_FAIL back to peer B, and peer A fallback to a regular TCP. Peer B receives this MP_FAIL, and fallback to a regular TCP.
Geliang Tang (5):
mptcp: MP_FAIL suboption sending
mptcp: MP_FAIL suboption receiving
mptcp: send out MP_FAIL when data checksum fails
mptcp: add the mibs for MP_FAIL
selftests: mptcp: add MP_FAIL mibs check
include/net/mptcp.h | 5 +- net/mptcp/mib.c | 2 + net/mptcp/mib.h | 2 + net/mptcp/options.c | 76 ++++++++++++++++++- net/mptcp/pm.c | 5 ++ net/mptcp/protocol.h | 19 +++++ net/mptcp/subflow.c | 16 ++++ .../testing/selftests/net/mptcp/mptcp_join.sh | 38 ++++++++++ 8 files changed, 158 insertions(+), 5 deletions(-)
Signature · 1 line
2.31.1