media: use pm_runtime_resume_and_get() on non-i2c drivers
Get series with b4
b4 am [email protected]Versions newest first
- v5 Latest25 patches 12 repliesIn review
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/25 | staging: media: imx7-mipi-csis: use pm_runtime_resume_and_get()drivers/ | +3 | 0 replies | |
| 2/25 | staging: media: atomisp: use pm_runtime_resume_and_get()drivers/ | +3 | 0 replies | |
| 3/25 | staging: media: ipu3: use pm_runtime_resume_and_get()drivers/ | +1 | 0 replies | |
| 4/25 | staging: media: cedrus_video: use pm_runtime_resume_and_get()drivers/ | +2 | 0 replies | |
| 5/25 | staging: media: tegra-vde: use pm_runtime_resume_and_get()drivers/ | +18 | 2 replies | |
| 6/25 | staging: media: tegra-video: use pm_runtime_resume_and_get()drivers/ drivers/ | +2 | 0 replies | |
| 7/25 | media: rockchip/rga: use pm_runtime_resume_and_get()drivers/ drivers/ | +4 | 1 reply | |
| 8/25 | media: sti/hva: use pm_runtime_resume_and_get()drivers/ | +9 | 0 replies | |
| 9/25 | media: ipu3: use pm_runtime_resume_and_get()drivers/ | +1 | 0 replies | |
| 10/25 | media: coda: use pm_runtime_resume_and_get()drivers/ | +4 | 0 replies | |
| 11/25 | media: mtk-jpeg: use pm_runtime_resume_and_get()drivers/ | +2 | 0 replies | |
| 12/25 | media: camss: use pm_runtime_resume_and_get()drivers/ drivers/ drivers/ +1 more | +9 | 0 replies | |
| 13/25 | media: venus: core: use pm_runtime_resume_and_get()drivers/ | +1 | 4 replies | |
| 14/25 | media: venus: vdec: use pm_runtime_resume_and_get()drivers/ | +3 | 1 reply | |
| 15/25 | media: venus: venc: use pm_runtime_resume_and_get()drivers/ | +3 | 1 reply | |
| 16/25 | media: rcar-fcp: use pm_runtime_resume_and_get()drivers/ | +1 | 1 reply | |
| 17/25 | media: rkisp1: use pm_runtime_resume_and_get()drivers/ | +1 | 1 reply | |
| 18/25 | media: s3c-camif: use pm_runtime_resume_and_get()drivers/ drivers/ | +4 | 0 replies | |
| 19/25 | media: s5p-mfc: use pm_runtime_resume_and_get()drivers/ | +2 | 0 replies | |
| 20/25 | media: stm32: use pm_runtime_resume_and_get()drivers/ | +3 | 0 replies | |
| 21/25 | media: sunxi: use pm_runtime_resume_and_get()drivers/ | +4 | 0 replies | |
| 22/25 | media: ti-vpe: use pm_runtime_resume_and_get()drivers/ drivers/ drivers/ | +11 | 0 replies | |
| 23/25 | media: vsp1: use pm_runtime_resume_and_get()drivers/ | +1 | 1 reply | |
| 24/25 | media: rcar-vin: use pm_runtime_resume_and_get()drivers/ drivers/ drivers/ | +16 | 0 replies | |
| 25/25 | media: hantro: use pm_runtime_resume_and_get()drivers/ | +2 | 0 replies |
Reviews trailers per patch
18 of 25 patches have a Reviewed-by or Acked-by.
| Patch | Ezequiel Garcia | Jonathan Cameron | Rui Miguel Silva | Sylwester Nawrocki | Robert Foss | Philipp Zabel | Niklas Söderlund | Laurent Pinchart | Stanimir Varbanov | Heiko Stuebner |
|---|---|---|---|---|---|---|---|---|---|---|
| 1/25 | A-b | |||||||||
| 2/25 | ||||||||||
| 3/25 | R-b | |||||||||
| 4/25 | A-b | |||||||||
| 5/25 | ||||||||||
| 6/25 | R-b | |||||||||
| 7/25 | R-b | R-b | ||||||||
| 8/25 | R-b | |||||||||
| 9/25 | ||||||||||
| 10/25 | R-b | |||||||||
| 11/25 | ||||||||||
| 12/25 | R-b | |||||||||
| 13/25 | T-b A-b | |||||||||
| 14/25 | T-b A-b | |||||||||
| 15/25 | T-b A-b | |||||||||
| 16/25 | R-b | |||||||||
| 17/25 | R-b | |||||||||
| 18/25 | R-b | |||||||||
| 19/25 | R-b | |||||||||
| 20/25 | ||||||||||
| 21/25 | ||||||||||
| 22/25 | ||||||||||
| 23/25 | R-b | |||||||||
| 24/25 | R-b | |||||||||
| 25/25 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 10 reviewers.
Cover letter [PATCH v5 00/25] media: use pm_runtime_resume_and_get() on non-i2c drivers
Dealing with PM runtime (RPM) is different than dealing with other kAPIs used on media, as most pm_runtime_get_*() functions won't return to the the state before the call if an error rises. They, instead, increment an usage_count.
Due to that, there were several bugs on media. Just on this review, we found 24 such errors.
So, let's use pm_runtime_resume_and_get() whenever possible, as it has two advantages over :
1. On errors, it decrements the usage count;
2. It always return zero on success or an error code. This prevents a common error pattern of checking if ret is not zero to identify for errors.
There are however a few places where calls to pm_runtime_get_sync() are kept. On several of those, a comment was added, in order to help preventing trivial patches that could try to change them.
PS.: This series was submitted already together with the fix patches at:
https://lore.kernel.org/linux-media/[email protected]/
I opted to break it on 3 parts, in order to make easier to review.
This is the third (and final) part.
Mauro Carvalho Chehab (25):
staging: media: imx7-mipi-csis: use pm_runtime_resume_and_get()
staging: media: atomisp: use pm_runtime_resume_and_get()
staging: media: ipu3: use pm_runtime_resume_and_get()
staging: media: cedrus_video: use pm_runtime_resume_and_get()
staging: media: tegra-vde: use pm_runtime_resume_and_get()
staging: media: tegra-video: use pm_runtime_resume_and_get()
media: rockchip/rga: use pm_runtime_resume_and_get()
media: sti/hva: use pm_runtime_resume_and_get()
media: ipu3: use pm_runtime_resume_and_get()
media: coda: use pm_runtime_resume_and_get()
media: mtk-jpeg: use pm_runtime_resume_and_get()
media: camss: use pm_runtime_resume_and_get()
media: venus: core: use pm_runtime_resume_and_get()
media: venus: vdec: use pm_runtime_resume_and_get()
media: venus: venc: use pm_runtime_resume_and_get()
media: rcar-fcp: use pm_runtime_resume_and_get()
media: rkisp1: use pm_runtime_resume_and_get()
media: s3c-camif: use pm_runtime_resume_and_get()
media: s5p-mfc: use pm_runtime_resume_and_get()
media: stm32: use pm_runtime_resume_and_get()
media: sunxi: use pm_runtime_resume_and_get()
media: ti-vpe: use pm_runtime_resume_and_get()
media: vsp1: use pm_runtime_resume_and_get()
media: rcar-vin: use pm_runtime_resume_and_get()
media: hantro: use pm_runtime_resume_and_get()
drivers/media/pci/intel/ipu3/ipu3-cio2-main.c | 3 +-- drivers/media/platform/coda/coda-common.c | 7 ++++--- .../media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 ++-- .../media/platform/qcom/camss/camss-csid.c | 6 ++---- .../media/platform/qcom/camss/camss-csiphy.c | 6 ++---- .../media/platform/qcom/camss/camss-ispif.c | 6 ++---- drivers/media/platform/qcom/camss/camss-vfe.c | 5 +++-- .../media/platform/qcom/venus/pm_helpers.c | 3 +-- drivers/media/platform/qcom/venus/vdec.c | 6 +++--- drivers/media/platform/qcom/venus/venc.c | 5 +++-- drivers/media/platform/rcar-fcp.c | 8 +------ drivers/media/platform/rcar-vin/rcar-csi2.c | 15 ++++++++++--- drivers/media/platform/rcar-vin/rcar-dma.c | 6 ++---- drivers/media/platform/rcar-vin/rcar-v4l2.c | 6 ++---- drivers/media/platform/rockchip/rga/rga-buf.c | 3 +-- drivers/media/platform/rockchip/rga/rga.c | 4 +++- .../platform/rockchip/rkisp1/rkisp1-capture.c | 3 +-- .../media/platform/s3c-camif/camif-capture.c | 2 +- drivers/media/platform/s3c-camif/camif-core.c | 5 +++-- drivers/media/platform/s5p-mfc/s5p_mfc_pm.c | 6 ++---- drivers/media/platform/sti/hva/hva-hw.c | 17 ++++++++------- drivers/media/platform/stm32/stm32-dcmi.c | 5 +++-- .../platform/sunxi/sun4i-csi/sun4i_v4l2.c | 6 ++++-- drivers/media/platform/ti-vpe/cal-video.c | 4 +++- drivers/media/platform/ti-vpe/cal.c | 8 ++++--- drivers/media/platform/ti-vpe/vpe.c | 8 +++---- drivers/media/platform/vsp1/vsp1_drv.c | 10 +-------- .../staging/media/atomisp/pci/atomisp_fops.c | 6 +++--- drivers/staging/media/hantro/hantro_drv.c | 5 ++--- drivers/staging/media/imx/imx7-mipi-csis.c | 7 +++---- drivers/staging/media/ipu3/ipu3.c | 3 +-- .../staging/media/sunxi/cedrus/cedrus_video.c | 6 ++---- drivers/staging/media/tegra-vde/vde.c | 21 ++++++++++++++++--- drivers/staging/media/tegra-video/csi.c | 3 +-- drivers/staging/media/tegra-video/vi.c | 3 +-- 35 files changed, 110 insertions(+), 111 deletions(-)
Signature · 1 line
2.30.2