Skip to content

Delayed inode error handling fixes

Josef Bacik linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btrfs: make btrfs_release_delayed_iref handle the !iref casefs/btrfs/delayed-inode.c+10 -90 replies
2/3btrfs: fix error handling in __btrfs_update_delayed_inodefs/btrfs/delayed-inode.c+4 -60 replies
3/3btrfs: abort transaction if we fail to update the delayed inodefs/btrfs/delayed-inode.c+3 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Delayed inode error handling fixes

Hello,

Here are 3 straightforward fixes, but they rely on eachother so I'm sending them as a series. The first changes how we do cleanup so that it can do the right thing in the case that we don't have an iref, this is to make the code cleaner in the error case. The second patch is to fix the error handling in __btrfs_update_delayed_inode so it actually does the proper cleanup if there's an error. And finally the last patch add's the abort() we need in order to not leave behind improper inode items that trip up fsck during error injection testing. Thanks,

Josef

Josef Bacik (3):
btrfs: make btrfs_release_delayed_iref handle the !iref case
btrfs: fix error handling in __btrfs_update_delayed_inode
btrfs: abort transaction if we fail to update the delayed inode

 fs/btrfs/delayed-inode.c | 32 +++++++++++++++++---------------
 1 file changed, 17 insertions(+), 15 deletions(-)
Signature · 1 line
2.26.3