Fix some issues at scripts/sphinx-pre-install
Status from this message: I've applied this set, thanks.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | scripts: sphinx-pre-install: rework the sphinx install logicscripts/ | +140 | 0 replies | |
| 2/2 | scripts: sphinx-pre-install: fix the need of virtenv packagesscripts/ | +74 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] Fix some issues at scripts/sphinx-pre-install
Currently, when using with --no-virtualenv, the script doesn't behave well, as it prints both instructions to install Sphinx via distribution's package manager and via pip.
Address it.
While here, rework the logic which recommends Sphinx install, by splitting it into three parts and making easier to maintain it, as there are too much complexity there. Splitting the Sphinx part of the logic on 3 separate functions allow to detect if the venv/virtualenv python packages are needed or not, and helps to have a cleaner logic.
Mauro Carvalho Chehab (2):
scripts: sphinx-pre-install: rework the sphinx install logic
scripts: sphinx-pre-install: fix the need of virtenv packages
scripts/sphinx-pre-install | 262 +++++++++++++++++++++++++------------ 1 file changed, 180 insertions(+), 82 deletions(-)
Signature · 1 line
2.31.1