Skip to content

9pfs: Twalk optimization

Christian Schoenebeck qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 6 repliesIn review
  2. v13 patches 3 repliesSuperseded

Changes in v2 from the cover letter

* Added a separate [NEW PATCH 1] for fixing not_same_qid() semantic.

* Code style: use sizeof(var-name) instead of sizeof(type-name)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/79pfs: fix not_same_qid()hw/9pfs/9p.c+1 -40 replies
2/79pfs: Twalk benchmarktests/qtest/virtio-9p-test.c+30 -00 replies
3/79pfs: capture root stathw/9pfs/9p.c hw/9pfs/9p.h+10 -10 replies
4/79pfs: drop fid_to_qid()hw/9pfs/9p.c+5 -180 replies
5/79pfs: replace not_same_qid() by same_stat_id()hw/9pfs/9p.c+3 -30 replies
6/79pfs: drop root_qidhw/9pfs/9p.c hw/9pfs/9p.h+0 -20 replies
7/79pfs: reduce latency of Twalkhw/9pfs/9p.c+70 -193 replies

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGreg Kurz
SeriesR-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] 9pfs: Twalk optimization

This patch set reduces latency of Twalk handling by reducing the amount of thread hops, similar to previous Treaddir optimization.

The performance gain of this patch set is not as spectacular as previously with Treaddir, but there is definitely a measurable difference.

The actualy performance optimization is patch 7. With the benchmark of patch 2, the runtime of the Twalk test was cut in half. In real world tests I measured a performance gain (i.e. running an entire guest OS, and hence mixed with all other kinds of 9p requests) of about 2%, again measured in a mix, not concentrated on Twalk alone.

v1 -> v2:

* Added a separate [NEW PATCH 1] for fixing not_same_qid() semantic.

* Code style: use sizeof(var-name) instead of sizeof(type-name)

    [PATCH 3].

* Split out dropping fid_to_qid() into separate [PATCH 4].

* Split out replacing not_same_qid() by same_stat_id() into separate

    [PATCH 5].

* Split out dropping root_qid into separate [PATCH 6].

Christian Schoenebeck (7):
9pfs: fix not_same_qid()
9pfs: Twalk benchmark
9pfs: capture root stat
9pfs: drop fid_to_qid()
9pfs: replace not_same_qid() by same_stat_id()
9pfs: drop root_qid
9pfs: reduce latency of Twalk

 hw/9pfs/9p.c                 | 128 +++++++++++++++++++++++------------
 hw/9pfs/9p.h                 |   2 +-
 tests/qtest/virtio-9p-test.c |  30 ++++++++
 3 files changed, 116 insertions(+), 44 deletions(-)
Signature · 1 line
2.20.1