Enhancements for PMD power management
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v10 Latest8 patches 1 replyIn review
- v98 patches 1 replySuperseded
- v87 patches 8 repliesSuperseded
Earlier versions · 7
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v7 | 7 patches | 6 replies | Superseded | |
| v6 | 7 patches | 12 replies | Superseded | |
| v5 | 7 patches | 7 replies | Superseded | |
| v4 | 7 patches | 0 replies | Superseded | |
| v3 | 7 patches | 7 replies | Superseded | |
| v2 | 7 patches | 7 replies | Superseded | |
| v1 | 7 patches | 25 replies | Superseded |
Changes in v10 from the cover letter
- Added missing changes to NIC feature .ini files
Patches in v10 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | eal: use callbacks for power monitoring comparisondoc/ drivers/ drivers/ +6 more | +122 | 0 replies | |
| 2/8 | net/af_xdp: add power monitor supportdrivers/ | +34 | 0 replies | |
| 3/8 | doc: add PMD power management NIC featuredoc/ doc/ doc/ +7 more | +19 | 0 replies | |
| 4/8 | eal: add power monitor for multiple eventslib/ lib/ lib/ +4 more | +137 | 0 replies | |
| 5/8 | power: remove thread safety from PMD power API'sdoc/ lib/ lib/ +1 more | +66 | 0 replies | |
| 6/8 | power: support callbacks for multiple Rx queuesdoc/ doc/ lib/ | +398 | 0 replies | |
| 7/8 | power: support monitoring multiple Rx queuesdoc/ lib/ | +90 | 0 replies | |
| 8/8 | examples/l3fwd-power: support multiq in PMD modesexamples/ | +0 | 0 replies |
Reviews trailers per patch
4 of 8 patches have a Reviewed-by or Acked-by.
| Patch | Konstantin Ananyev | David Hunt | Timothy McDaniel |
|---|---|---|---|
| 1/8 | A-b | T-b | A-b |
| 2/8 | |||
| 3/8 | |||
| 4/8 | T-b | ||
| 5/8 | A-b | T-b | |
| 6/8 | A-b | T-b | |
| 7/8 | A-b | T-b | |
| 8/8 | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [dpdk-dev] [PATCH v10 0/8] Enhancements for PMD power management
This patchset introduces several changes related to PMD power management:
- Changed monitoring intrinsics to use callbacks as a comparison function, based on previous patchset [1] but incorporating feedback [2] - this hopefully will make it possible to add support for .get_monitor_addr in virtio
- Add a new intrinsic to monitor multiple addresses, based on RTM instruction set and the TPAUSE instruction
- Add support for PMD power management on multiple queues, as well as all accompanying infrastructure and example apps changes
v10:
- Added missing changes to NIC feature .ini files
v9:
- Added all missing Acks and Tests
- Added a new commit with NIC features
- Addressed minor issues raised in review
v8:
- Fixed checkpatch issue
- Added comment explaining empty poll handling (Konstantin)
v7:
- Fixed various bugs
v6:
- Improved the algorithm for multi-queue sleep
- Fixed segfault and addressed other feedback
v5:
- Removed "power save queue" API and replaced with mechanism suggested by Konstantin
- Addressed other feedback
v4:
- Replaced raw number with a macro
- Fixed all the bugs found by Konstantin
- Some other minor corrections
v3:
- Moved some doc updates to NIC features list
v2:
- Changed check inversion to callbacks
- Addressed feedback from Konstantin
- Added doc updates where necessary
[1] http://patches.dpdk.org/project/dpdk/list/?series=16930&state=*
[2] http://patches.dpdk.org/project/dpdk/patch/819ef1ace187365a615d3383e54579e3d9fb216e.1620747068.git.anatoly.burakov@intel.com/#133274
Anatoly Burakov (8):
eal: use callbacks for power monitoring comparison net/af_xdp: add power monitor support
doc: add PMD power management NIC feature
eal: add power monitor for multiple events
power: remove thread safety from PMD power API's
power: support callbacks for multiple Rx queues
power: support monitoring multiple Rx queues examples/l3fwd-power: support multiq in PMD modes
doc/guides/nics/features.rst | 10 + doc/guides/nics/features/af_xdp.ini | 1 + doc/guides/nics/features/default.ini | 1 + doc/guides/nics/features/i40e.ini | 1 + doc/guides/nics/features/i40e_vf.ini | 1 + doc/guides/nics/features/iavf.ini | 1 + doc/guides/nics/features/ice.ini | 1 + doc/guides/nics/features/ixgbe.ini | 1 + doc/guides/nics/features/ixgbe_vf.ini | 1 + doc/guides/nics/features/mlx5.ini | 1 + doc/guides/prog_guide/power_man.rst | 74 +- doc/guides/rel_notes/release_21_08.rst | 11 + drivers/event/dlb2/dlb2.c | 17 +- drivers/net/af_xdp/rte_eth_af_xdp.c | 34 + drivers/net/i40e/i40e_rxtx.c | 20 +- drivers/net/iavf/iavf_rxtx.c | 20 +- drivers/net/ice/ice_rxtx.c | 20 +- drivers/net/ixgbe/ixgbe_rxtx.c | 20 +- drivers/net/mlx5/mlx5_rx.c | 17 +- examples/l3fwd-power/main.c | 6 - lib/eal/arm/rte_power_intrinsics.c | 11 + lib/eal/include/generic/rte_cpuflags.h | 2 + .../include/generic/rte_power_intrinsics.h | 68 +- lib/eal/ppc/rte_power_intrinsics.c | 11 + lib/eal/version.map | 3 + lib/eal/x86/rte_cpuflags.c | 2 + lib/eal/x86/rte_power_intrinsics.c | 90 ++- lib/power/meson.build | 3 + lib/power/rte_power_pmd_mgmt.c | 663 +++++++++++++----- lib/power/rte_power_pmd_mgmt.h | 6 + 30 files changed, 855 insertions(+), 262 deletions(-)
Signature · 1 line
2.25.1