Skip to content

Slightly how START_SYNC and WAIT_SYNC work

David Sterba linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4btrfs: sink wait_for_unblock parameter to async commitfs/btrfs/ioctl.c fs/btrfs/transaction.c fs/btrfs/transaction.h+4 -251 reply
2/4btrfs: inline wait_current_trans_commit_start in its callerfs/btrfs/transaction.c+7 -131 reply
3/4btrfs: replace async commit by pending actionsfs/btrfs/ioctl.c fs/btrfs/transaction.c fs/btrfs/transaction.h+5 -820 replies
4/4btrfs: remove fs_info::transaction_blocked_waitfs/btrfs/ctree.h fs/btrfs/disk-io.c fs/btrfs/super.c +1 more+4 -60 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchAnand Jain
1/4R-b
2/4R-b
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] Slightly how START_SYNC and WAIT_SYNC work

The async transaction commit ioctl has a subtle semantics that used to work for ceph. We need more straightforward semantics in progs (eg. when waiting for commit after subvolume deletion) and otherwise the async commit does a few annoying things.

Long explanation is in patch 3. I hope it works, but somebody please double check. It's a minor change in the commit logic, but merely removing some waiting, no other changes in state transitions.

David Sterba (4):
btrfs: sink wait_for_unblock parameter to async commit
btrfs: inline wait_current_trans_commit_start in its caller
btrfs: replace async commit by pending actions
btrfs: remove fs_info::transaction_blocked_wait

 fs/btrfs/ctree.h       |   1 -
 fs/btrfs/disk-io.c     |   5 +-
 fs/btrfs/ioctl.c       |  12 ++---
 fs/btrfs/super.c       |   1 -
 fs/btrfs/transaction.c | 103 +----------------------------------------
 fs/btrfs/transaction.h |   2 -
 6 files changed, 9 insertions(+), 115 deletions(-)
Signature · 1 line
2.31.1