Skip to content

Clause-22/Clause-45 MDIO regmap support fixups

Sander Vanheule lkml 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v12 patches 3 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2regmap: mdio: Fix regmap_bus pointer constnessdrivers/base/regmap/regmap-mdio.c+1 -10 replies
2/2regmap: mdio: Reject invalid addressesdrivers/base/regmap/regmap-mdio.c+16 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] Clause-22/Clause-45 MDIO regmap support fixups

A proposed patch to make C22 access more strict [1], was posted in reply to an RFC series which also added C45 register access [2]. It appears that as a result, the original RFC patches got merged instead.

Access functions are corrected to return -ENXIO, instead of silently ignoring any invalid high bits in the register offset.
Additionally, a warning about a discarded const qualifier is fixed.

[1] Proposed C22 patch:
https://lore.kernel.org/lkml/[email protected]/

[2] RFC series:
https://lore.kernel.org/lkml/[email protected]/

---
Changes since v1:

- Keep C45 access code, but apply fix for discarded pointer constness
- Return -ENXIO for invalid C45 access too, as done for invalid C22 access

Sander Vanheule (2):
regmap: mdio: Fix regmap_bus pointer constness
regmap: mdio: Reject invalid addresses

 drivers/base/regmap/regmap-mdio.c | 22 +++++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)
Signature · 1 line
2.31.1