Skip to content

cpufreq: Migrate away from ->stop_cpu() callback

Viresh Kumar linux-doc linux-pm linuxppc-dev lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 5 repliesIn review
  2. v31 of 3 patches 5 repliesSuperseded
  3. v23 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches5 repliesSuperseded

Changes in v4 from the cover letter

- Based on a cleanup patch [1] from Rafael, apart from 5.13-rc7.
- No need to update exit() for intel pstate anymore.
- Remove the stop_cpu() callback completely.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4cpufreq: cppc: Migrate to ->exit() callback instead of ->stop_cpu()drivers/cpufreq/cppc_cpufreq.c+24 -220 replies
2/4cpufreq: intel_pstate: Migrate to ->offline() instead of ->stop_cpu()drivers/cpufreq/intel_pstate.c+2 -83 replies
3/4cpufreq: powerenv: Migrate to ->exit() callback instead of ->stop_cpu()drivers/cpufreq/powernv-cpufreq.c+9 -142 replies
3/4cpufreq: powernv: Migrate to ->exit() callback instead of ->stop_cpu()drivers/cpufreq/powernv-cpufreq.c+9 -140 replies
4/4cpufreq: Remove stop_cpu() callbackDocumentation/cpu-freq/cpu-drivers.rst Documentation/translations/zh_CN/cpu-freq/cpu-drivers.rst drivers/cpufreq/cpufreq.c +1 more+0 -100 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchViresh Kumar
1/4
2/4A-b
3/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH V4 0/4] cpufreq: Migrate away from ->stop_cpu() callback

Hi Rafael,

These are based on your patch [1] now.

commit 367dc4aa932b ("cpufreq: Add stop CPU callback to cpufreq_driver interface") added the stop_cpu() callback to allow the drivers to do clean up before the CPU is completely down and its state can't be modified.

At that time the CPU hotplug framework used to call the cpufreq core's registered notifier for different events like CPU_DOWN_PREPARE and CPU_POST_DEAD. The stop_cpu() callback was called during the CPU_DOWN_PREPARE event.

This is no longer the case, cpuhp_cpufreq_offline() is called only once by the CPU hotplug core now and we don't really need two separate callbacks for cpufreq drivers, i.e. stop_cpu() and exit(), as everything can be done from the exit() callback itself.

Migrate to using the offline() or exit() callback instead of stop_cpu().

V3->V4:
- Based on a cleanup patch [1] from Rafael, apart from 5.13-rc7.
- No need to update exit() for intel pstate anymore.
- Remove the stop_cpu() callback completely.

--
Viresh

[1] https://lore.kernel.org/linux-pm/5490292.DvuYhMxLoT@kreacher/

Viresh Kumar (4):
cpufreq: cppc: Migrate to ->exit() callback instead of ->stop_cpu()
cpufreq: intel_pstate: Migrate to ->offline() instead of ->stop_cpu()
cpufreq: powerenv: Migrate to ->exit() callback instead of

    ->stop_cpu()

cpufreq: Remove stop_cpu() callback

 Documentation/cpu-freq/cpu-drivers.rst        |  3 --
 .../zh_CN/cpu-freq/cpu-drivers.rst            |  3 --
 drivers/cpufreq/cppc_cpufreq.c                | 46 ++++++++++---------
 drivers/cpufreq/cpufreq.c                     |  3 --
 drivers/cpufreq/intel_pstate.c                | 10 +---
 drivers/cpufreq/powernv-cpufreq.c             | 23 ++++------
 include/linux/cpufreq.h                       |  1 -
 7 files changed, 35 insertions(+), 54 deletions(-)
Signature · 1 line
2.31.1.272.g89b43f80a514