Skip to content

RFC btrfs buffered iomap support

Goldwyn Rodrigues linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest31 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/31iomap: Check if blocksize == PAGE_SIZE in to_iomap_page()fs/iomap/buffered-io.c+6 -41 reply
2/31iomap: Add submit_io to writepage_opsfs/iomap/buffered-io.c include/linux/iomap.h+16 -11 reply
3/31iomap: Export iomap_writepage_end_bio()fs/iomap/buffered-io.c include/linux/iomap.h+3 -10 replies
4/31iomap: Introduce iomap_readpage_opsfs/gfs2/aops.c fs/iomap/buffered-io.c fs/xfs/xfs_aops.c +2 more+64 -231 reply
5/31btrfs: writepage() lock extent before pagesfs/btrfs/extent_io.c+51 -151 reply
6/31btrfs: lock extents while truncatingfs/btrfs/inode.c+23 -62 replies
7/31btrfs: write() perform extent locks before locking pagefs/btrfs/file.c+16 -790 replies
8/31btrfs: btrfs_em_to_iomap () to convert em to iomapfs/btrfs/ctree.h fs/btrfs/file.c+24 -02 replies
9/31btrfs: Don't process pages if locked_page is NULLfs/btrfs/extent_io.c fs/btrfs/inode.c+5 -10 replies
10/31btrfs: Add btrfs_map_blocks to for iomap_writeback_opsfs/btrfs/inode.c+71 -01 reply
11/31btrfs: Use submit_io to submit btrfs writeback biosfs/btrfs/inode.c+16 -11 reply
12/31btrfs: endio sequence for writepagefs/btrfs/inode.c+18 -00 replies
13/31btrfs: do not checksum for free space inodefs/btrfs/disk-io.c+6 -31 reply
14/31btrfs: end EXTENT_MAP_INLINE writeback earlyfs/btrfs/inode.c+16 -10 replies
15/31btrfs: Switch to iomap_writepages()fs/btrfs/inode.c+3 -10 replies
16/31btrfs: remove force_page_uptodatefs/btrfs/file.c+6 -130 replies
17/31btrfs: Introduce btrfs_iomapfs/btrfs/file.c+28 -161 reply
18/31btrfs: Add btrfs_iomap_release()fs/btrfs/file.c+28 -140 replies
19/31btrfs: Add reservation information to btrfs_iomapfs/btrfs/file.c+25 -241 reply
20/31btrfs: Carve out btrfs_buffered_iomap_begin() from write pathfs/btrfs/file.c+59 -410 replies
21/31btrfs: Carve out btrfs_buffered_iomap_end from the write pathfs/btrfs/file.c+59 -380 replies
22/31btrfs: Set extents delalloc in iomap_endfs/btrfs/file.c+27 -310 replies
23/31btrfs: define iomap_page_opsfs/btrfs/file.c+11 -00 replies
24/31btrfs: Switch to iomap_file_buffered_write()fs/btrfs/file.c+27 -1300 replies
25/31btrfs: remove all page related functionsfs/btrfs/file.c+0 -1560 replies
26/31btrfs: use srcmap for read-before-write casesfs/btrfs/file.c+30 -00 replies
27/31btrfs: Rename end_bio_extent_readpage to btrfs_readpage_endiofs/btrfs/extent_io.c fs/btrfs/extent_io.h+7 -60 replies
28/31btrfs: iomap_begin() for buffered readfs/btrfs/inode.c+50 -00 replies
29/31btrfs: Use iomap_readpage_ops to allocate and submit biofs/btrfs/ctree.h fs/btrfs/extent_io.c fs/btrfs/extent_io.h +1 more+21 -20 replies
30/31btrfs: Do not call btrfs_io_bio_free_csum() if BTRFS_INODE_NODATASUM is not setfs/btrfs/extent_io.c+8 -40 replies
31/31btrfs: Switch to iomap_readpage() and iomap_readahead()fs/btrfs/inode.c+4 -130 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 00/31] btrfs buffered iomap support

From: Goldwyn Rodrigues <[email protected]>

This is an attempt to perform the bufered read and write using iomap on btrfs.
I propose these changes as an RFC because I would like to know on your comments on the feasibility of going ahead with the design. It is not feature complete with the most important support missing is multi-device and compression.
Sending to BTRFS mailing only for perspective from btrfs developers first.

Locking sequence change
One of the biggest architecture changes is locking extents before pages. writepage(), called during memory pressure provides the page which is locked already. Perform a best effort locking and work with what is feasible. For truncate->invalidatepage(), lock the pages before calling setsize(). Are there any other areas which need to be covered?

TODO
====

Bio submission for multi-device
Multi-device submission would require some work with respect to asynchronous completions. iomap can merge bio's making it larger than extent_map's map_length. There is a check in btrfs_map_bio which WARN()s on this. Perhaps a more modular approach of having callbacks would be easier to deal with.

Compression
This would require extra flags to iomap, say type IOMAP_ENCODED, which would require iomap to read/write complete extents as opposed to performing I/O on only what is requested. An additional field io_size would be required to know how much of compressed size maps to uncompressed size.

Known issues
============
BIO Submission: described above
Random WARN_ON in kernel/locking/lockdep.c:895 points to memory corruption.

Finally, I have added some questions in the patch headers as well.

Signature · 52 lines
Goldwyn


Goldwyn Rodrigues (31):
  iomap: Check if blocksize == PAGE_SIZE in to_iomap_page()
  iomap: Add submit_io to writepage_ops
  iomap: Export iomap_writepage_end_bio()
  iomap: Introduce iomap_readpage_ops
  btrfs: writepage() lock extent before pages
  btrfs: lock extents while truncating
  btrfs: write() perform extent locks before locking page
  btrfs: btrfs_em_to_iomap () to convert em to iomap
  btrfs: Don't process pages if locked_page is NULL
  btrfs: Add btrfs_map_blocks to for iomap_writeback_ops
  btrfs: Use submit_io to submit btrfs writeback bios
  btrfs: endio sequence for writepage
  btrfs: do not checksum for free space inode
  btrfs: end EXTENT_MAP_INLINE writeback early
  btrfs: Switch to iomap_writepages()
  btrfs: remove force_page_uptodate
  btrfs: Introduce btrfs_iomap
  btrfs: Add btrfs_iomap_release()
  btrfs: Add reservation information to btrfs_iomap
  btrfs: Carve out btrfs_buffered_iomap_begin() from write path
  btrfs: Carve out btrfs_buffered_iomap_end from the write path
  btrfs: Set extents delalloc in iomap_end
  btrfs: define iomap_page_ops
  btrfs: Switch to iomap_file_buffered_write()
  btrfs: remove all page related functions
  btrfs: use srcmap for read-before-write cases
  btrfs: Rename end_bio_extent_readpage to btrfs_readpage_endio
  btrfs: iomap_begin() for buffered read
  btrfs: Use iomap_readpage_ops to allocate and submit bio
  btrfs: Do not call btrfs_io_bio_free_csum() if BTRFS_INODE_NODATASUM
    is not set
  btrfs: Switch to iomap_readpage() and iomap_readahead()

 fs/btrfs/ctree.h       |   3 +
 fs/btrfs/disk-io.c     |   9 +-
 fs/btrfs/extent_io.c   | 103 +++++--
 fs/btrfs/extent_io.h   |   4 +
 fs/btrfs/file.c        | 642 ++++++++++++++---------------------------
 fs/btrfs/inode.c       | 219 ++++++++++++--
 fs/gfs2/aops.c         |   4 +-
 fs/iomap/buffered-io.c |  80 +++--
 fs/xfs/xfs_aops.c      |   4 +-
 fs/zonefs/super.c      |   4 +-
 include/linux/iomap.h  |  26 +-
 11 files changed, 601 insertions(+), 497 deletions(-)

-- 
2.31.1