Skip to content

Add generic-support for linux,elfcorehdr and fix riscv

Geert Uytterhoeven linux-arm-kernel linux-devicetree linux-riscv lkml 1 version NAK

Status from this message: NACK

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 11 repliesNAK

Patches in v1

#Subject and filesSizeRepliesApplied
1/3of: fdt: Add generic support for parsing elf core header propertiesDocumentation/devicetree/bindings/chosen.txt drivers/of/fdt.c+37 -63 replies
2/3riscv: Remove non-standard linux,elfcorehdr handlingarch/riscv/mm/init.c+0 -208 replies
3/3arm64: kdump: Remove custom linux,elfcorehdr parsingarch/arm64/mm/init.c+0 -210 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Add generic-support for linux,elfcorehdr and fix riscv

Hi all,

While working on v4 of "[PATCH v3] ARM: Parse kdump DT properties", I noticed the recently (v5.13-rc1) introduced RISC-V crash kernel support uses "linux,elfcorehdr" in a non-standard way. Instead of relying on a "linux,elfcorehdr" property under the "/chosen" node, RISC-V uses a reserved memory node with the "linux,elfcorehdr" compatible value.

As we may want to fix riscv before the release of v5.13, I decided not to wait until my full v4 is ready, but fast-track generic "linux,elfcorehdr" handling instead.

This series consists of 3 patches:
1. Generic handling of "linux,elfcorehdr", as requested by Rob in a review comment for [1],
2. Drop the non-standard code from riscv. It can just use the generic code instead (needs corresponding changes to WIP kexec-tools),
3. Drop the now duplicate code from arm64. This can be postponed, as it can co-exist safely with the generic code.

This has been tested on arm32 (with a WIP successor of [1]), and compile-tested on riscv64 and arm64.

Thanks for your comments!

[1] "[PATCH v3] ARM: Parse kdump DT properties"

    https://lore.kernel.org/linux-devicetree/[email protected]/

Geert Uytterhoeven (3):
of: fdt: Add generic support for parsing elf core header properties
riscv: Remove non-standard linux,elfcorehdr handling
arm64: kdump: Remove custom linux,elfcorehdr parsing

 Documentation/devicetree/bindings/chosen.txt |  6 ++--
 arch/arm64/mm/init.c                         | 21 -----------
 arch/riscv/mm/init.c                         | 20 -----------
 drivers/of/fdt.c                             | 37 ++++++++++++++++++--
 4 files changed, 37 insertions(+), 47 deletions(-)
Signature · 12 lines
2.25.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds