net: ethernat: ezchip: bug fixing and code improvments
Status from this message: This series was applied to netdev/net.git (refs/heads/master):
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 3 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | net: ethernet: ezchip: fix UAF in nps_enet_removedrivers/ | +1 | 0 replies | Applied |
| 2/3 | net: ethernet: ezchip: remove redundant checkdrivers/ | +1 | 0 replies | Applied |
| 3/3 | net: ethernet: ezchip: fix error handlingdrivers/ | +1 | 0 replies | Applied |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] net: ethernat: ezchip: bug fixing and code improvments
While manual code reviewing, I found some error in ezchip driver. Two of them looks very dangerous:
1. use-after-free in nps_enet_remove
Accessing netdev private data after free_netdev()
2. wrong error handling of platform_get_irq() It can cause passing negative irq to request_irq()
Also, in 2nd patch I removed redundant check to increase execution speed and make code more straightforward.
Pavel Skripkin (3):
net: ethernet: ezchip: fix UAF in nps_enet_remove
net: ethernet: ezchip: remove redundant check
net: ethernet: ezchip: fix error handling
drivers/net/ethernet/ezchip/nps_enet.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
Signature · 6 lines
2.32.0 _______________________________________________ Linux-kernel-mentees mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees