Skip to content

staging: rtl8723bs: remove 5Ghz code

Fabio Aiuto linux-staging lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest17 patches 2 repliesIn review
  2. v217 patches 3 repliesSuperseded
  3. v118 patches 14 repliesSuperseded

Changes in v3 from the cover letter

- delete a condition in patch 1 as pointed out by Hans
- fix in 'Changes in v2' text (pointed out).

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17staging: rtl8723bs: remove all 5Ghz network typesdrivers/staging/rtl8723bs/core/rtw_ap.c drivers/staging/rtl8723bs/core/rtw_ieee80211.c drivers/staging/rtl8723bs/core/rtw_mlme.c +10 more+14 -1680 replies
2/17staging: rtl8723bs: remove code related to unsupported channel bandwidthdrivers/staging/rtl8723bs/core/rtw_wlan_util.c drivers/staging/rtl8723bs/core/rtw_xmit.c drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +7 more+17 -1280 replies
3/17staging: rtl8723bs: remove unused enum items related to channel bondingdrivers/staging/rtl8723bs/include/rtw_rf.h+0 -80 replies
4/17staging: rtl8723bs: rename enum items related to channel bondingdrivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c drivers/staging/rtl8723bs/include/rtw_rf.h+10 -100 replies
5/17staging: rtl8723bs: remove 5Ghz field in struct registry_privdrivers/staging/rtl8723bs/include/drv_types.h drivers/staging/rtl8723bs/os_dep/os_intfs.c+0 -30 replies
6/17staging: rtl8723bs: remove struct rt_channel_plan_5gdrivers/staging/rtl8723bs/core/rtw_mlme_ext.c drivers/staging/rtl8723bs/include/rtw_mlme_ext.h drivers/staging/rtl8723bs/include/rtw_rf.h+8 -700 replies
7/17staging: rtl8723bs: remove all branchings between 2.4Ghz and 5Ghz band typesdrivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h +14 more+488 -8670 replies
8/17staging: rtl8723bs: beautify prototypes in include/hal_com_phycfg.hdrivers/staging/rtl8723bs/include/hal_com_phycfg.h+48 -1400 replies
9/17staging: rtl8723bs: remove 5Ghz code related to channel plan definitiondrivers/staging/rtl8723bs/core/rtw_mlme_ext.c drivers/staging/rtl8723bs/hal/hal_com_phycfg.c drivers/staging/rtl8723bs/include/hal_data.h +3 more+97 -2070 replies
10/17staging: rtl8723bs: remove some unused 5Ghz macro definitionsdrivers/staging/rtl8723bs/hal/odm.h drivers/staging/rtl8723bs/include/Hal8192CPhyReg.h drivers/staging/rtl8723bs/include/hal_com_reg.h +1 more+0 -60 replies
11/17staging: rtl8723bs: remove 5Ghz code related to RF power calibrationdrivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.c drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c drivers/staging/rtl8723bs/hal/odm.c +1 more+2 -1140 replies
12/17staging: rtl8723bs: remove VHT dead codedrivers/staging/rtl8723bs/core/rtw_mlme_ext.c drivers/staging/rtl8723bs/hal/hal_com.c drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +5 more+9 -7520 replies
13/17staging: rtl8723bs: remove unused ODM_CMNINFO_BOARD_TYPE enum itemdrivers/staging/rtl8723bs/hal/odm.c drivers/staging/rtl8723bs/hal/odm.h+1 -80 replies
14/17staging: rtl8723bs: fix macro value for 2.4Ghz only devicedrivers/staging/rtl8723bs/hal/odm.h+1 -40 replies
15/17staging: rtl8723bs: remove obsolete 5Ghz commentsdrivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c drivers/staging/rtl8723bs/os_dep/wifi_regd.c+0 -60 replies
16/17staging: rtl8723bs: fix check allowing 5Ghz settingsdrivers/staging/rtl8723bs/os_dep/ioctl_linux.c+3 -40 replies
17/17staging: rtl8723bs: remove item from TODO listdrivers/staging/rtl8723bs/TODO+0 -20 replies

Reviews trailers per patch

None of the 17 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchFabio AutoHans de Goede
SeriesT-b A-b
1/17
2/17
3/17
4/17
5/17
6/17
7/17
8/17
9/17
10/17
11/17
12/17
13/17
14/17
15/17
16/17
17/17

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/17] staging: rtl8723bs: remove 5Ghz code

This patch series removes all occurences of 5Ghz code over the driver as required from driver's TODO list:

- find and remove remaining code valid only for 5 GHz. most of the obvious one have been removed, but things like channel > 14 still exist.

rtl8723bs work on 2.4Ghz band and supports 802.11bgn standards. So all code related to 802.11a/ac standard is removed, as well as code related to channel numbers above 14.

VHT code is deleted as well, for it's related to 802.11ac.

Comments are fixed accordingly and many unused variables are deleted.

Every single patch of this series has been tested on a Lenovo Ideapad MIIX 300-10IBY except for the last one, for obvious reason (it deletes just the TODO item). So:

------------------------------------------------
Changes in v3:
- delete a condition in patch 1 as pointed out by Hans
- fix in 'Changes in v2' text (pointed out).
Changes in v2:
- drop v1 15/18 patch, for it deliberately does register writes as pointed out by Hans.

Fabio Aiuto (17):
staging: rtl8723bs: remove all 5Ghz network types
staging: rtl8723bs: remove code related to unsupported channel
bandwidth
staging: rtl8723bs: remove unused enum items related to channel
bonding
staging: rtl8723bs: rename enum items related to channel bonding
staging: rtl8723bs: remove 5Ghz field in struct registry_priv
staging: rtl8723bs: remove struct rt_channel_plan_5g
staging: rtl8723bs: remove all branchings between 2.4Ghz and 5Ghz band
types
staging: rtl8723bs: beautify prototypes in include/hal_com_phycfg.h
staging: rtl8723bs: remove 5Ghz code related to channel plan
definition
staging: rtl8723bs: remove some unused 5Ghz macro definitions
staging: rtl8723bs: remove 5Ghz code related to RF power calibration
staging: rtl8723bs: remove VHT dead code
staging: rtl8723bs: remove unused ODM_CMNINFO_BOARD_TYPE enum item
staging: rtl8723bs: fix macro value for 2.4Ghz only device
staging: rtl8723bs: remove obsolete 5Ghz comments
staging: rtl8723bs: fix check allowing 5Ghz settings
staging: rtl8723bs: remove item from TODO list

 drivers/staging/rtl8723bs/TODO                |    2 -
 drivers/staging/rtl8723bs/core/rtw_ap.c       |   11 +-
 .../staging/rtl8723bs/core/rtw_ieee80211.c    |   22 +-
 drivers/staging/rtl8723bs/core/rtw_mlme.c     |   10 -
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |  328 ++---
 .../staging/rtl8723bs/core/rtw_wlan_util.c    |   29 +-
 drivers/staging/rtl8723bs/core/rtw_xmit.c     |    5 +-
 .../staging/rtl8723bs/hal/HalBtc8723b1Ant.c   |    4 +-
 .../staging/rtl8723bs/hal/HalBtc8723b2Ant.c   |    5 +-
 drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h  |    1 -
 .../staging/rtl8723bs/hal/HalHWImg8723B_BB.c  |   17 +-
 .../staging/rtl8723bs/hal/HalHWImg8723B_RF.c  |  595 ++++-----
 .../staging/rtl8723bs/hal/HalPhyRf_8723B.c    |   19 +-
 drivers/staging/rtl8723bs/hal/hal_btcoex.c    |    4 -
 drivers/staging/rtl8723bs/hal/hal_com.c       |  241 ----
 .../staging/rtl8723bs/hal/hal_com_phycfg.c    | 1059 +++--------------
 drivers/staging/rtl8723bs/hal/odm.c           |   50 -
 drivers/staging/rtl8723bs/hal/odm.h           |   42 +-
 drivers/staging/rtl8723bs/hal/odm_DIG.c       |    2 -
 .../rtl8723bs/hal/odm_EdcaTurboCheck.c        |    4 +-
 .../rtl8723bs/hal/odm_RegConfig8723B.c        |    5 +-
 .../rtl8723bs/hal/odm_RegConfig8723B.h        |    2 -
 drivers/staging/rtl8723bs/hal/rtl8723b_dm.c   |    1 -
 .../staging/rtl8723bs/hal/rtl8723b_hal_init.c |   41 +-
 .../staging/rtl8723bs/hal/rtl8723b_phycfg.c   |   43 +-
 drivers/staging/rtl8723bs/hal/sdio_halinit.c  |    5 -
 .../rtl8723bs/include/Hal8192CPhyReg.h        |    2 -
 drivers/staging/rtl8723bs/include/drv_types.h |   10 +-
 drivers/staging/rtl8723bs/include/hal_com.h   |   62 +-
 .../rtl8723bs/include/hal_com_phycfg.h        |  198 +--
 .../staging/rtl8723bs/include/hal_com_reg.h   |    1 -
 drivers/staging/rtl8723bs/include/hal_data.h  |   40 +-
 drivers/staging/rtl8723bs/include/hal_pg.h    |    2 -
 drivers/staging/rtl8723bs/include/hal_phy.h   |   10 -
 drivers/staging/rtl8723bs/include/ieee80211.h |   67 +-
 .../staging/rtl8723bs/include/rtl8723b_xmit.h |   21 -
 drivers/staging/rtl8723bs/include/rtw_ht.h    |    4 -
 .../staging/rtl8723bs/include/rtw_mlme_ext.h  |   52 +-
 drivers/staging/rtl8723bs/include/rtw_rf.h    |   33 +-
 drivers/staging/rtl8723bs/include/wifi.h      |    1 -
 .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c |    4 -
 .../staging/rtl8723bs/os_dep/ioctl_linux.c    |    8 +-
 drivers/staging/rtl8723bs/os_dep/os_intfs.c   |   13 +-
 drivers/staging/rtl8723bs/os_dep/wifi_regd.c  |    4 -
 44 files changed, 640 insertions(+), 2439 deletions(-)
Signature · 1 line
2.20.1