Skip to content

some smatch fixes

Mauro Carvalho Chehab linux-media lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5media: dib8000: rewrite the init prbs logicdrivers/media/dvb-frontends/dib8000.c+39 -170 replies
2/5media: uvc: don't do DMA on stackdrivers/media/usb/uvc/uvc_v4l2.c drivers/media/usb/uvc/uvcvideo.h+7 -61 reply
3/5media: v4l2-flash-led-class: drop an useless checkdrivers/media/v4l2-core/v4l2-flash-led-class.c+1 -16 replies
4/5media: ivtv: prevent going past the hw arraysdrivers/media/pci/ivtv/ivtv-cards.h drivers/media/pci/ivtv/ivtv-i2c.c+58 -261 reply
5/5media: sti: don't copy past the sizedrivers/media/platform/sti/delta/delta-ipc.c+1 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] some smatch fixes

This 5 patch series addresses a couple of other smatch warnings.

One of the patches seem to be fixing an user-visible bug:

media: uvc: don't do DMA on stack

Basically, input selection at the UVC driver seems broken, as it is usind DMA on stack, which stopped working on Kernel 4.9.

In practice, the number of affected devices is probably small, as this affects UVC devices with multiple inputs. The vast majority of UVC ones have just one input.

Mauro Carvalho Chehab (5):
media: dib8000: rewrite the init prbs logic
media: uvc: don't do DMA on stack
media: v4l2-flash-led-class: drop an useless check
media: ivtv: prevent going past the hw arrays
media: sti: don't copy past the size

 drivers/media/dvb-frontends/dib8000.c         | 56 ++++++++++-----
 drivers/media/pci/ivtv/ivtv-cards.h           | 68 +++++++++++++------
 drivers/media/pci/ivtv/ivtv-i2c.c             | 16 +++--
 drivers/media/platform/sti/delta/delta-ipc.c  |  3 +-
 drivers/media/usb/uvc/uvc_v4l2.c              | 10 ++-
 drivers/media/usb/uvc/uvcvideo.h              |  3 +
 .../media/v4l2-core/v4l2-flash-led-class.c    |  2 +-
 7 files changed, 106 insertions(+), 52 deletions(-)
Signature · 1 line
2.31.1