Skip to content

Add TDX Guest Support (Attestation support)

Kuppuswamy Sathyanarayanan bpf lkml netdev platform-driver-x86 6 versions – In review

Get series with b4
b4 am 20210806000946.2951441-1-sathyanarayanan.kuppuswamy@linux.intel.com

Versions newest first · linked by author and title

  1. v4 Latest7 patches 1 replyIn review
  2. v3 posting 2/25 patches 0 repliesSuperseded
  3. v3 posting 1/26 patches 6 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v2 posting 2/24 patches2 repliesSuperseded
v2 posting 1/26 patches20 repliesSuperseded
v16 patches1 replySuperseded

Changes in v4 from the cover letter

* Since the code added by patch titled "x86/tdx: Add tdg_debug_enabled() interface" is only used by other patches in this series, moved it here.
* Rebased on top of Tom Lendacky's protected guest
changes (https://lore.kernel.org/patchwork/cover/1468760/
* Rest of the history is included in individual patches.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7x86/tdx: Add tdg_debug_enabled() interfacearch/x86/include/asm/tdx.h arch/x86/kernel/tdx.c+7 -00 replies
2/7x86/tdx: Add TDREPORT TDX Module call supportarch/x86/include/asm/tdx.h arch/x86/kernel/tdx.c+35 -00 replies
3/7x86/tdx: Add GetQuote TDX hypercall supportarch/x86/include/asm/tdx.h arch/x86/kernel/tdx.c+36 -00 replies
4/7x86/tdx: Add SetupEventNotifyInterrupt TDX hypercall supportarch/x86/kernel/tdx.c+27 -00 replies
5/7x86/tdx: Add TDX Guest event notify interrupt vector supportarch/x86/include/asm/hardirq.h arch/x86/include/asm/idtentry.h arch/x86/include/asm/irq_vectors.h +3 more+61 -10 replies
6/7platform/x86: intel_tdx_attest: Add TDX Guest attestation interface driverdrivers/platform/x86/intel/Kconfig drivers/platform/x86/intel/Makefile drivers/platform/x86/intel/tdx/Kconfig +3 more+267 -00 replies
7/7tools/tdx: Add a sample attestation user apptools/Makefile tools/tdx/Makefile tools/tdx/attest/.gitignore +2 more+284 -60 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchTony LuckAndi KleenHans de Goede
SeriesA-b
1/7R-b R-b
2/7R-b R-b
3/7R-b R-b
4/7R-b R-b
5/7R-b R-b
6/7R-b R-b A-b
7/7R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/7] Add TDX Guest Support (Attestation support)

Hi All,

Intel's Trust Domain Extensions (TDX) protect guest VMs from malicious hosts and some physical attacks. VM guest with TDX support is called as TD Guest.

In TD Guest, the attestation process is used to verify the trustworthiness of TD guest to the 3rd party servers. Such attestation process is required by 3rd party servers before sending sensitive information to TD guests. One usage example is to get encryption keys from the key server for mounting the encrypted rootfs or secondary drive.

Following patches adds the attestation support to TDX guest which includes attestation user interface driver, user agent example, and related hypercall support.

In this series, only following patches are in arch/x86 and are intended for x86 maintainers review.

* x86/tdx: Add TDREPORT TDX Module call support
* x86/tdx: Add GetQuote TDX hypercall support
* x86/tdx: Add SetupEventNotifyInterrupt TDX hypercall support

Patch titled "platform/x86: intel_tdx_attest: Add TDX Guest attestation interface driver" adds the attestation driver support. This is supposed to be reviewed by platform-x86 maintainers.

Also, patch titled "tools/tdx: Add a sample attestation user app" adds a testing app for attestation feature which needs review from [email protected].

This series is the continuation of the following TDX patch series which added basic TDX guest support.

[set 1, v5] - https://lore.kernel.org/patchwork/project/lkml/list/?series=510805
[set 2, v4] - https://lore.kernel.org/patchwork/project/lkml/list/?series=510814
[set 3, v4] - https://lore.kernel.org/patchwork/project/lkml/list/?series=510816
[set 4, v4] - https://lore.kernel.org/patchwork/project/lkml/list/?series=510836
[set 5, v3] - https://lkml.org/lkml/2021/8/5/1195

Also please note that this series alone is not necessarily fully functional.

You can find TDX related documents in the following link.

https://software.intel.com/content/www/br/pt/develop/articles/intel-trust-domain-extensions.html

Changes since v3:
* Since the code added by patch titled "x86/tdx: Add tdg_debug_enabled() interface" is only used by other patches in this series, moved it here.
* Rebased on top of Tom Lendacky's protected guest
changes (https://lore.kernel.org/patchwork/cover/1468760/
* Rest of the history is included in individual patches.

Changes since v2:
* Rebased on top of v5.14-rc1.
* Rest of the history is included in individual patches.

Changes since v1:
* Included platform-x86 and test tool maintainers in recipient list.
* Fixed commit log and comments in attestation driver as per Han's comments.

Kuppuswamy Sathyanarayanan (7):
x86/tdx: Add tdg_debug_enabled() interface
x86/tdx: Add TDREPORT TDX Module call support
x86/tdx: Add GetQuote TDX hypercall support
x86/tdx: Add SetupEventNotifyInterrupt TDX hypercall support x86/tdx: Add TDX Guest event notify interrupt vector support platform/x86: intel_tdx_attest: Add TDX Guest attestation interface
driver
tools/tdx: Add a sample attestation user app

 arch/x86/include/asm/hardirq.h                |   1 +
 arch/x86/include/asm/idtentry.h               |   4 +
 arch/x86/include/asm/irq_vectors.h            |   7 +-
 arch/x86/include/asm/tdx.h                    |   8 +
 arch/x86/kernel/irq.c                         |   7 +
 arch/x86/kernel/tdx.c                         | 140 +++++++++++
 drivers/platform/x86/intel/Kconfig            |   1 +
 drivers/platform/x86/intel/Makefile           |   1 +
 drivers/platform/x86/intel/tdx/Kconfig        |  13 +
 drivers/platform/x86/intel/tdx/Makefile       |   3 +
 .../platform/x86/intel/tdx/intel_tdx_attest.c | 212 ++++++++++++++++
 include/uapi/misc/tdx.h                       |  37 +++
 tools/Makefile                                |  13 +-
 tools/tdx/Makefile                            |  19 ++
 tools/tdx/attest/.gitignore                   |   2 +
 tools/tdx/attest/Makefile                     |  24 ++
 tools/tdx/attest/tdx-attest-test.c            | 232 ++++++++++++++++++
 17 files changed, 717 insertions(+), 7 deletions(-)
 create mode 100644 drivers/platform/x86/intel/tdx/Kconfig
 create mode 100644 drivers/platform/x86/intel/tdx/Makefile
 create mode 100644 drivers/platform/x86/intel/tdx/intel_tdx_attest.c
 create mode 100644 include/uapi/misc/tdx.h
 create mode 100644 tools/tdx/Makefile
 create mode 100644 tools/tdx/attest/.gitignore
 create mode 100644 tools/tdx/attest/Makefile
 create mode 100644 tools/tdx/attest/tdx-attest-test.c
Signature · 1 line
2.25.1