Skip to content

mptcp: refactor active backup

Paolo Abeni mptcp oe-kbuild oe-kbuild-all 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 3 repliesIn review
  2. v17 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- stale_loss_cnt is now configurable via sysctl
- addressed buglet noted by Mat on v1
- fixed timeout update issues in patches 1-2
- fixed splat in __mptcp_clean_una() on reinection
- the new self-tests are now less unstable

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8mptcp: more accurate timeoutnet/mptcp/protocol.c+37 -230 replies
2/8mptcp: less aggressive retransmission stragegynet/mptcp/pm.c net/mptcp/protocol.c net/mptcp/protocol.h+37 -100 replies
3/8mptcp: handle pending data on closed subflownet/mptcp/options.c net/mptcp/protocol.c net/mptcp/protocol.h+82 -80 replies
4/8mptcp: cleanup sysctl data and helpersnet/mptcp/ctrl.c net/mptcp/protocol.h+10 -100 replies
5/8mptcp: faster active backup recoveryDocumentation/networking/mptcp-sysctl.rst net/mptcp/ctrl.c net/mptcp/pm.c +3 more+98 -51 reply
6/8mptcp: add mibs for stale subflows processingnet/mptcp/mib.c net/mptcp/mib.h net/mptcp/pm.c +2 more+8 -00 replies
7/8mptcp: backup flag from incoming MPJ ack optionnet/mptcp/subflow.c+4 -20 replies
8/8selftests: mptcp: add testcase for active-backtools/testing/selftests/net/mptcp/mptcp_join.sh+184 -310 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 mptcp-next 0/8] mptcp: refactor active backup

This series addresses a bunch of issues somewhat related to active backup handling. The most visible functial issue addressed here is:

https://github.com/multipath-tcp/mptcp_net-next/issues/191

This series also add some specific self-tests, to cover both active-backup switch-over and proper usage of backup link.

A new netns parameter is introduced:

stale_loss_cnt - the max amount of mptcp rtx timeouts with no progresses
and outstanding data over a single subflow needed to declare such subflow 'stale': no more data will be queue until some ack is observed.

Changes from v1:
- stale_loss_cnt is now configurable via sysctl
- addressed buglet noted by Mat on v1
- fixed timeout update issues in patches 1-2
- fixed splat in __mptcp_clean_una() on reinection
- the new self-tests are now less unstable

Paolo Abeni (8):
mptcp: more accurate timeout
mptcp: less aggressive retransmission stragegy
mptcp: handle pending data on closed subflow
mptcp: cleanup sysctl data and helpers
mptcp: faster active backup recovery
mptcp: add mibs for stale subflows processing
mptcp: backup flag from incoming MPJ ack option
selftests: mptcp: add testcase for active-back

 Documentation/networking/mptcp-sysctl.rst     |  12 +
 net/mptcp/ctrl.c                              |  26 ++-
 net/mptcp/mib.c                               |   2 +
 net/mptcp/mib.h                               |   2 +
 net/mptcp/options.c                           |   8 +-
 net/mptcp/pm.c                                |  21 ++
 net/mptcp/pm_netlink.c                        |  37 +++
 net/mptcp/protocol.c                          | 187 +++++++++++----
 net/mptcp/protocol.h                          |  31 ++-
 net/mptcp/subflow.c                           |   6 +-
 .../testing/selftests/net/mptcp/mptcp_join.sh | 215 +++++++++++++++---
 11 files changed, 459 insertions(+), 88 deletions(-)
Signature · 1 line
2.26.3