Skip to content

Remove highmem allocations, kmap/kunmap

David Sterba linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6btrfs: drop from __GFP_HIGHMEM all allocationsfs/btrfs/compression.c fs/btrfs/lzo.c fs/btrfs/raid56.c +2 more+14 -150 replies
2/6btrfs: compression: drop kmap/kunmap from lzofs/btrfs/lzo.c+10 -280 replies
3/6btrfs: compression: drop kmap/kunmap from zlibfs/btrfs/zlib.c+11 -250 replies
4/6btrfs: compression: drop kmap/kunmap from zstdfs/btrfs/zstd.c+9 -180 replies
5/6btrfs: compression: drop kmap/kunmap from generic helpersfs/btrfs/compression.c fs/btrfs/inode.c+2 -40 replies
6/6btrfs: check-integrity: drop kmap/kunmap for block pagesfs/btrfs/check-integrity.c+3 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] Remove highmem allocations, kmap/kunmap

The highmem was maybe was a good idea long time ago but with 64bit architectures everywhere I don't think we need to take it into account. This does not mean this 32bit won't work, just that it won't try to use temporary pages in highmem for compression and raid56. The key word is temporary. Combining a very fast device (like hundreds of megabytes throughput) and 32bit machine with reasonable memory (for 32bit, like 8G), it could become a problem once low memory is scarce.

David Sterba (6):
btrfs: drop from __GFP_HIGHMEM all allocations
btrfs: compression: drop kmap/kunmap from lzo
btrfs: compression: drop kmap/kunmap from zlib
btrfs: compression: drop kmap/kunmap from zstd
btrfs: compression: drop kmap/kunmap from generic helpers
btrfs: check-integrity: drop kmap/kunmap for block pages

 fs/btrfs/check-integrity.c | 11 +++-------
 fs/btrfs/compression.c     |  6 ++----
 fs/btrfs/inode.c           |  3 +--
 fs/btrfs/lzo.c             | 42 +++++++++++---------------------------
 fs/btrfs/raid56.c          | 10 ++++-----
 fs/btrfs/zlib.c            | 42 +++++++++++++-------------------------
 fs/btrfs/zstd.c            | 33 +++++++++++-------------------
 7 files changed, 49 insertions(+), 98 deletions(-)
Signature · 1 line
2.31.1