Skip to content

Fix defect in TranslationBlock insertion procedure

Liren Wei qemu-devel 1 version Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2accel/tcg: Hoist tcg_tb_insert() up above tb_link_page()accel/tcg/translate-all.c+8 -11 reply
2/2tcg: Bake tb_destroy() into tcg_region_treeaccel/tcg/translate-all.c include/tcg/tcg.h tcg/region.c+7 -182 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Fix defect in TranslationBlock insertion procedure

TranslationBlocks are now inserted first into QHT and then into its corresponding tcg_region_tree. This is problematic under MTTCG, as other vCPU threads may immediately execute it, and even bailout before the TB itself is inserted into its tcg_region_tree, resulting in an incorrect CPUState after rewinding.

Liren Wei (2):
accel/tcg: Hoist tcg_tb_insert() up above tb_link_page()
tcg: Bake tb_destroy() into tcg_region_tree

 accel/tcg/translate-all.c | 15 ++++++++-------
 include/tcg/tcg.h         |  1 -
 tcg/region.c              | 18 +++++++-----------
 3 files changed, 15 insertions(+), 19 deletions(-)
Signature · 1 line
2.32.0