Skip to content

EADV-related fixes, select refactorings, restartable compat syscalls

Jan Kiszka xenomai 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9cobalt/posix/io: Remove unneeded special case of select_bind_onekernel/cobalt/posix/io.c+1 -120 replies
2/9cobalt/posix/io: Avoid err variable shadowingkernel/cobalt/posix/io.c kernel/cobalt/posix/syscall32.c+8 -70 replies
3/9cobalt/rtdm/fd: Fix comment typokernel/cobalt/rtdm/fd.c+1 -10 replies
4/9cobalt/rtdm/fd: Fix error code documentation of rtdm_fd_selectkernel/cobalt/rtdm/fd.c+5 -10 replies
5/9cobalt/rtdm/fd: Fix default handler setupskernel/cobalt/rtdm/fd.c+36 -250 replies
6/9cobalt/select: Add proper handling of EADVkernel/cobalt/posix/io.c kernel/cobalt/posix/syscall32.c lib/cobalt/select.c+13 -40 replies
7/9cobalt/posix/syscall32: Mark compat clock_nanosleep restartablekernel/cobalt/posix/syscall32.c+1 -10 replies
8/9cobalt/posix/compat: Privatize sys32_get/put_fdsetinclude/cobalt/kernel/compat.h kernel/cobalt/posix/compat.c+10 -120 replies
9/9cobalt/posix/io: Unify native and compat versions of selectkernel/cobalt/posix/io.c kernel/cobalt/posix/io.h kernel/cobalt/posix/syscall32.c+76 -1160 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] EADV-related fixes, select refactorings, restartable compat syscalls

This should resolved the EADV bug seen with select when called with Linux fds. It also fixes wrong EADV reporting for other services. And it adds the missing syscall restart support for clock_nanosleep and select when taking the compat path.

Please review and test carefully, some details are rather tricky.

I'm considering the EADV fixes for stable as well, though they will alter the return codes. But the current scheme was broken anyway.

Jan

CC Philippe Gerum <[email protected]>
CC Steve Freyder <[email protected]>

Jan Kiszka (9):
cobalt/posix/io: Remove unneeded special case of select_bind_one cobalt/posix/io: Avoid err variable shadowing cobalt/rtdm/fd: Fix comment typo
cobalt/rtdm/fd: Fix error code documentation of rtdm_fd_select cobalt/rtdm/fd: Fix default handler setups cobalt/select: Add proper handling of EADV cobalt/posix/syscall32: Mark compat clock_nanosleep restartable cobalt/posix/compat: Privatize sys32_get/put_fdset cobalt/posix/io: Unify native and compat versions of select

 include/cobalt/kernel/compat.h  |   8 +-
 kernel/cobalt/posix/compat.c    |  14 ++--
 kernel/cobalt/posix/io.c        | 131 +++++++++++++++++++++-----------
 kernel/cobalt/posix/io.h        |   3 +
 kernel/cobalt/posix/syscall32.c |  93 +----------------------
 kernel/cobalt/rtdm/fd.c         |  69 ++++++++++-------
 lib/cobalt/select.c             |   2 +-
 7 files changed, 146 insertions(+), 174 deletions(-)
Signature · 1 line
2.26.2