RFC TDX support
Get series with b4
b4 am [email protected]Versions newest first
- v2 RFC Latest44 patches 47 repliesIn review
Changes in v2 from the cover letter
- suppress level trigger/SMI/INIT/SIPI related to IOAPIC.
- add VM attribute sha384 to TD measurement.
- guest TSC Hz specification.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/44 | target/i386: Expose x86_cpu_get_supported_feature_word() for TDXtarget/ target/ | +5 | 1 reply | |
| 2/44 | kvm: Switch KVM_CAP_READONLY_MEM to a per-VM ioctl()accel/ | +1 | 1 reply | |
| 3/44 | i386/kvm: Move architectural CPUID leaf generation to separarte helpertarget/ target/ | +102 | 0 replies | |
| 4/44 | vl: Introduce machine_init_done_late notifierhw/ include/ | +28 | 2 replies | |
| 5/44 | linux-headers: Update headers to pull in TDX API changeslinux-headers/ linux-headers/ | +62 | 0 replies | |
| 6/44 | hw/i386: Introduce kvm-type for TDX guestdefault-configs/ hw/ hw/ +8 more | +124 | 6 replies | |
| 7/44 | i386/kvm: Squash getting/putting guest state for TDX VMstarget/ | +15 | 2 replies | |
| 8/44 | i386/kvm: Skip KVM_X86_SETUP_MCE for TDX gueststarget/ | +2 | 0 replies | |
| 9/44 | target/i386: kvm: don't synchronize guest tsc for TD guesttarget/ | +1 | 1 reply | |
| 10/44 | hw/i386: Initialize TDX via KVM ioctl() when kvm_type is TDXaccel/ include/ qapi/ +3 more | +172 | 2 replies | |
| 11/44 | i386/tdx: Implement user specified tsc frequencytarget/ target/ | +24 | 2 replies | |
| 12/44 | target/i386/tdx: Finalize the TD's measurement when machine is donetarget/ target/ target/ | +31 | 1 reply | |
| 13/44 | i386/tdx: Frame in tdx_get_supported_cpuid with KVM_TDX_CAPABILITIEStarget/ target/ target/ | +78 | 0 replies | |
| 14/44 | i386/tdx: Frame in the call for KVM_TDX_INIT_VCPUinclude/ target/ target/ +1 more | +29 | 0 replies | |
| 15/44 | i386/tdx: Add hook to require generic device loaderhw/ include/ target/ +1 more | +38 | 1 reply | |
| 16/44 | hw/i386: Add definitions from UEFI spec for volumes, resources, etc...hw/ | +496 | 1 reply | |
| 17/44 | i386/tdx: Add definitions for TDVF metadatainclude/ | +55 | 0 replies | |
| 18/44 | hw/i386: refactor e820_add_entry()hw/ | +28 | 1 reply | |
| 19/44 | hw/i386/e820: introduce a helper function to change type of e820hw/ hw/ | +73 | 1 reply | |
| 20/44 | i386/tdx: Parse tdx metadata and store the result into TdxGuestStatehw/ hw/ hw/ +4 more | +359 | 11 replies | |
| 21/44 | i386/tdx: Create the TD HOB list upon machine init donehw/ hw/ hw/ +1 more | +206 | 1 reply | |
| 22/44 | i386/tdx: Add TDVF memory via INIT_MEM_REGIONtarget/ | +16 | 0 replies | |
| 23/44 | i386/tdx: Use KVM_TDX_INIT_VCPU to pass HOB to TDVFtarget/ | +10 | 0 replies | |
| 24/44 | i386/tdx: Add MMIO HOB entrieshw/ hw/ | +74 | 1 reply | |
| 25/44 | q35: Move PCIe BAR check above PAM check in mch_write_config()hw/ | +5 | 0 replies | |
| 26/44 | pci-host/q35: Move PAM initialization above SMRAM initializationhw/ | +10 | 0 replies | |
| 27/44 | q35: Introduce smm_ranges property for q35-pci-hosthw/ hw/ include/ +1 more | +33 | 1 reply | |
| 28/44 | i386/tdx: Force x2apic mode and routing for TDshw/ include/ include/ +1 more | +21 | 1 reply | |
| 29/44 | target/i386: Add machine option to disable PIC/8259hw/ hw/ hw/ +1 more | +26 | 1 reply | |
| 30/44 | qom: implement property helper for sha384include/ qom/ | +93 | 0 replies | |
| 31/44 | target/i386/tdx: Allows mrconfigid/mrowner/mrownerconfig for TDX_INIT_VMqapi/ target/ target/ | +30 | 1 reply | |
| 32/44 | tdx: add kvm_tdx_enabled() accessor for later useinclude/ target/ | +6 | 2 replies | |
| 33/44 | qmp: add query-tdx-capabilities query-tdx commandinclude/ qapi/ target/ +2 more | +117 | 2 replies | |
| 34/44 | target/i386/tdx: set reboot action to shutdown when tdxtarget/ | +14 | 3 replies | |
| 35/44 | ioapic: add property to disable level interrupthw/ hw/ include/ | +48 | 0 replies | |
| 36/44 | hw/i386: add eoi_intercept_unsupported member to X86MachineStatehw/ include/ | +2 | 0 replies | |
| 37/44 | hw/i386: add option to forcibly report edge trigger in acpi tableshw/ hw/ | +124 | 0 replies | |
| 38/44 | hw/i386: plug eoi_intercept_unsupported to ioapichw/ hw/ hw/ +2 more | +17 | 0 replies | |
| 39/44 | ioapic: add property to disallow SMI delivery modehw/ hw/ include/ | +39 | 0 replies | |
| 40/44 | hw/i386: add a flag to disallow SMIhw/ hw/ hw/ +2 more | +22 | 0 replies | |
| 41/44 | ioapic: add property to disallow INIT/SIPI delivery modehw/ hw/ include/ | +41 | 0 replies | |
| 42/44 | hw/i386: add a flag to disable init/sipi delivery mode of interrupthw/ hw/ hw/ +2 more | +18 | 1 reply | |
| 43/44 | i386/tdx: disallow level interrupt and SMI/INIT/SIPI delivery modehw/ | +3 | 0 replies | |
| 44/44 | i386/tdx: disable S3/S4 unconditionallytarget/ | +20 | 0 replies |
Reviews trailers per patch
4 of 44 patches have a Reviewed-by or Acked-by.
| Patch | Connor Kuehl |
|---|---|
| 1/44 | R-b |
| 2/44 | R-b |
| 3/44 | |
| 4/44 | |
| 5/44 | |
| 6/44 | |
| 7/44 | |
| 8/44 | |
| 9/44 | R-b |
| 10/44 | |
| 11/44 | |
| 12/44 | R-b |
| 13/44 | |
| 14/44 | |
| 15/44 | |
| 16/44 | |
| 17/44 | |
| 18/44 | |
| 19/44 | |
| 20/44 | |
| 21/44 | |
| 22/44 | |
| 23/44 | |
| 24/44 | |
| 25/44 | |
| 26/44 | |
| 27/44 | |
| 28/44 | |
| 29/44 | |
| 30/44 | |
| 31/44 | |
| 32/44 | |
| 33/44 | |
| 34/44 | |
| 35/44 | |
| 36/44 | |
| 37/44 | |
| 38/44 | |
| 39/44 | |
| 40/44 | |
| 41/44 | |
| 42/44 | |
| 43/44 | |
| 44/44 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH v2 00/44] TDX support
From: Isaku Yamahata <[email protected]>
This patch series is to enable TDX support. This needs corresponding KVM patch for TDX [1]. The patch [1] requires more patches to be function. So this patch series is RFC. For those who want to try github repo is available at [2].
Patch series is organized as follows.
1- 5 code refactoring and simple hooks that will be used later 6- 9 introduce kvm type and tdx type. disallow non-usable operations
10-15 wire up necessary TDX kvm ioctl to initialize TD guest 16-24 load TDVF and setup necessary info for TDVF
25-26 prohibit unsupported operations related to SMM
28-29 force x2apic and disable PIC
30-31 allows user to specify sha384 value for TD guest 32-33 add qmp operation to query KVM capability and TD info
34 make reboot action shutdown
35-43 suppress level-trigger/SMI/INIT/SIPI
44 suppress S3/S4
TODO:
- gdb support
- sanity check of CPUID
Changes from v1:
- suppress level trigger/SMI/INIT/SIPI related to IOAPIC.
- add VM attribute sha384 to TD measurement.
- guest TSC Hz specification.
Links:
[1] KVM TDX patch series v2
https://patchwork.kernel.org/project/kvm/list/?series=510271
[2] intel public github
kvm TDX branch: https://github.com/intel/tdx/tree/kvm
TDX guest branch: https://github.com/intel/tdx/tree/guest
qemu TDX https://github.com/intel/qemu-tdx
[3] TDVF
https://github.com/tianocore/edk2-staging/tree/TDVF
[4] TDX specs
https://software.intel.com/content/www/us/en/develop/articles/intel-trust-domain-extensions.html
Chenyi Qiang (1):
qmp: add query-tdx-capabilities query-tdx command
Isaku Yamahata (29):
kvm: Switch KVM_CAP_READONLY_MEM to a per-VM ioctl()
vl: Introduce machine_init_done_late notifier
i386/kvm: Skip KVM_X86_SETUP_MCE for TDX guests target/i386: kvm: don't synchronize guest tsc for TD guest i386/tdx: Frame in the call for KVM_TDX_INIT_VCPU
hw/i386: Add definitions from UEFI spec for volumes, resources, etc... i386/tdx: Add definitions for TDVF metadata
hw/i386: refactor e820_add_entry()
hw/i386/e820: introduce a helper function to change type of e820 i386/tdx: Parse tdx metadata and store the result into TdxGuestState i386/tdx: Create the TD HOB list upon machine init done i386/tdx: Add TDVF memory via INIT_MEM_REGION
i386/tdx: Use KVM_TDX_INIT_VCPU to pass HOB to TDVF pci-host/q35: Move PAM initialization above SMRAM initialization
q35: Introduce smm_ranges property for q35-pci-host
qom: implement property helper for sha384
target/i386/tdx: Allows mrconfigid/mrowner/mrownerconfig for
TDX_INIT_VM
tdx: add kvm_tdx_enabled() accessor for later use target/i386/tdx: set reboot action to shutdown when tdx
ioapic: add property to disable level interrupt
hw/i386: add eoi_intercept_unsupported member to X86MachineState hw/i386: add option to forcibly report edge trigger in acpi tables hw/i386: plug eoi_intercept_unsupported to ioapic
ioapic: add property to disallow SMI delivery mode hw/i386: add a flag to disallow SMI
ioapic: add property to disallow INIT/SIPI delivery mode hw/i386: add a flag to disable init/sipi delivery mode of interrupt i386/tdx: disallow level interrupt and SMI/INIT/SIPI delivery mode i386/tdx: disable S3/S4 unconditionally
Sean Christopherson (9):
target/i386: Expose x86_cpu_get_supported_feature_word() for TDX i386/kvm: Move architectural CPUID leaf generation to separarte helper i386/kvm: Squash getting/putting guest state for TDX VMs i386/tdx: Frame in tdx_get_supported_cpuid with KVM_TDX_CAPABILITIES i386/tdx: Add hook to require generic device loader i386/tdx: Add MMIO HOB entries
q35: Move PCIe BAR check above PAM check in mch_write_config() i386/tdx: Force x2apic mode and routing for TDs target/i386: Add machine option to disable PIC/8259
Xiaoyao Li (5):
linux-headers: Update headers to pull in TDX API changes hw/i386: Introduce kvm-type for TDX guest
hw/i386: Initialize TDX via KVM ioctl() when kvm_type is TDX i386/tdx: Implement user specified tsc frequency target/i386/tdx: Finalize the TD's measurement when machine is done
accel/kvm/kvm-all.c | 4 +- default-configs/devices/i386-softmmu.mak | 1 + hw/core/generic-loader.c | 5 + hw/core/machine.c | 26 ++ hw/core/meson.build | 3 + hw/core/tdvf-stub.c | 6 + hw/i386/Kconfig | 5 + hw/i386/acpi-build.c | 103 +++-- hw/i386/acpi-common.c | 74 +++- hw/i386/e820_memory_layout.c | 114 +++++- hw/i386/e820_memory_layout.h | 1 + hw/i386/meson.build | 1 + hw/i386/microvm.c | 7 +- hw/i386/pc.c | 18 + hw/i386/pc_piix.c | 7 +- hw/i386/pc_q35.c | 9 +- hw/i386/pc_sysfw.c | 6 + hw/i386/tdvf-hob.c | 235 +++++++++++ hw/i386/tdvf-hob.h | 25 ++ hw/i386/tdvf.c | 312 ++++++++++++++ hw/i386/uefi.h | 496 +++++++++++++++++++++++ hw/i386/x86.c | 72 +++- hw/intc/apic_common.c | 12 + hw/intc/ioapic.c | 57 +++ hw/intc/ioapic_common.c | 68 ++++ hw/pci-host/q35.c | 67 +-- include/hw/i386/apic.h | 1 + include/hw/i386/apic_internal.h | 1 + include/hw/i386/ioapic_internal.h | 3 + include/hw/i386/pc.h | 3 + include/hw/i386/tdvf.h | 55 +++ include/hw/i386/x86.h | 14 +- include/hw/pci-host/q35.h | 1 + include/qom/object.h | 17 + include/sysemu/sysemu.h | 2 + include/sysemu/tdvf.h | 6 + include/sysemu/tdx.h | 22 + linux-headers/asm-x86/kvm.h | 60 +++ linux-headers/linux/kvm.h | 2 + qapi/misc-target.json | 59 +++ qapi/qom.json | 23 ++ qom/object.c | 76 ++++ target/i386/cpu.c | 4 +- target/i386/cpu.h | 3 + target/i386/kvm/kvm-stub.c | 5 + target/i386/kvm/kvm.c | 255 +++++++----- target/i386/kvm/kvm_i386.h | 5 + target/i386/kvm/meson.build | 1 + target/i386/kvm/tdx-stub.c | 33 ++ target/i386/kvm/tdx.c | 417 +++++++++++++++++++ target/i386/kvm/tdx.h | 58 +++ target/i386/monitor.c | 23 ++ 52 files changed, 2685 insertions(+), 198 deletions(-) create mode 100644 hw/core/tdvf-stub.c create mode 100644 hw/i386/tdvf-hob.c create mode 100644 hw/i386/tdvf-hob.h create mode 100644 hw/i386/tdvf.c create mode 100644 hw/i386/uefi.h create mode 100644 include/hw/i386/tdvf.h create mode 100644 include/sysemu/tdvf.h create mode 100644 include/sysemu/tdx.h create mode 100644 target/i386/kvm/tdx-stub.c create mode 100644 target/i386/kvm/tdx.c create mode 100644 target/i386/kvm/tdx.h
Signature · 1 line
2.25.1