Skip to content

fullmesh path manager support

Geliang Tang mptcp 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest6 patches 4 repliesIn review
  2. v65 patches 5 repliesSuperseded
  3. v55 patches 9 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v45 patches0 repliesSuperseded
v35 patches5 repliesSuperseded
v210 patches7 repliesSuperseded
v19 patches2 repliesSuperseded

Changes in v7 from the cover letter

- add a new patch to drop flags and ifindex arguments of __mptcp_subflow_connect().
- add more comments for the testcase.

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6mptcp: drop flags and ifindex argumentsnet/mptcp/pm_netlink.c net/mptcp/protocol.h net/mptcp/subflow.c+30 -72 replies
2/6mptcp: remote addresses fullmeshinclude/uapi/linux/mptcp.h net/mptcp/pm_netlink.c+58 -40 replies
3/6mptcp: local addresses fullmeshnet/mptcp/pm_netlink.c+63 -100 replies
4/6selftests: mptcp: set and print the fullmesh flagtools/testing/selftests/net/mptcp/pm_nl_ctl.c+15 -10 replies
5/6selftests: mptcp: add fullmesh testcasestools/testing/selftests/net/mptcp/mptcp_join.sh+63 -30 replies
6/6selftests: mptcp: delete uncontinuous removing idstools/testing/selftests/net/mptcp/mptcp_join.sh+6 -40 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMat Martineau
SeriesR-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [MPTCP][PATCH v7 mptcp-next 0/6] fullmesh path manager support

From: Geliang Tang <[email protected]>

v7:
- add a new patch to drop flags and ifindex arguments of __mptcp_subflow_connect().
- add more comments for the testcase.

v6:
- drop lookup_subflow_by_addrs()
- pass three arrays instead of 'entries' in fill_local_adresses_vec()
- drop the 'remote' argument of fill_local_addresses_vec
- drop the 'local' argument of fill_remote_addresses_vec
- fix the pm.subflows.
- add limit testcase.

v5:
- patch 1, add a new helper lookup_address_in_vec.
- patch 2, update pm.subflows in the non-fullmesh case.
- patch 4, add more tests.
- tag: export/20210727T054640

v4:
- add new helpers, fill_local/remote_addresses_vec
- add max_subflows checks
- add 'local' into the local addresses array only when no fullmesh entry found.
- add signal,fullmesh check

v3:
- the in-kernel fullmesh path manager has been dropped from this patchset, only keep the fullmesh flag support code.

v2:
- Implement the fullmesh mode as an extension to the netlink PM, not a standalone PM as Paolo suggested.
- drop duplicate code.
- add a new per endpoint flag MPTCP_PM_ADDR_FLAG_FULLMESH.

Geliang Tang (6):
mptcp: drop flags and ifindex arguments
mptcp: remote addresses fullmesh
mptcp: local addresses fullmesh
selftests: mptcp: set and print the fullmesh flag
selftests: mptcp: add fullmesh testcases
selftests: mptcp: delete uncontinuous removing ids

 include/uapi/linux/mptcp.h                    |   1 +
 net/mptcp/pm_netlink.c                        | 155 ++++++++++++++++--
 net/mptcp/protocol.h                          |   5 +-
 net/mptcp/subflow.c                           |   7 +-
 .../testing/selftests/net/mptcp/mptcp_join.sh |  76 ++++++++-
 tools/testing/selftests/net/mptcp/pm_nl_ctl.c |  16 +-
 6 files changed, 233 insertions(+), 27 deletions(-)
Signature · 1 line
2.31.1