Skip to content

Separate user/kernel QP creation logic

Leon Romanovsky linux-rdma lkml 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 0 repliesNew
  2. v17 patches 6 repliesApplied

Changes in v2 from the cover letter

* Resend
v1: https://lore.kernel.org/lkml/[email protected]
* Fixed typo: incline -> inline/
* Dropped ib_create_qp_uverbs() wrapper in favour of direct call.
* Moved kernel-doc to the actual ib_create_qp() function that users will use.
v0: https://lore.kernel.org/lkml/[email protected]

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7RDMA/mlx5: Delete not-available udata checkdrivers/infiniband/hw/mlx5/qp.c+0 -30 replies
2/7RDMA/core: Delete duplicated and unreachable codedrivers/infiniband/core/core_priv.h drivers/infiniband/core/verbs.c+5 -180 replies
3/7RDMA/core: Remove protection from wrong in-kernel API usagedrivers/infiniband/core/verbs.c+0 -100 replies
4/7RDMA/core: Reorganize create QP low-level functionsdrivers/infiniband/core/core_priv.h drivers/infiniband/core/verbs.c include/rdma/ib_verbs.h+81 -670 replies
5/7RDMA/core: Configure selinux QP during creationdrivers/infiniband/core/uverbs_cmd.c drivers/infiniband/core/uverbs_std_types_qp.c drivers/infiniband/core/verbs.c+7 -170 replies
6/7RDMA/core: Properly increment and decrement QP usecntsdrivers/infiniband/core/core_priv.h drivers/infiniband/core/uverbs_cmd.c drivers/infiniband/core/uverbs_std_types_qp.c +1 more+39 -490 replies
7/7RDMA/core: Create clean QP creations interface for uverbsdrivers/infiniband/core/core_priv.h drivers/infiniband/core/uverbs_cmd.c drivers/infiniband/core/uverbs_std_types_qp.c +1 more+52 -520 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH rdma-next v2 0/7] Separate user/kernel QP creation logic

From: Leon Romanovsky <[email protected]>

Changelog:
v2:
* Resend
v1: https://lore.kernel.org/lkml/[email protected]
* Fixed typo: incline -> inline/
* Dropped ib_create_qp_uverbs() wrapper in favour of direct call.
* Moved kernel-doc to the actual ib_create_qp() function that users will use.
v0: https://lore.kernel.org/lkml/[email protected]

---------------------------------------------------------------------------
Hi,

The "QP allocation" series shows clearly how convoluted the create QP flow and especially XRC_TGT flow, where it calls to kernel verb just to pass some parameters as NULL to the user create QP verb.

This series is a small step to make clean XRC_TGT flow by providing more clean user/kernel create QP verb separation.

It is based on the "QP allocation" series.

Thanks

Leon Romanovsky (7):
RDMA/mlx5: Delete not-available udata check RDMA/core: Delete duplicated and unreachable code RDMA/core: Remove protection from wrong in-kernel API usage RDMA/core: Reorganize create QP low-level functions RDMA/core: Configure selinux QP during creation RDMA/core: Properly increment and decrement QP usecnts RDMA/core: Create clean QP creations interface for uverbs

 drivers/infiniband/core/core_priv.h           |  58 +----
 drivers/infiniband/core/uverbs_cmd.c          |  31 +--
 drivers/infiniband/core/uverbs_std_types_qp.c |  29 +--
 drivers/infiniband/core/verbs.c               | 207 +++++++++++-------
 drivers/infiniband/hw/mlx5/qp.c               |   3 -
 include/rdma/ib_verbs.h                       |  16 +-
 6 files changed, 156 insertions(+), 188 deletions(-)
Signature · 1 line
2.31.1