Skip to content

virtio: Add virtio-device bindings

Viresh Kumar linux-devicetree linux-gpio linux-i2c lkml virtualization 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 11 repliesIn review
  2. v35 patches 16 repliesSuperseded
  3. v25 patches 7 repliesSuperseded

Changes in v4 from the cover letter

- The binding is named "virtio,deviceXXXXXXXX" now.
- The virtio binding doesn't restrict the node names anymore.
- The i2c/gpio nodes are named i2c and gpio now.
- Dropped including gpio.yaml.
- Updated code to match the new binding name.
- Use "type: object" in additional-property.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5dt-bindings: virtio: Add binding for virtio devicesDocumentation/devicetree/bindings/virtio/mmio.yaml Documentation/devicetree/bindings/virtio/virtio-device.yaml+43 -12 replies
2/5dt-bindings: i2c: Add bindings for i2c-virtioDocumentation/devicetree/bindings/i2c/i2c-virtio.yaml+51 -01 reply
3/5dt-bindings: gpio: Add bindings for gpio-virtioDocumentation/devicetree/bindings/gpio/gpio-virtio.yaml+59 -04 replies
4/5uapi: virtio_ids: Sync ids with specificationinclude/uapi/linux/virtio_ids.h+12 -00 replies
5/5virtio: Bind virtio device to device-tree nodedrivers/virtio/virtio.c+54 -30 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchWolfram SangArnd BergmannRob Herring
1/5R-b R-b
2/5A-b R-b R-b
3/5R-b R-b
4/5
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH V4 0/5] virtio: Add virtio-device bindings

Hi,

Currently the DT only provides support for following node types for virtio-mmio nodes:

        virtio_mmio@a000000 {
                dma-coherent;
                interrupts = <0x00 0x10 0x01>;
                reg = <0x00 0xa000000 0x00 0x200>;
                compatible = "virtio,mmio";
        };

Here, each virtio-mmio corresponds to a virtio-device. But there is no way for other users in the DT to show their dependency on virtio devices.

This patchset provides that support.

The first patch adds virtio-device bindings to allow for device sub-nodes to be present and the second patch updates the virtio core to update the of_node.

Other patches add bindings for i2c and gpio devices.

Tested on x86 with qemu for arm64.

V3->V4:
- The binding is named "virtio,deviceXXXXXXXX" now.
- The virtio binding doesn't restrict the node names anymore.
- The i2c/gpio nodes are named i2c and gpio now.
- Dropped including gpio.yaml.
- Updated code to match the new binding name.
- Use "type: object" in additional-property.

V2/2.1->V3:
- Added review-tags from Arnd and Wolfram.
- Only the 5th patch changed otherwise:
- Use of_device_is_compatible() instead of keeping a list of devices.
- Use snprintf (with BUG_ON on return value) to create the compatible string, whose length is fixed using "virtio,XXXXXXXX".
- Use dev_of_node().

V1->V2:
- The changes (both binding and code) are made at virtio level, instead of virtio-mmio. This allows the same to be used by all device types, irrespective of the transport mechanism.

- Dropped the reg property and used compatible in the form "virtio,<DID>".

- Dropped dt-bindings/virtio/virtio_ids.h.

- Add a patch to sync virtio-ids from spec, required for the last patch.

--
Viresh

Viresh Kumar (5):
dt-bindings: virtio: Add binding for virtio devices
dt-bindings: i2c: Add bindings for i2c-virtio
dt-bindings: gpio: Add bindings for gpio-virtio
uapi: virtio_ids: Sync ids with specification
virtio: Bind virtio device to device-tree node

 .../devicetree/bindings/gpio/gpio-virtio.yaml | 59 +++++++++++++++++++
 .../devicetree/bindings/i2c/i2c-virtio.yaml   | 51 ++++++++++++++++
 .../devicetree/bindings/virtio/mmio.yaml      |  3 +-
 .../bindings/virtio/virtio-device.yaml        | 41 +++++++++++++
 drivers/virtio/virtio.c                       | 57 +++++++++++++++++-
 include/uapi/linux/virtio_ids.h               | 12 ++++
 6 files changed, 219 insertions(+), 4 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/gpio/gpio-virtio.yaml
 create mode 100644 Documentation/devicetree/bindings/i2c/i2c-virtio.yaml
 create mode 100644 Documentation/devicetree/bindings/virtio/virtio-device.yaml
Signature · 1 line
2.31.1.272.g89b43f80a514