Skip to content

ALSA: scarlett2: note gen 3 support + fix four issues

Geoffrey D. Bennett alsa-devel 1 version Applied

Status from this message: Applied all four patches now. Thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 2 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4ALSA: scarlett2: Fix Mute/Dim/MSD Mode control namessound/usb/mixer_scarlett_gen2.c+2 -20 replies
2/4ALSA: scarlett2: Fix Direct Monitor control name for 2i2sound/usb/mixer_scarlett_gen2.c+6 -20 replies
3/4ALSA: scarlett2: Correct channel mute status after mute button pressedsound/usb/mixer_scarlett_gen2.c+7 -10 replies
4/4ALSA: scarlett2: Fix line out/speaker switching notificationssound/usb/mixer_scarlett_gen2.c+9 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] ALSA: scarlett2: note gen 3 support + fix four issues

Hi Takashi,

In the sound-5.14-rc1 merge commit log the highlights included:
"Scarlett2 mixer code fixes and enhancements". I think that the new support for Gen 3 devices is significant enough to be worth mentioning.

Can you add to the next update a note along the lines of "Support for Focusrite Scarlett Solo/2i2/4i4/8i6/18i8/18i20 Gen 3 audio interface proprietary mixer controls"?

This set of patches is relative to v5.14-rc2 and fixes four issues:

1. The Mute/Dim/MSD Mode controls are missing the direction/function parts of the syntax of standard control names as per Documentation/sound/designs/control-names.rst

- This could be considered a breaking-stable change if someone is relying on the Mute/Dim control names not changing. I think it's unlikely to be a problem as this driver is still considered experimental and not enabled by default, but if never changing control names is important, then you can drop this patch.

2. The Direct Monitor control on the 2i2 interface is an Enum, not a Switch.

- This changes a control name, but that control was only introduced in v5.14-rc1, so not a problem to change it now.

3. Fixes the mute status not being correctly read when the mute button is pressed.

- Not applicable for stable; those controls were introduced in v5.14-rc1.

4. Sends the correct notification on line out and speaker switching changes.

- Partly applicable to stable, but will need a separate patch.

Thanks,
Geoffrey.

Geoffrey D. Bennett (4):
ALSA: scarlett2: Fix Mute/Dim/MSD Mode control names
ALSA: scarlett2: Fix Direct Monitor control name for 2i2
ALSA: scarlett2: Correct channel mute status after mute button pressed
ALSA: scarlett2: Fix line out/speaker switching notifications

 sound/usb/mixer_scarlett_gen2.c | 34 +++++++++++++++++++++++----------
 1 file changed, 24 insertions(+), 10 deletions(-)
Signature · 1 line
2.31.1