sk_buff: optimize GRO for the common case
Status from this message: This series was applied to netdev/net-next.git (refs/heads/master):
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 6 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | sk_buff: introduce 'slow_gro' flagsinclude/ | +4 | 0 replies | Applied |
| 2/6 | sk_buff: track dst status in slow_groinclude/ include/ | +4 | 2 replies | Applied |
| 3/6 | sk_buff: track extension status in slow_gronet/ | +1 | 0 replies | Applied |
| 4/6 | net: optimize GRO for the common case.net/ net/ | +28 | 0 replies | Applied |
| 5/6 | skbuff: allow 'slow_gro' for skb carring sock referenceinclude/ net/ net/ | +24 | 0 replies | Applied |
| 6/6 | veth: use skb_prepare_for_gro()drivers/ | +1 | 0 replies | Applied |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH net-next 0/6] sk_buff: optimize GRO for the common case
This is a trimmed down revision of "sk_buff: optimize layout for GRO", specifically dropping the changes to the sk_buff layout[1].
This series tries to accomplish 2 goals:
- optimize the GRO stage for the most common scenario, avoiding a bunch of conditional and some more code
- let owned skbs entering the GRO engine, allowing backpressure in the veth GRO forward path.
A new sk_buff flag (!!!) is introduced and maintained for GRO's sake. Such field uses an existing hole, so there is no change to the sk_buff size.
[1] two main reasons:
- move skb->inner_ field requires some extra care, as some in kernel users access and the fields regardless of skb->encapsulation.
- extending secmark size clash with ct and nft uAPIs
address the all above is possible, I think, but for sure not in a single series.
Paolo Abeni (6):
sk_buff: introduce 'slow_gro' flags
sk_buff: track dst status in slow_gro
sk_buff: track extension status in slow_gro
net: optimize GRO for the common case.
skbuff: allow 'slow_gro' for skb carring sock reference
veth: use skb_prepare_for_gro()
drivers/net/veth.c | 2 +- include/linux/skbuff.h | 6 ++++++ include/net/dst.h | 2 ++ include/net/sock.h | 9 +++++++++ net/core/dev.c | 32 ++++++++++++++++++++++++-------- net/core/skbuff.c | 27 ++++++++++++++++++++------- 6 files changed, 62 insertions(+), 16 deletions(-)
Signature · 1 line
2.26.3