Skip to content

Implement generic cc_platform_has() helper function

Tom Lendacky amd-gfx dri-devel kexec kvm linux-efi linux-fsdevel linux-iommu linux-s390 linuxppc-dev lkml platform-driver-x86 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 38 repliesIn review
  2. v212 patches 32 repliesSuperseded
  3. v111 patches 31 repliesSuperseded

Changes in v3 from the cover letter

- Changed the name from prot_guest_has() to cc_platform_has()
- Took the cc_platform_has() function out of line. Created two new files, cc_platform.c, in both x86 and ppc to implment the function. As a result, also changed the attribute defines into enums.
- Removed any received Reviewed-by's and Acked-by's given changes in this version.
- Added removal of new instances of mem_encrypt_active() usage in powerpc arch.
- Based on latest Linux tree to pick up powerpc changes related to the mem_encrypt_active() function.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8x86/ioremap: Selectively build arch override encryption functionsarch/x86/include/asm/io.h arch/x86/mm/ioremap.c+9 -10 replies
2/8mm: Introduce a function to check for confidential computing featuresarch/Kconfig include/linux/cc_platform.h+91 -02 replies
3/8x86/sev: Add an x86 version of cc_platform_has()arch/x86/Kconfig arch/x86/include/asm/mem_encrypt.h arch/x86/kernel/Makefile +2 more+49 -01 reply
4/8powerpc/pseries/svm: Add a powerpc version of cc_platform_has()arch/powerpc/platforms/pseries/Kconfig arch/powerpc/platforms/pseries/Makefile arch/powerpc/platforms/pseries/cc_platform.c+29 -010 replies
5/8x86/sme: Replace occurrences of sme_active() with cc_platform_has()arch/x86/include/asm/kexec.h arch/x86/include/asm/mem_encrypt.h arch/x86/kernel/machine_kexec_64.c +7 more+31 -3517 replies
6/8x86/sev: Replace occurrences of sev_active() with cc_platform_has()arch/x86/include/asm/mem_encrypt.h arch/x86/kernel/crash_dump_64.c arch/x86/kernel/kvm.c +6 more+29 -310 replies
7/8x86/sev: Replace occurrences of sev_es_active() with cc_platform_has()arch/x86/include/asm/mem_encrypt.h arch/x86/kernel/sev.c arch/x86/mm/mem_encrypt.c +1 more+8 -170 replies
8/8treewide: Replace the use of mem_encrypt_active() with cc_platform_has()arch/powerpc/include/asm/mem_encrypt.h arch/powerpc/platforms/pseries/svm.c arch/s390/include/asm/mem_encrypt.h +15 more+31 -402 replies

Reviews trailers per patch

1 of 8 patches has a Reviewed-by or Acked-by.

PatchMichael Ellerman
1/8
2/8
3/8
4/8A-b
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/8] Implement generic cc_platform_has() helper function

This patch series provides a generic helper function, cc_platform_has(), to replace the sme_active(), sev_active(), sev_es_active() and mem_encrypt_active() functions.

It is expected that as new confidential computing technologies are added to the kernel, they can all be covered by a single function call instead of a collection of specific function calls all called from the same locations.

The powerpc and s390 patches have been compile tested only. Can the folks copied on this series verify that nothing breaks for them. Also, a new file, arch/powerpc/platforms/pseries/cc_platform.c, has been created for powerpc to hold the out of line function.

Cc Andi Kleen <[email protected]>
Cc Andy Lutomirski <[email protected]>
Cc Ard Biesheuvel <[email protected]>
Cc Baoquan He <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Cc Borislav Petkov <[email protected]>
Cc Christian Borntraeger <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Dave Hansen <[email protected]>
Cc Dave Young <[email protected]>
Cc David Airlie <[email protected]>
Cc Heiko Carstens <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Joerg Roedel <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Thomas Zimmermann <[email protected]>
Cc Vasily Gorbik <[email protected]>
Cc VMware Graphics <[email protected]>
Cc Will Deacon <[email protected]>
Cc Christoph Hellwig <[email protected]>

---

Patches based on:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master 4b93c544e90e ("thunderbolt: test: split up test cases in tb_test_credit_alloc_all")

Changes since v2:
- Changed the name from prot_guest_has() to cc_platform_has()
- Took the cc_platform_has() function out of line. Created two new files, cc_platform.c, in both x86 and ppc to implment the function. As a result, also changed the attribute defines into enums.
- Removed any received Reviewed-by's and Acked-by's given changes in this version.
- Added removal of new instances of mem_encrypt_active() usage in powerpc arch.
- Based on latest Linux tree to pick up powerpc changes related to the mem_encrypt_active() function.

Changes since v1:
- Moved some arch ioremap functions within #ifdef CONFIG_AMD_MEM_ENCRYPT in prep for use of prot_guest_has() by TDX.
- Added type includes to the the protected_guest.h header file to prevent build errors outside of x86.
- Made amd_prot_guest_has() EXPORT_SYMBOL_GPL
- Used amd_prot_guest_has() in place of checking sme_me_mask in the arch/x86/mm/mem_encrypt.c file.

Tom Lendacky (8):
x86/ioremap: Selectively build arch override encryption functions
mm: Introduce a function to check for confidential computing features x86/sev: Add an x86 version of cc_platform_has() powerpc/pseries/svm: Add a powerpc version of cc_platform_has() x86/sme: Replace occurrences of sme_active() with cc_platform_has() x86/sev: Replace occurrences of sev_active() with cc_platform_has() x86/sev: Replace occurrences of sev_es_active() with cc_platform_has()
treewide: Replace the use of mem_encrypt_active() with
cc_platform_has()

 arch/Kconfig                                 |  3 +
 arch/powerpc/include/asm/mem_encrypt.h       |  5 --
 arch/powerpc/platforms/pseries/Kconfig       |  1 +
 arch/powerpc/platforms/pseries/Makefile      |  2 +
 arch/powerpc/platforms/pseries/cc_platform.c | 26 ++++++
 arch/powerpc/platforms/pseries/svm.c         |  5 +-
 arch/s390/include/asm/mem_encrypt.h          |  2 -
 arch/x86/Kconfig                             |  1 +
 arch/x86/include/asm/io.h                    |  8 ++
 arch/x86/include/asm/kexec.h                 |  2 +-
 arch/x86/include/asm/mem_encrypt.h           | 14 +---
 arch/x86/kernel/Makefile                     |  3 +
 arch/x86/kernel/cc_platform.c                | 21 +++++
 arch/x86/kernel/crash_dump_64.c              |  4 +-
 arch/x86/kernel/head64.c                     |  4 +-
 arch/x86/kernel/kvm.c                        |  3 +-
 arch/x86/kernel/kvmclock.c                   |  4 +-
 arch/x86/kernel/machine_kexec_64.c           | 19 +++--
 arch/x86/kernel/pci-swiotlb.c                |  9 +-
 arch/x86/kernel/relocate_kernel_64.S         |  2 +-
 arch/x86/kernel/sev.c                        |  6 +-
 arch/x86/kvm/svm/svm.c                       |  3 +-
 arch/x86/mm/ioremap.c                        | 18 ++--
 arch/x86/mm/mem_encrypt.c                    | 57 +++++++------
 arch/x86/mm/mem_encrypt_identity.c           |  3 +-
 arch/x86/mm/pat/set_memory.c                 |  3 +-
 arch/x86/platform/efi/efi_64.c               |  9 +-
 arch/x86/realmode/init.c                     |  8 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c      |  4 +-
 drivers/gpu/drm/drm_cache.c                  |  4 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_drv.c          |  4 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_msg.c          |  6 +-
 drivers/iommu/amd/init.c                     |  7 +-
 drivers/iommu/amd/iommu.c                    |  3 +-
 drivers/iommu/amd/iommu_v2.c                 |  3 +-
 drivers/iommu/iommu.c                        |  3 +-
 fs/proc/vmcore.c                             |  6 +-
 include/linux/cc_platform.h                  | 88 ++++++++++++++++++++
 include/linux/mem_encrypt.h                  |  4 -
 kernel/dma/swiotlb.c                         |  4 +-
 40 files changed, 267 insertions(+), 114 deletions(-)
 create mode 100644 arch/powerpc/platforms/pseries/cc_platform.c
 create mode 100644 arch/x86/kernel/cc_platform.c
 create mode 100644 include/linux/cc_platform.h

base-commit: 4b93c544e90e2b28326182d31ee008eb80e02074

Signature · 1 line
2.33.0