Skip to content

net: stmmac: Add ethtool per-queue statistic

Vijayakannan Ayyathurai linux-arm-kernel lkml netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (refs/heads/master):

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 3 repliesApplied 3/3

Patches in v1 All 3 applied

#Subject and filesSizeRepliesApplied
1/3net: stmmac: fix INTR TBU status affecting irq count statisticdrivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c+3 -21 replyApplied
2/3net: stmmac: add ethtool per-queue statistic frameworkdrivers/net/ethernet/stmicro/stmmac/common.h drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c drivers/net/ethernet/stmicro/stmmac/stmmac_main.c+80 -11 replyApplied
3/3net: stmmac: add ethtool per-queue irq statistic supportdrivers/net/ethernet/stmicro/stmmac/common.h drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c+6 -01 replyApplied

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchWong Vee Khee
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next v1 0/3] net: stmmac: Add ethtool per-queue statistic

Adding generic ethtool per-queue statistic framework to display the statistics for each rx/tx queue. In future, users can avail it to add more per-queue specific counters. Number of rx/tx queues displayed is depending on the available rx/tx queues in that particular MAC config and this number is limited up to the MTL_MAX_{RX|TX}_QUEUES defined in the driver.

Ethtool per-queue statistic display will look like below, when users start adding more counters.

Example - 1:
q0_tx_statA:
q0_tx_statB:
q0_tx_statC:
|
q0_tx_statX:
.
.
.
qMAX_tx_statA:
qMAX_tx_statB:
qMAX_tx_statC:
|
qMAX_tx_statX:

q0_rx_statA:
q0_rx_statB:
q0_rx_statC:
|
q0_rx_statX:
.
.
.
qMAX_rx_statA:
qMAX_rx_statB:
qMAX_rx_statC:
|
qMAX_rx_statX:

Example - 2: Ping test using the tx queue 3.

$ tc qdisc add dev enp0s30f4 root mqprio num_tc 2 map 1 0 0 0 0 0 0 0
 0 0 0 0 0 0 0 0 queues 3@0 1@3 hw 0

Statistic before ping:
---------------------

$ ethtool -S enp0s30f4

[ snip ]

     q3_tx_pkt_n: 7916
     q3_tx_irq_n: 316

[ snip ]

$ cat /proc/interrupts

[ snip ]
143: 0 0 0 316 0 0

         0          0  IR-PCI-MSI 499719-edge      enp0s30f4:tx-3

[ snip ]

$ ping -I enp0s30f4 192.168.1.10 -i 0.01 -c 100 > /dev/null

Statistic after ping:
---------------------

$ ethtool -S enp0s30f4

[ snip ]

     q3_tx_pkt_n: 8016
     q3_tx_irq_n: 320

[ snip ]

$ cat /proc/interrupts

[ snip ]
143: 0 0 0 320 0 0

         0          0  IR-PCI-MSI 499719-edge      enp0s30f4:tx-3

[ snip ]

Vijayakannan Ayyathurai (2):
net: stmmac: add ethtool per-queue statistic framework
net: stmmac: add ethtool per-queue irq statistic support

Voon Weifeng (1):
net: stmmac: fix INTR TBU status affecting irq count statistic

 drivers/net/ethernet/stmicro/stmmac/common.h  | 13 ++++
 .../net/ethernet/stmicro/stmmac/dwmac4_lib.c  |  7 +-
 .../ethernet/stmicro/stmmac/stmmac_ethtool.c  | 67 ++++++++++++++++++-
 .../net/ethernet/stmicro/stmmac/stmmac_main.c |  5 ++
 4 files changed, 89 insertions(+), 3 deletions(-)

base-commit: e4637f621203cb482f3ddb590cfe9f65045d92a6

Signature · 1 line
2.17.1