Skip to content

Two chardev with fdset fixes

Michal Privoznik qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2chardev: Propagate error from logfile openingchardev/char.c+2 -53 replies
2/2monitor: Report EBADFD if fdset contains invalid FDmonitor/misc.c+1 -13 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéMarc-André Lureau
1/2R-b R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] Two chardev with fdset fixes

I was working on libvirt, trying to make it pass a pre-opened FD for a chardev's logfile. I've spent non-negligible amount of time trying to figure out why I was getting EACCESS error when QEMU definitely was able to access the FD. Well, found the problem and here is my attempt to save future me from figuring it out again.

NB, I'm not fully convinced that EBADFD is the best value, but anything is better than EACCESS.

Michal Privoznik (2):
chardev: Propagate error from logfile opening
monitor: Report EBADFD if fdset contains invalid FD

 chardev/char.c | 7 ++-----
 monitor/misc.c | 2 +-
 2 files changed, 3 insertions(+), 6 deletions(-)
Signature · 1 line
2.31.1