Skip to content

mptcp: minor receive path optimization

Paolo Abeni mptcp 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 4 repliesIn review
  2. v10 of 4 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- fixed = -> |= (Mat)
- fixed bug in ADD_ADDR processing (still in 3/4)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4mptcp: do not set unconditionally csum_reqd on incoming optnet/mptcp/options.c+1 -30 replies
2/4mptcp: better binary layout for mptcp_options_receivednet/mptcp/options.c net/mptcp/protocol.h+13 -150 replies
3/4mptcp: consolidate in_opt sub-options fields in a bitmasknet/mptcp/options.c net/mptcp/protocol.c net/mptcp/protocol.h +1 more+63 -730 replies
4/4mptcp: optimize the input options processing.net/mptcp/options.c+36 -343 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchMat Martineau
1/4
2/4
3/4
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 mptcp-next 0/4] mptcp: minor receive path optimization

This series aims at closing:

https://github.com/multipath-tcp/mptcp_net-next/issues/42

The relevant code is introduced by patch 4/4.

Do do the above in hopefully clean way, the series needs some changes to the input options struct. That means a lot of noise in the option-related code in the previous patches, anyhow no functional change is intended here.

v1 -> v2:
- fixed = -> |= (Mat)
- fixed bug in ADD_ADDR processing (still in 3/4)

Paolo Abeni (4):
mptcp: do not set unconditionally csum_reqd on incoming opt
mptcp: better binary layout for mptcp_options_received
mptcp: consolidate in_opt sub-options fields in a bitmask
mptcp: optimize the input options processing.

 net/mptcp/options.c  | 140 +++++++++++++++++++------------------------
 net/mptcp/protocol.c |   4 +-
 net/mptcp/protocol.h |  36 ++++++-----
 net/mptcp/subflow.c  |  40 +++++++------
 4 files changed, 104 insertions(+), 116 deletions(-)
Signature · 1 line
2.26.3