Skip to content

gpio: mpc8xxx: Fix 3 errors related to the error handling path of the 'mpc8xxx_probe()'

Christophe JAILLET kernel-janitors linux-gpio lkml 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3gpio: mpc8xxx: Fix a resources leak in the error handling path of 'mpc8xxx_probe()'drivers/gpio/gpio-mpc8xxx.c+2 -01 reply
2/3gpio: mpc8xxx: Fix a potential double iounmap call in 'mpc8xxx_probe()'drivers/gpio/gpio-mpc8xxx.c+4 -71 reply
3/3gpio: mpc8xxx: Use 'devm_gpiochip_add_data()' to simplify the code and avoid a leakdrivers/gpio/gpio-mpc8xxx.c+1 -31 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] gpio: mpc8xxx: Fix 3 errors related to the error handling path of the 'mpc8xxx_probe()'

This has been split in 3 patches because:
- the root issue of patch 1 and 3 is not the same commit as the one for patch 2.
- the strategy to fix the issues is not the same
- patch 1: add a new call in the rror handling path
- patch 3: switch to a resource managed function

They could be merged together if easier to review. The subject would then be something like "gpio: mpc8xxx: Fix the error handling path of 'mpc8xxx_probe()'"

If prefered, 'devm_add_action_or_reset()' could be used to switch the probe to a fully managed resource function and remove the 'remove' function. That's mostly a matter of taste.

If such an option is preferred, I'm a bit puzzled by the 'irq_set_chained_handler_and_data()' call in the remove function because I don't see why it is there.
Also see the comment at the end of patch 1 also related to this function call.

Christophe JAILLET (3):
gpio: mpc8xxx: Fix a resources leak in the error handling path of

    'mpc8xxx_probe()'
  gpio: mpc8xxx: Fix a potential double iounmap call in
    'mpc8xxx_probe()'

gpio: mpc8xxx: Use 'devm_gpiochip_add_data()' to simplify the code and
avoid a leak

 drivers/gpio/gpio-mpc8xxx.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)
Signature · 1 line
2.30.2