Skip to content

introduce QArray

Christian Schoenebeck qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 8 repliesIn review
  2. v25 patches 18 repliesSuperseded
  3. v15 patches 3 repliesSuperseded

Changes in v3 from the cover letter

* Refactor QArrayRef() -> QARRAY_REF() [patch 1], [patch 5].

* Commit log: Add more thorough explanation for the motivation of QArray, along with example for advantage over GArray [patch 1].

* Commit log: Add reason for using MIT license for qarray.h instead of the standard QEMU license GPLv2+ [patch 1].

* API doc comments: use 'size_t' type consistently in API doc example code [patch 1].

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5qemu/qarray.h: introduce QArrayinclude/qemu/qarray.h+154 -00 replies
2/5qemu/qarray.h: check scalar type in QARRAY_CREATE()include/qemu/qarray.h+6 -00 replies
3/59pfs: make V9fsString usable via QArray APIfsdev/9p-marshal.c fsdev/9p-marshal.h+5 -00 replies
4/59pfs: make V9fsPath usable via QArray APIfsdev/file-op-9p.h hw/9pfs/9p.c+4 -00 replies
5/59pfs: use QArray in v9fs_walk()hw/9pfs/9p.c+5 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/5] introduce QArray

Patches 1 and 2 introduce include/qemu/qarray.h which implements a deep auto free mechanism for arrays. See commit log of patch 1 for a detailed explanation and motivation for introducing QArray.

Patches 3..5 are provided (e.g. as example) for 9p being the first user of this new QArray API. These particular patches 3..5 are rebased on my current 9p queue: https://github.com/cschoenebeck/qemu/commits/9p.next
which are basically just the following two queued patches:

https://github.com/cschoenebeck/qemu/commit/7772715d43908235940f5b7dec68d0458b1ccdf4
https://github.com/cschoenebeck/qemu/commit/838b55e392ea7d52e714fdba1db777f658aee2cc

v2 -> v3:

* Refactor QArrayRef() -> QARRAY_REF() [patch 1], [patch 5].

* Commit log: Add more thorough explanation for the motivation of QArray, along with example for advantage over GArray [patch 1].

* Commit log: Add reason for using MIT license for qarray.h instead of the standard QEMU license GPLv2+ [patch 1].

* API doc comments: use 'size_t' type consistently in API doc example code [patch 1].

v1 -> v2:

* Minor API comment changes [patch 1].

* Perform strong type check by using __builtin_types_compatible_p() instead of a weak check using sizeof() [patch 2].

Christian Schoenebeck (5):
qemu/qarray.h: introduce QArray qemu/qarray.h: check scalar type in QARRAY_CREATE() 9pfs: make V9fsString usable via QArray API 9pfs: make V9fsPath usable via QArray API 9pfs: use QArray in v9fs_walk()

 fsdev/9p-marshal.c    |   2 +
 fsdev/9p-marshal.h    |   3 +
 fsdev/file-op-9p.h    |   2 +
 hw/9pfs/9p.c          |  19 ++---
 include/qemu/qarray.h | 160 ++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 174 insertions(+), 12 deletions(-)
 create mode 100644 include/qemu/qarray.h
Signature · 1 line
2.20.1